Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KeyError encountered on unknown attributes #22600

Merged

Conversation

mrjerryjohns
Copy link
Contributor

@mrjerryjohns mrjerryjohns commented Sep 13, 2022

This removes the KeyError exception that is thrown when the Python cluster cache encounters an attribute that it doesn't have schema for. This occurs for some of the extended attributes in the test cluster that are not actually defined in schema.

This ensures that we don't abruptly terminate attribute processing when running tests against the all clusters app.

Also removes a bunch of over-zealous prints that serve to confuse and distract than they are helpful.

Testing

Ran against all-clusters-app, ensured warnings and exceptions are no longer thrown.

This removes the KeyError exception that is thrown when the Python
cluster cache encounters an attribute that it doesn't have schema for.
This occurs for some of the extended attributes in the test cluster that
are not actually defined in schema.

This ensures that we don't abruptly terminate attribute processing when
running tests against the all clusters app.
@andy31415
Copy link
Contributor

Accepted for 1.0: python specific, does not affect core SDK. Helps testability and general integration by avoiding errors being thrown on normal operations.

@github-actions
Copy link

github-actions bot commented Sep 13, 2022

PR #22600: Size comparison from abafb40 to 4d1dc35

Increases (3 builds for bl602, cc13x2_26x2, telink)
platform target config section abafb40 4d1dc353 change % change
bl602 lighting-app bl602 .text 1067054 1067056 2 0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 179008 179016 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812984 812992 8 0.0
text 574372 574374 2 0.0
Decreases (2 builds for bl602, cc13x2_26x2)
platform target config section abafb40 4d1dc353 change % change
bl602 lighting-app bl602+rpc (read/write) 1457274 1457266 -8 -0.0
.text 1098660 1098656 -4 -0.0
cc13x2_26x2 shell LP_CC2652R7 (read only) 667926 667918 -8 -0.0
.text 581492 581484 -8 -0.0
Full report (20 builds for bl602, bl702, cc13x2_26x2, k32w, linux, qpg, telink)
platform target config section abafb40 4d1dc353 change % change
bl602 lighting-app bl602 (read/write) 1411814 1411814 0 0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1067054 1067056 2 0.0
bl602+rpc (read/write) 1457274 1457266 -8 -0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1098660 1098656 -4 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1187155 1187155 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1499760 1499760 0 0.0
.debug_aranges 133048 133048 0 0.0
.debug_frame 486288 486288 0 0.0
.debug_info 37815372 37815372 0 0.0
.debug_line 5245919 5245919 0 0.0
.debug_loc 3362384 3362384 0 0.0
.debug_ranges 360176 360176 0 0.0
.debug_str 3444963 3444963 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 115944 115944 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564298 564298 0 0.0
.symtab 171520 171520 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956472 956472 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1282939 1282939 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4792 4792 0 0.0
.debug_abbrev 1637329 1637329 0 0.0
.debug_aranges 140552 140552 0 0.0
.debug_frame 511664 511664 0 0.0
.debug_info 41718972 41718972 0 0.0
.debug_line 5620333 5620333 0 0.0
.debug_loc 3555115 3555115 0 0.0
.debug_ranges 382632 382632 0 0.0
.debug_str 3840930 3840930 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129336 129336 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 623471 623471 0 0.0
.symtab 189328 189328 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030034 1030034 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676883 676883 0 0.0
(read/write) 174540 174540 0 0.0
.bss 74316 74316 0 0.0
.data 3380 3380 0 0.0
.rodata 89395 89395 0 0.0
.text 587176 587176 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641603 641603 0 0.0
(read/write) 157884 157884 0 0.0
.bss 73588 73588 0 0.0
.data 3380 3380 0 0.0
.rodata 78547 78547 0 0.0
.text 562736 562736 0 0.0
lock-ftd LP_CC2652R7 (read only) 678015 678015 0 0.0
(read/write) 163720 163720 0 0.0
.bss 71516 71516 0 0.0
.data 3304 3304 0 0.0
.rodata 77247 77247 0 0.0
.text 600288 600288 0 0.0
lock-mtd LP_CC2652R7 (read only) 660999 660999 0 0.0
(read/write) 176424 176424 0 0.0
.bss 67204 67204 0 0.0
.data 3304 3304 0 0.0
.rodata 102527 102527 0 0.0
.text 557992 557992 0 0.0
pump-app LP_CC2652R7 (read only) 686851 686851 0 0.0
(read/write) 155588 155588 0 0.0
.bss 71452 71452 0 0.0
.data 3296 3296 0 0.0
.rodata 90275 90275 0 0.0
.text 596092 596092 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671343 671343 0 0.0
(read/write) 171208 171208 0 0.0
.bss 71564 71564 0 0.0
.data 3292 3292 0 0.0
.rodata 85831 85831 0 0.0
.text 585032 585032 0 0.0
shell LP_CC2652R7 (read only) 667926 667918 -8 -0.0
(read/write) 179008 179016 8 0.0
.bss 76628 76628 0 0.0
.data 3376 3376 0 0.0
.rodata 86118 86118 0 0.0
.text 581492 581484 -8 -0.0
k32w light k32w0+release (read/write) 648860 648860 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 573352 573352 0 0.0
lock k32w0+release (read/write) 706048 706048 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630084 630084 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10343756 10343756 0 0.0
(read/write) 705649 705649 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 650024 650024 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 502972 502972 0 0.0
.text 8187716 8187716 0 0.0
thermostat-no-ble arm64 (read only) 2366020 2366020 0 0.0
(read/write) 141905 141905 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76160 76160 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141452 141452 0 0.0
.text 1986480 1986480 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129980 1129980 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577076 577076 0 0.0
lock-app qpg6105+debug (read/write) 1100992 1100992 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548092 548092 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812984 812992 8 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574372 574374 2 0.0
lighting-app tlsr9518adk80d (read/write) 834896 834896 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592502 592502 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843140 843140 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598764 598764 0 0.0

@andy31415 andy31415 merged commit c6cde56 into project-chip:master Sep 15, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
This removes the KeyError exception that is thrown when the Python
cluster cache encounters an attribute that it doesn't have schema for.
This occurs for some of the extended attributes in the test cluster that
are not actually defined in schema.

This ensures that we don't abruptly terminate attribute processing when
running tests against the all clusters app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tooling] Doing wildcard reads in Python keeps returning 'KeyError'
3 participants