-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KeyError
encountered on unknown attributes
#22600
Merged
andy31415
merged 1 commit into
project-chip:master
from
mrjerryjohns:python/unknown-attribute-exception
Sep 15, 2022
Merged
Remove KeyError
encountered on unknown attributes
#22600
andy31415
merged 1 commit into
project-chip:master
from
mrjerryjohns:python/unknown-attribute-exception
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the KeyError exception that is thrown when the Python cluster cache encounters an attribute that it doesn't have schema for. This occurs for some of the extended attributes in the test cluster that are not actually defined in schema. This ensures that we don't abruptly terminate attribute processing when running tests against the all clusters app.
tcarmelveilleux
approved these changes
Sep 13, 2022
andy31415
approved these changes
Sep 13, 2022
Accepted for 1.0: python specific, does not affect core SDK. Helps testability and general integration by avoiding errors being thrown on normal operations. |
PR #22600: Size comparison from abafb40 to 4d1dc35 Increases (3 builds for bl602, cc13x2_26x2, telink)
Decreases (2 builds for bl602, cc13x2_26x2)
Full report (20 builds for bl602, bl702, cc13x2_26x2, k32w, linux, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
This removes the KeyError exception that is thrown when the Python cluster cache encounters an attribute that it doesn't have schema for. This occurs for some of the extended attributes in the test cluster that are not actually defined in schema. This ensures that we don't abruptly terminate attribute processing when running tests against the all clusters app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
KeyError
exception that is thrown when the Python cluster cache encounters an attribute that it doesn't have schema for. This occurs for some of the extended attributes in the test cluster that are not actually defined in schema.This ensures that we don't abruptly terminate attribute processing when running tests against the all clusters app.
Also removes a bunch of over-zealous prints that serve to confuse and distract than they are helpful.
Testing
Ran against all-clusters-app, ensured warnings and exceptions are no longer thrown.