-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add TestOnlyCommissionableDataProvider to pychip_server_native_init() #22498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22498: Size comparison from 7475f00 to 45902de Increases (1 build for esp32)
Decreases (10 builds for bl602, esp32, psoc6, telink)
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sandeepmistry
force-pushed
the
issue-21969-fix
branch
from
September 9, 2022 14:17
45902de
to
5b82ce3
Compare
PR #22498: Size comparison from bf12fce to 5b82ce3 Increases (4 builds for esp32, psoc6, qpg)
Decreases (6 builds for bl602, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sandeepmistry
force-pushed
the
issue-21969-fix
branch
from
September 14, 2022 19:24
e5e3b16
to
5de23ef
Compare
sandeepmistry
changed the title
[WIP] Python: Add LinuxCommissionableDataProvider to pychip_server_native_init()
[WIP] Python: Add TestOnlyCommissionableDataProvider to pychip_server_native_init()
Sep 14, 2022
PR #22498: Size comparison from 6ebd6b6 to 5de23ef Increases (7 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sandeepmistry
changed the title
[WIP] Python: Add TestOnlyCommissionableDataProvider to pychip_server_native_init()
Python: Add TestOnlyCommissionableDataProvider to pychip_server_native_init()
Sep 15, 2022
@mrjerryjohns this should be good to go now, with the changes in 5f3f72c. The Python Lighting app example is now functional. |
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple and
gjc13
September 15, 2022 19:14
pullapprove
bot
requested review from
saurabhst,
tecimovic,
yufengwangca,
selissia,
wbschiller,
turon,
woody-apple,
vijs,
xylophone21 and
vivien-apple
September 15, 2022 19:17
…AttributeChangeCallback)
sandeepmistry
force-pushed
the
issue-21969-fix
branch
from
September 16, 2022 15:21
0feaf9c
to
ac08db0
Compare
PR #22498: Size comparison from 69551a1 to ac08db0 Increases (7 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (5 builds for bl602, cc13x2_26x2, efr32, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mrjerryjohns
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
This change adds a
LinuxCommissionableDataProvider
to the Python chip server similar toexamples/platform/linux/AppMain.cpp
to prevent issue #21969. It also includes the changes from PR #22494 as they are needed to build.Note: There is most likely a more eloquent platform independent way to do this, but wanted to get the discussion going.
cc/ @mrjerryjohns