-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require issues for all PRs #22457
Require issues for all PRs #22457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should not be a hard enforcement: hotfixes or trivial changes should be ok.
Is it possible to add some alternate like 'No Issue reason: ...' to the check? So one or the other? |
HotFix will override this, or Fast track. Per our TT meetings, let's see how this goes, we can grant exceptions, but exceptions should be exceptional :) |
Trivial changes should not be allowed if they're not part of the categories already approved by the TT. Renames were already pushed out, as an example of this. |
Removing review: side discussion we agreed on: describe what we hope to get from issues (trackability/better documented changes/...) and review at a later point if this was met or productivity drawbacks are too much
PR #22457: Size comparison from 383c416 to 88aad70 Increases (2 builds for nrfconnect, telink)
Full report (14 builds for bl602, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #22457: Size comparison from 383c416 to b4d3e36 Increases (2 builds for nrfconnect, telink)
Decreases (3 builds for bl602, qpg)
Full report (14 builds for bl602, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #22457: Size comparison from 383c416 to 23af4bb Increases (8 builds for bl602, nrfconnect, psoc6, telink)
Decreases (2 builds for esp32)
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* First commit * Updating text * Adding workflow issue type * Updating spaces * Fixing spaces, adding feature * Updating types
Problem
Resolving: #22456
Change overview
Updating pull approve, and adding a new action
Testing
CI