-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in SubscribeEvent function that results in compilation failure #22434
Conversation
PR #22434: Size comparison from e535710 to 946cb69 Increases (4 builds for cc13x2_26x2, nrfconnect, psoc6, qpg)
Decreases (6 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Hello @andy31415 , I have made the requested changes. Please advise on where exactly I should add the issue link #22467 because CI seems to be failing on parsing the issue link |
@spalas1996 You need "Fixes #NNNN" in that exact form in the PR description... I added that here. |
Thanks @bzbarsky-apple |
Accepted for v1: compile error fix. |
Problem
Fix bug in SubscribeEvent function.
Fixes #22467
Change overview
Fix bug in SubscribeEvent function that results in compilation failure
There is a bug in the SubscribeEvent function in CHIPCluster.h:
connectedhomeip/src/controller/CHIPCluster.h
Line 348 in 342ba68
While trying to use this function I get the following compilation error:
vendor/csa-iot/connectedhomeip/src/controller/CHIPCluster.h:384:16: error: no matching function for call to 'SubscribeEvent'
return Controller::SubscribeEvent(&mExchangeManager, mSession.Get().Value(), mEndpoint, onReportCb,
By changing this line of code
connectedhomeip/src/controller/CHIPCluster.h
Line 369 in 342ba68
to
auto onSubscriptionEstablishedCb = [context, subscriptionEstablishedCb](const app::ReadClient & readClient)
compilation is successful
Testing
How was this tested? (at least one bullet point required)