Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the naming of the "get the attestation challenge" Darwin function. #22430

Merged
merged 1 commit into from
Sep 7, 2022
+3 −3
Merged

Fix the naming of the "get the attestation challenge" Darwin function. #22430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/darwin/Framework/CHIP/MTRDeviceController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ typedef void (^MTRDeviceConnectionCallback)(MTRBaseDevice * _Nullable device, NS
/**
* Return the attestation challenge for the secure session of the device being commissioned.
*
* Attempts to retrieve the generated attestation challenge from a commissionee with the given Device ID.
* Attempts to retrieve the attestation challenge for a commissionee with the given Device ID.
* Returns nil if given Device ID does not match an active commissionee, or if a Secure Session is not availale.
*/
- (nullable NSData *)generateAttestationChallengeForDeviceId:(uint64_t)deviceId;
- (nullable NSData *)fetchAttestationChallengeForDeviceId:(uint64_t)deviceId;

/**
* Compute a PASE verifier and passcode ID for the desired setup pincode.
Expand Down
2 changes: 1 addition & 1 deletion src/darwin/Framework/CHIP/MTRDeviceController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ - (nullable NSData *)computePaseVerifier:(uint32_t)setupPincode iterations:(uint
return result;
}

- (nullable NSData *)generateAttestationChallengeForDeviceId:(uint64_t)deviceId
- (nullable NSData *)fetchAttestationChallengeForDeviceId:(uint64_t)deviceId
{
VerifyOrReturnValue([self checkIsRunning], nil);

Expand Down