-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEKEN] add beken examples/platform files #22405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add beken examples/platform files * modify beken examples/lighting-app files
zhengyaohan
force-pushed
the
meger-test
branch
from
September 6, 2022 07:31
a3dcebb
to
c71da44
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
September 6, 2022 07:31
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
September 6, 2022 07:31
PR #22405: Size comparison from 8edae2d to c71da44 Increases (1 build for psoc6)
Decreases (3 builds for esp32, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Accepted for 1.0: platform change |
andy31415
reviewed
Sep 6, 2022
andy31415
reviewed
Sep 6, 2022
andy31415
reviewed
Sep 6, 2022
andy31415
reviewed
Sep 6, 2022
andy31415
reviewed
Sep 6, 2022
andy31415
reviewed
Sep 6, 2022
* remove commented-out code * modify class members attr
andy31415
approved these changes
Sep 9, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* [BEKEN] add beken examples/platform files * add beken examples/platform files * modify beken examples/lighting-app files * [BEKEN] optimize by reviewer's suggestion * remove commented-out code * modify class members attr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview