Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVE2] Fix kMaxThreadNameLength #22367

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

woody-apple
Copy link
Contributor

Fixes #22336

kMaxThreadNameLength currently set to 32. Spec mandates it to 8

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

PR #22367: Size comparison from 0962e0b to 227889b

Increases (5 builds for bl602, cc13x2_26x2, nrfconnect, telink)
platform target config section 0962e0b8 227889b change % change
bl602 lighting-app bl602+rpc .text 1082848 1082852 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672371 672379 8 0.0
.text 583308 583316 8 0.0
shell LP_CC2652R7 (read only) 665078 665086 8 0.0
.text 579068 579076 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814124 814128 4 0.0
telink light-switch-app tlsr9518adk80d text 571362 571364 2 0.0
Decreases (4 builds for cc13x2_26x2, esp32, telink)
platform target config section 0962e0b8 227889b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 179140 179132 -8 -0.0
shell LP_CC2652R7 (read/write) 181952 181944 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1030036 1030034 -2 -0.0
.flash.text 1030036 1030034 -2 -0.0
telink lighting-app tlsr9518adk80d text 589488 589486 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0962e0b8 227889b change % change
bl602 lighting-app bl602 (read/write) 1383938 1383938 0 0.0
.bss 120290 120290 0 0.0
.data 4480 4480 0 0.0
.text 1051092 1051092 0 0.0
bl602+rpc (read/write) 1429450 1429450 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1082848 1082852 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672371 672379 8 0.0
(read/write) 179140 179132 -8 -0.0
.bss 74404 74404 0 0.0
.data 3372 3372 0 0.0
.rodata 88747 88747 0 0.0
.text 583308 583316 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637763 637763 0 0.0
(read/write) 157980 157980 0 0.0
.bss 73692 73692 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559460 559460 0 0.0
lock-ftd LP_CC2652R7 (read only) 674079 674079 0 0.0
(read/write) 167648 167648 0 0.0
.bss 71508 71508 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596928 596928 0 0.0
lock-mtd LP_CC2652R7 (read only) 656823 656823 0 0.0
(read/write) 180592 180592 0 0.0
.bss 67196 67196 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554584 554584 0 0.0
pump-app LP_CC2652R7 (read only) 684751 684751 0 0.0
(read/write) 157784 157784 0 0.0
.bss 71548 71548 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594308 594308 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669243 669243 0 0.0
(read/write) 173412 173412 0 0.0
.bss 71668 71668 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583248 583248 0 0.0
shell LP_CC2652R7 (read only) 665078 665086 8 0.0
(read/write) 181952 181944 -8 -0.0
.bss 76724 76724 0 0.0
.data 3376 3376 0 0.0
.rodata 85694 85694 0 0.0
.text 579068 579076 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586118 586118 0 0.0
.app_xip_area 462752 462752 0 0.0
.bss 65800 65800 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591902 591902 0 0.0
.app_xip_area 463752 463752 0 0.0
.bss 70584 70584 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599034 599034 0 0.0
.app_xip_area 476388 476388 0 0.0
.bss 65112 65112 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1104012 1104012 0 0.0
.bss 136148 136148 0 0.0
.data 2068 2068 0 0.0
.text 965772 965772 0 0.0
BRD4161A+rpc (read/write) 1158264 1158264 0 0.0
.bss 152836 152836 0 0.0
.data 2280 2280 0 0.0
.text 1003128 1003128 0 0.0
BRD4161A+rs911x (read/write) 996672 996672 0 0.0
.bss 168912 168912 0 0.0
.data 2056 2056 0 0.0
.text 825684 825684 0 0.0
lock-app BRD4161A+wf200 (read/write) 1145916 1145916 0 0.0
.bss 151992 151992 0 0.0
.data 2064 2064 0 0.0
.text 991840 991840 0 0.0
window-app BRD4161A (read/write) 1095420 1095420 0 0.0
.bss 137588 137588 0 0.0
.data 2096 2096 0 0.0
.text 955716 955716 0 0.0
esp32 all-clusters-app c3devkit (read only) 1030036 1030034 -2 -0.0
(read/write) 1488674 1488674 0 0.0
.dram0.bss 70864 70864 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217776 217776 0 0.0
.flash.text 1030036 1030034 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1083395 1083395 0 0.0
(read/write) 490632 490632 0 0.0
.dram0.bss 76376 76376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248116 248116 0 0.0
.flash.text 1078011 1078011 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 645524 645524 0 0.0
.bss 70232 70232 0 0.0
.data 2044 2044 0 0.0
.text 570520 570520 0 0.0
lock k32w0+release (read/write) 703044 703044 0 0.0
.bss 70704 70704 0 0.0
.data 2052 2052 0 0.0
.text 627560 627560 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10299772 10299772 0 0.0
(read/write) 704593 704593 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649248 649248 0 0.0
.dynamic 560 560 0 0.0
.got 13816 13816 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 498076 498076 0 0.0
.text 8150628 8150628 0 0.0
thermostat-no-ble arm64 (read only) 2357076 2357076 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140524 140524 0 0.0
.text 1978832 1978832 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215076 215076 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180099 1180099 0 0.0
bss 143759 143759 0 0.0
rodata 143268 143268 0 0.0
text 814124 814128 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159975 1159975 0 0.0
bss 142996 142996 0 0.0
rodata 134944 134944 0 0.0
text 803116 803116 0 0.0
p6 all-clusters-app default (read only) 842104 842104 0 0.0
(read/write) 1739044 1739044 0 0.0
.bss 188584 188584 0 0.0
.data 2656 2656 0 0.0
.text 1539416 1539416 0 0.0
all-clusters-minimal-app default (read only) 842824 842824 0 0.0
(read/write) 1683052 1683052 0 0.0
.bss 187864 187864 0 0.0
.data 2656 2656 0 0.0
.text 1484144 1484144 0 0.0
light-app default (read only) 851168 851168 0 0.0
(read/write) 1600340 1600340 0 0.0
.bss 179728 179728 0 0.0
.data 2448 2448 0 0.0
.text 1409776 1409776 0 0.0
lock-app default (read only) 846136 846136 0 0.0
(read/write) 1638060 1638060 0 0.0
.bss 184744 184744 0 0.0
.data 2464 2464 0 0.0
.text 1442464 1442464 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808816 808816 0 0.0
bss 71480 71480 0 0.0
noinit 43488 43488 0 0.0
text 571362 571364 2 0.0
lighting-app tlsr9518adk80d (read/write) 830792 830792 0 0.0
bss 72336 72336 0 0.0
noinit 43488 43488 0 0.0
text 589488 589486 -2 -0.0

@github-actions github-actions bot added the tools label Sep 8, 2022
@andy31415
Copy link
Contributor

@woody-apple - this PR cherrypick is strange: it contains some cert deltas together with an expected kMaxThreadnameLength change. Do we know what happened?

@emargolis - history says you maybe changed things?

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

PR #22367: Size comparison from 9f4d680 to 81d9453

Increases (1 build for nrfconnect)
platform target config section 9f4d680 81d9453 change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803112 803116 4 0.0
Full report (7 builds for mbed, nrfconnect, p6)
platform target config section 9f4d680 81d9453 change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215076 215076 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180099 1180099 0 0.0
bss 143759 143759 0 0.0
rodata 143268 143268 0 0.0
text 814128 814128 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159975 1159975 0 0.0
bss 142996 142996 0 0.0
rodata 134944 134944 0 0.0
text 803112 803116 4 0.0
p6 all-clusters-app default (read only) 842104 842104 0 0.0
(read/write) 1739044 1739044 0 0.0
.bss 188584 188584 0 0.0
.data 2656 2656 0 0.0
.text 1539416 1539416 0 0.0
all-clusters-minimal-app default (read only) 842824 842824 0 0.0
(read/write) 1683052 1683052 0 0.0
.bss 187864 187864 0 0.0
.data 2656 2656 0 0.0
.text 1484144 1484144 0 0.0
light-app default (read only) 851168 851168 0 0.0
(read/write) 1600340 1600340 0 0.0
.bss 179728 179728 0 0.0
.data 2448 2448 0 0.0
.text 1409776 1409776 0 0.0
lock-app default (read only) 846136 846136 0 0.0
(read/write) 1638060 1638060 0 0.0
.bss 184744 184744 0 0.0
.data 2464 2464 0 0.0
.text 1442464 1442464 0 0.0

@andy31415
Copy link
Contributor

I manually reverted the extra commit.

@github-actions github-actions bot removed the tools label Sep 9, 2022
@andy31415 andy31415 enabled auto-merge (squash) September 9, 2022 13:54
@andy31415 andy31415 disabled auto-merge September 9, 2022 14:06
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

PR #22367: Size comparison from 5e6279c to ac8b62b

Increases (1 build for nrfconnect)
platform target config section 5e6279c ac8b62b change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814168 814172 4 0.0
Decreases (1 build for telink)
platform target config section 5e6279c ac8b62b change % change
telink light-switch-app tlsr9518adk80d (read/write) 808808 808800 -8 -0.0
text 571350 571348 -2 -0.0
Full report (21 builds for bl602, cc13x2_26x2, efr32, k32w, mbed, nrfconnect, telink)
platform target config section 5e6279c ac8b62b change % change
bl602 lighting-app bl602 (read/write) 1383898 1383898 0 0.0
.bss 120290 120290 0 0.0
.data 4480 4480 0 0.0
.text 1051048 1051048 0 0.0
bl602+rpc (read/write) 1429410 1429410 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1082808 1082808 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672379 672379 0 0.0
(read/write) 179132 179132 0 0.0
.bss 74404 74404 0 0.0
.data 3372 3372 0 0.0
.rodata 88747 88747 0 0.0
.text 583316 583316 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637763 637763 0 0.0
(read/write) 157980 157980 0 0.0
.bss 73692 73692 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559460 559460 0 0.0
lock-ftd LP_CC2652R7 (read only) 674079 674079 0 0.0
(read/write) 167648 167648 0 0.0
.bss 71508 71508 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596928 596928 0 0.0
lock-mtd LP_CC2652R7 (read only) 656815 656815 0 0.0
(read/write) 180600 180600 0 0.0
.bss 67196 67196 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554576 554576 0 0.0
pump-app LP_CC2652R7 (read only) 684751 684751 0 0.0
(read/write) 157784 157784 0 0.0
.bss 71548 71548 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594308 594308 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669243 669243 0 0.0
(read/write) 173412 173412 0 0.0
.bss 71668 71668 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583248 583248 0 0.0
shell LP_CC2652R7 (read only) 665086 665086 0 0.0
(read/write) 181944 181944 0 0.0
.bss 76724 76724 0 0.0
.data 3376 3376 0 0.0
.rodata 85694 85694 0 0.0
.text 579076 579076 0 0.0
efr32 lighting-app BRD4161A (read/write) 1103948 1103948 0 0.0
.bss 136148 136148 0 0.0
.data 2068 2068 0 0.0
.text 965708 965708 0 0.0
BRD4161A+rpc (read/write) 1158216 1158216 0 0.0
.bss 152836 152836 0 0.0
.data 2280 2280 0 0.0
.text 1003080 1003080 0 0.0
BRD4161A+rs911x (read/write) 996624 996624 0 0.0
.bss 168912 168912 0 0.0
.data 2056 2056 0 0.0
.text 825636 825636 0 0.0
lock-app BRD4161A+wf200 (read/write) 1145900 1145900 0 0.0
.bss 151992 151992 0 0.0
.data 2064 2064 0 0.0
.text 991824 991824 0 0.0
window-app BRD4161A (read/write) 1095356 1095356 0 0.0
.bss 137588 137588 0 0.0
.data 2096 2096 0 0.0
.text 955652 955652 0 0.0
k32w light k32w0+release (read/write) 645524 645524 0 0.0
.bss 70232 70232 0 0.0
.data 2044 2044 0 0.0
.text 570520 570520 0 0.0
lock k32w0+release (read/write) 703044 703044 0 0.0
.bss 70704 70704 0 0.0
.data 2052 2052 0 0.0
.text 627560 627560 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215076 215076 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180147 1180147 0 0.0
bss 143759 143759 0 0.0
rodata 143268 143268 0 0.0
text 814168 814172 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160023 1160023 0 0.0
bss 142996 142996 0 0.0
rodata 134944 134944 0 0.0
text 803160 803160 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808808 808800 -8 -0.0
bss 71480 71480 0 0.0
noinit 43488 43488 0 0.0
text 571350 571348 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830776 830776 0 0.0
bss 72336 72336 0 0.0
noinit 43488 43488 0 0.0
text 589472 589472 0 0.0

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

PR #22367: Size comparison from b5563e7 to 45a5767

Full report (9 builds for linux, mbed, nrfconnect, p6)
platform target config section b5563e7 45a5767 change % change
linux chip-tool-ipv6only arm64 (read only) 10299916 10299916 0 0.0
(read/write) 704593 704593 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649248 649248 0 0.0
.dynamic 560 560 0 0.0
.got 13816 13816 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 498076 498076 0 0.0
.text 8150772 8150772 0 0.0
thermostat-no-ble arm64 (read only) 2356916 2356916 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140524 140524 0 0.0
.text 1978672 1978672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215076 215076 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180147 1180147 0 0.0
bss 143759 143759 0 0.0
rodata 143268 143268 0 0.0
text 814172 814172 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160023 1160023 0 0.0
bss 142996 142996 0 0.0
rodata 134944 134944 0 0.0
text 803160 803160 0 0.0
p6 all-clusters-app default (read only) 842104 842104 0 0.0
(read/write) 1738996 1738996 0 0.0
.bss 188584 188584 0 0.0
.data 2656 2656 0 0.0
.text 1539368 1539368 0 0.0
all-clusters-minimal-app default (read only) 842824 842824 0 0.0
(read/write) 1683004 1683004 0 0.0
.bss 187864 187864 0 0.0
.data 2656 2656 0 0.0
.text 1484096 1484096 0 0.0
light-app default (read only) 851168 851168 0 0.0
(read/write) 1600292 1600292 0 0.0
.bss 179728 179728 0 0.0
.data 2448 2448 0 0.0
.text 1409728 1409728 0 0.0
lock-app default (read only) 846136 846136 0 0.0
(read/write) 1638012 1638012 0 0.0
.bss 184744 184744 0 0.0
.data 2464 2464 0 0.0
.text 1442416 1442416 0 0.0

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

PR #22367: Size comparison from fff6c23 to f6d277f

Decreases (2 builds for nrfconnect)
platform target config section fff6c23 f6d277f change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814172 814168 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 803160 803156 -4 -0.0
Full report (9 builds for k32w, mbed, nrfconnect, p6)
platform target config section fff6c23 f6d277f change % change
k32w light k32w0+release (read/write) 645524 645524 0 0.0
.bss 70232 70232 0 0.0
.data 2044 2044 0 0.0
.text 570520 570520 0 0.0
lock k32w0+release (read/write) 703044 703044 0 0.0
.bss 70704 70704 0 0.0
.data 2052 2052 0 0.0
.text 627560 627560 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215076 215076 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180147 1180147 0 0.0
bss 143759 143759 0 0.0
rodata 143268 143268 0 0.0
text 814172 814168 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160023 1160023 0 0.0
bss 142996 142996 0 0.0
rodata 134944 134944 0 0.0
text 803160 803156 -4 -0.0
p6 all-clusters-app default (read only) 842104 842104 0 0.0
(read/write) 1738996 1738996 0 0.0
.bss 188584 188584 0 0.0
.data 2656 2656 0 0.0
.text 1539368 1539368 0 0.0
all-clusters-minimal-app default (read only) 842824 842824 0 0.0
(read/write) 1683004 1683004 0 0.0
.bss 187864 187864 0 0.0
.data 2656 2656 0 0.0
.text 1484096 1484096 0 0.0
light-app default (read only) 851168 851168 0 0.0
(read/write) 1600292 1600292 0 0.0
.bss 179728 179728 0 0.0
.data 2448 2448 0 0.0
.text 1409728 1409728 0 0.0
lock-app default (read only) 846136 846136 0 0.0
(read/write) 1638012 1638012 0 0.0
.bss 184744 184744 0 0.0
.data 2464 2464 0 0.0
.text 1442416 1442416 0 0.0

@andy31415 andy31415 merged commit 4128509 into sve-2 Sep 12, 2022
@andy31415 andy31415 deleted the cherry-pick-27526266e652ce4c6d732e612170f37197088148 branch September 12, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants