-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin-framework-tool] Add a shortcut (CTL('_')) to stop the stack w… #22362
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_ShortcutStop
Sep 2, 2022
Merged
[darwin-framework-tool] Add a shortcut (CTL('_')) to stop the stack w… #22362
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_ShortcutStop
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile in interactive mode
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
September 2, 2022 12:46
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
September 2, 2022 12:46
PR #22362: Size comparison from 771f835 to 57c39d9 Decreases (4 builds for efr32, esp32, psoc6)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 2, 2022
andy31415
approved these changes
Sep 2, 2022
Accepted to master: examples change only. |
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…hile in interactive mode (project-chip#22362)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hile in interactive mode
Problem
This PR is similar to #22268. But instead of adding a shortcut to restart the Matter stack, it adds one to stop the Matter stack with the possibility to do a restart afterward (using
Ctrl + ^
).It is sometimes helpful to found/debug some crashes that does not happens when quickly restarting the stack. For example the second step of #22320 shows that a quick restart was not able to get the crash since some actions are a little bit delayed by some dispatch queues but won't crash if the stack is restarted too quickly.
So the reason for this PR is to not have to manually hack the restart method ;)
I'm arguing for v1.0 for the same reason than #22268 in the sense that it does not affect anything from the core SDK and may help to find some bugs related to the stack shutdown.
Change overview
Testing
I have only tested that the stack is correctly turned off when pressing
Ctrl + _
and that it does restart when startingCtrl + ^
.