-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Darwin framework notification when subscription drops. #22351
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:darwin-notify-resubscribe
Sep 3, 2022
Merged
Add a Darwin framework notification when subscription drops. #22351
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:darwin-notify-resubscribe
Sep 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tells the API consumer the reason for the drop and how long we will wait before resubscribing. Fixes project-chip#21613
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
September 1, 2022 21:16
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
September 1, 2022 21:16
pullapprove
bot
added
review - pending
darwin
platform
examples
and removed
examples
darwin
platform
labels
Sep 1, 2022
PR #22351: Size comparison from 0f0e1e9 to 65f28f0 Increases (4 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (2 builds for cc13x2_26x2, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Sep 2, 2022
...rwin/CHIPTool/CHIPTool/View Controllers/Temperature Sensor/TemperatureSensorViewController.m
Show resolved
Hide resolved
bzbarsky-apple
force-pushed
the
darwin-notify-resubscribe
branch
from
September 2, 2022 20:17
ec9426b
to
8bf1fec
Compare
PR #22351: Size comparison from 3dd58ef to 8bf1fec Increases (3 builds for esp32, psoc6)
Decreases (4 builds for nrfconnect, qpg, telink)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 2, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…-chip#22351) * Add a Darwin framework notification when subscription drops. Tells the API consumer the reason for the drop and how long we will wait before resubscribing. Fixes project-chip#21613 * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tells the API consumer the reason for the drop and how long we will wait before resubscribing.
Fixes #21613
Problem
No way to find out about subscription loss when using auto-resubscribe.
Change overview
Add a way to find out.
Testing
Tested using darwin-framework-tool
any subscribe-all-events
. Killed the server app, observed messages like:etc.