Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32] Fix thermostat app build #22346

Merged
merged 1 commit into from
Sep 1, 2022
Merged

[EFR32] Fix thermostat app build #22346

merged 1 commit into from
Sep 1, 2022

Conversation

mkardous-silabs
Copy link
Contributor

Problem

Thermostat example build was broken

Change overview

Fix thermostat build

  • Add missing variable for openthread lib
  • Add LCD init call

Testing

Manual tests with EFR32 MG24 and the thermostat example

@github-actions
Copy link

github-actions bot commented Sep 1, 2022 •
edited
Loading

PR #22346: Size comparison from f011e5a to 85662ec

Increases (7 builds for efr32, esp32, psoc6, qpg)
platform target config section f011e5a 85662ec change % change
efr32 lighting-app BRD4161A (read/write) 1108456 1108480 24 0.0
.text 970032 970056 24 0.0
BRD4161A+rpc (read/write) 972148 972172 24 0.0
.text 819032 819056 24 0.0
BRD4161A+rs911x (read/write) 1002164 1002196 32 0.0
.text 830912 830944 32 0.0
lock-app BRD4161A+wf200 (read/write) 1150280 1150304 24 0.0
.text 995940 995964 24 0.0
esp32 all-clusters-app c3devkit (read only) 1033902 1033904 2 0.0
.flash.text 1033902 1033904 2 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26711523 26711524 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1129156 1129164 8 0.0
.text 576252 576260 8 0.0
Decreases (3 builds for esp32, psoc6, telink)
platform target config section f011e5a 85662ec change % change
esp32 all-clusters-app m5stack (read/write) 490924 490916 -8 -0.0
.flash.rodata 247464 247456 -8 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22290176 22290175 -1 -0.0
telink lighting-app tlsr9518adk80d (read/write) 830912 830904 -8 -0.0
text 589598 589594 -4 -0.0
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section f011e5a 85662ec change % change
bl602 lighting-app bl602 (read/write) 1386150 1386150 0 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052544 1052544 0 0.0
bl602+rpc (read/write) 1431806 1431806 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084304 1084304 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675351 675351 0 0.0
(read/write) 176056 176056 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89215 89215 0 0.0
.text 585824 585824 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640063 640063 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78367 78367 0 0.0
.text 561376 561376 0 0.0
lock-ftd LP_CC2652R7 (read only) 676411 676411 0 0.0
(read/write) 165308 165308 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77067 77067 0 0.0
.text 598864 598864 0 0.0
lock-mtd LP_CC2652R7 (read only) 659371 659371 0 0.0
(read/write) 178036 178036 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102323 102323 0 0.0
.text 556568 556568 0 0.0
pump-app LP_CC2652R7 (read only) 685239 685239 0 0.0
(read/write) 157184 157184 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90079 90079 0 0.0
.text 594676 594676 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669731 669731 0 0.0
(read/write) 172804 172804 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85627 85627 0 0.0
.text 583624 583624 0 0.0
shell LP_CC2652R7 (read only) 666002 666002 0 0.0
(read/write) 180924 180924 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85770 85770 0 0.0
.text 579916 579916 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586874 586874 0 0.0
.app_xip_area 463532 463532 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592626 592626 0 0.0
.app_xip_area 464500 464500 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599810 599810 0 0.0
.app_xip_area 477188 477188 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108456 1108480 24 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970032 970056 24 0.0
BRD4161A+rpc (read/write) 972148 972172 24 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819032 819056 24 0.0
BRD4161A+rs911x (read/write) 1002164 1002196 32 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830912 830944 32 0.0
lock-app BRD4161A+wf200 (read/write) 1150280 1150304 24 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995940 995964 24 0.0
window-app BRD4161A (read/write) 1099720 1099720 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959832 959832 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033902 1033904 2 0.0
(read/write) 1493646 1493646 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218160 218160 0 0.0
.flash.text 1033902 1033904 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086503 1086503 0 0.0
(read/write) 490924 490916 -8 -0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247464 247456 -8 -0.0
.flash.text 1081119 1081119 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648204 648204 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572696 572696 0 0.0
lock k32w0+release (read/write) 705200 705200 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629236 629236 0 0.0
linux all-clusters-app debug (read only) 3044537 3044537 0 0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275435 275435 0 0.0
.text 2589666 2589666 0 0.0
all-clusters-minimal-app debug (read only) 2880337 2880337 0 0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275595 275595 0 0.0
.text 2428082 2428082 0 0.0
bridge-app debug+rpc (read only) 2378617 2378617 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204296 204296 0 0.0
.text 2011410 2011410 0 0.0
chip-tool debug (read only) 10943593 10943593 0 0.0
(read/write) 657320 657320 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622288 622288 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 569013 569013 0 0.0
.text 8853764 8853764 0 0.0
chip-tool-ipv6only arm64 (read only) 10318484 10318484 0 0.0
(read/write) 705169 705169 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649784 649784 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 499252 499252 0 0.0
.text 8166820 8166820 0 0.0
lighting-app debug+rpc (read only) 2603497 2603497 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221104 221104 0 0.0
.text 2211202 2211202 0 0.0
lock-app debug (read only) 2586497 2586497 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238128 238128 0 0.0
.text 2181426 2181426 0 0.0
ota-provider-app debug (read only) 2363737 2363737 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 210104 210104 0 0.0
.text 1989874 1989874 0 0.0
ota-requestor-app debug (read only) 2529001 2529001 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216832 216832 0 0.0
.text 2139266 2139266 0 0.0
shell debug (read only) 2612841 2612841 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235538 235538 0 0.0
.text 2218594 2218594 0 0.0
thermostat-no-ble arm64 (read only) 2362532 2362532 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141404 141404 0 0.0
.text 1983088 1983088 0 0.0
tv-app debug (read only) 3190953 3190953 0 0.0
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 260104 260104 0 0.0
.text 2740818 2740818 0 0.0
tv-casting-app debug (read only) 5509393 5509393 0 0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 345041 345041 0 0.0
.text 4892450 4892450 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455184 2455184 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417828 1417828 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181087 1181087 0 0.0
bss 143641 143641 0 0.0
rodata 143504 143504 0 0.0
text 815000 815000 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160267 1160267 0 0.0
bss 142868 142868 0 0.0
rodata 135092 135092 0 0.0
text 803392 803392 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742700 1742700 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221450 1221450 0 0.0
.debug_aranges 111712 111712 0 0.0
.debug_frame 372900 372900 0 0.0
.debug_info 26711523 26711524 1 0.0
.debug_line 3656847 3656847 0 0.0
.debug_loc 3571715 3571715 0 0.0
.debug_ranges 338128 338128 0 0.0
.debug_str 3426920 3426920 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570576 570576 0 0.0
.symtab 421488 421488 0 0.0
.text 1542928 1542928 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685900 1685900 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213289 1213289 0 0.0
.debug_aranges 111184 111184 0 0.0
.debug_frame 375980 375980 0 0.0
.debug_info 26448146 26448146 0 0.0
.debug_line 3677363 3677363 0 0.0
.debug_loc 3559352 3559352 0 0.0
.debug_ranges 336744 336744 0 0.0
.debug_str 3415925 3415925 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535050 535050 0 0.0
.symtab 408080 408080 0 0.0
.text 1486864 1486864 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603148 1603148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048108 1048108 0 0.0
.debug_aranges 103360 103360 0 0.0
.debug_frame 346248 346248 0 0.0
.debug_info 21910427 21910427 0 0.0
.debug_line 3247828 3247828 0 0.0
.debug_loc 3257695 3257695 0 0.0
.debug_ranges 302216 302216 0 0.0
.debug_str 3221145 3221145 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468349 468349 0 0.0
.symtab 375168 375168 0 0.0
.text 1412344 1412344 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640844 1640844 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055543 1055543 0 0.0
.debug_aranges 104032 104032 0 0.0
.debug_frame 349076 349076 0 0.0
.debug_info 22290176 22290175 -1 -0.0
.debug_line 3256649 3256649 0 0.0
.debug_loc 3297548 3297548 0 0.0
.debug_ranges 305560 305560 0 0.0
.debug_str 3248566 3248566 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474564 0 0.0
.symtab 378352 378352 0 0.0
.text 1445008 1445008 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129156 1129164 8 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576252 576260 8 0.0
lock-app qpg6105+debug (read/write) 1100176 1100176 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547276 547276 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808996 808996 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571474 571474 0 0.0
lighting-app tlsr9518adk80d (read/write) 830912 830904 -8 -0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589598 589594 -4 -0.0

@andy31415 andy31415 merged commit 0f0e1e9 into project-chip:master Sep 1, 2022
@mkardous-silabs mkardous-silabs deleted the fix/thermostat_app branch September 1, 2022 23:37
jmartinez-silabs added a commit to SiliconLabs/matter that referenced this pull request Sep 8, 2022
@jmartinez-silabs
Pull request #65: RC3 cherrypicks + point to matter_support/workswith
2d55b46 
Merge in WMN_TOOLS/matter from rc3_cherrypicks to RC_0.3.0

Squashed commit of the following:

commit bbfbb9c82faae045a2f47453f9e589065ea50edd
Author: Junior Martinez <[email protected]>
Date:   Fri Sep 2 13:24:15 2022 -0400

    re-enable BRD4162A for wifi builds as it is support with the workswith branch of matter_support

commit 1509b4aa5f9ebaf6c6f727a893160dd086893912
Author: Junior Martinez <[email protected]>
Date:   Fri Sep 2 13:22:21 2022 -0400

    Change matter_support submodule to point to the workswith branch

commit 46c630d083cf305e1f33351180449ea500ac8690
Author: jmartinez-silabs <[email protected]>
Date:   Wed Aug 31 00:24:32 2022 -0400

    Add openthread lib with coap api enabled (project-chip#22276)

commit 0e3839fdc48e7373000705f8bea1a993dd27b5a4
Author: Jean-Francois Penven <[email protected]>
Date:   Thu Sep 1 17:42:34 2022 -0400

    Fix wf200 openthread include (project-chip#22347)

commit 439b376dba33d43ca213434f5d0473ebe2c1d3bb
Author: mkardous-silabs <[email protected]>
Date:   Thu Sep 1 16:26:49 2022 -0400

    Fix thermostat build (project-chip#22346)
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@mkardous-silabs @isiu-apple
Fix thermostat build (project-chip#22346)
44ce4e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcasallas-silabs rcasallas-silabs rcasallas-silabs approved these changes

@jepenven-silabs jepenven-silabs jepenven-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkardous-silabs @bzbarsky-apple @jepenven-silabs @rcasallas-silabs @andy31415