-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove upload of entire out dir for linux - it is too large #22343
Merged
andy31415
merged 1 commit into
project-chip:master
from
andy31415:disable_upload_on_linux_build
Sep 1, 2022
Merged
Remove upload of entire out dir for linux - it is too large #22343
andy31415
merged 1 commit into
project-chip:master
from
andy31415:disable_upload_on_linux_build
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang and
rgoliver
September 1, 2022 16:35
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
September 1, 2022 16:35
andy31415
added
hotfix
urgent fix needed, can bypass review
ACCEPTED for 1.0 master
labels
Sep 1, 2022
v1 reason: fixing CI infra (invalid failure mode of timeout when in fact it should be test run failure) |
PR #22343: Size comparison from 686547c to 93223ce Increases (4 builds for cc13x2_26x2, esp32, psoc6)
Decreases (6 builds for cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 1, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Timing out on builds, like https://github.com/project-chip/connectedhomeip/runs/8137393997?check_suite_focus=true
Uploading the entire out directory (expecting 100s of MB) including a python venv is not practical. If we enable this, we need some curated subset (like elf files in test and maybe map files).
Change overview
Disable upload on failure for linux
Testing
N/A - CI will run and this is a comment-out only. if CI runs we are fine.