-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DarwinFrameworkTool] Add autoResubscribe optional parameters to comm… #22339
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_Add_autoResubscribe
Sep 2, 2022
Merged
[DarwinFrameworkTool] Add autoResubscribe optional parameters to comm… #22339
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_Add_autoResubscribe
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22339: Size comparison from 26bfa09 to 248dceb Increases (6 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (2 builds for bl602, cc13x2_26x2)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
1.0 accepted: changes /examples only |
andy31415
approved these changes
Sep 1, 2022
bzbarsky-apple
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/rebase |
…ands making subscriptions
248dceb
to
8688a6a
Compare
PR #22339: Size comparison from e56afce to 8688a6a Increases (5 builds for bl602, psoc6, telink)
Decreases (3 builds for efr32, esp32, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ands making subscriptions (project-chip#22339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ands making subscriptions
Problem
In #22320 one of the step to reproduce the crash is to manually disable auto-resubscription.
This PR add an option to do that as an optional parameter instead of manually editing the code.
Change overview
autoResubscribe
optional parameter to commands making subscriptionsV1.0 justification is that it may help to find crashes related to the subscriptions ending up and only affect a tool that is not altering the behaviour of the SDK at all.