-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more debug log to track CASE failure during commission #22335
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/pairing/debug
Sep 1, 2022
Merged
Add more debug log to track CASE failure during commission #22335
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/pairing/debug
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
September 1, 2022 06:51
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
September 1, 2022 06:51
PR #22335: Size comparison from 26bfa09 to 967dc4f Increases (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, cc13x2_26x2, k32w, qpg)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Sep 1, 2022
bzbarsky-apple
approved these changes
Sep 1, 2022
andy31415
approved these changes
Sep 1, 2022
Approving for 1.0 as high value change in debugging connection issues, low risk since it only changes logging. |
Co-authored-by: Boris Zbarsky <[email protected]>
PR #22335: Size comparison from 26bfa09 to 6562074 Increases (26 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, cc13x2_26x2, k32w, qpg)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…hip#22335) * Add more debug log to track CASE failure during commision * Update src/app/OperationalSessionSetup.cpp Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Found random commission failure during automation test against esp32 target. It looks the reason of this failure if the esp32 was not able to send Sigma2 msg to the controller. We just know where it failed but don't know why.
We need to instrument more debug log to help us understand the failure reason.
Change overview
Add more debug log to track CASE failure during commission
Testing
How was this tested? (at least one bullet point required)