-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA: Fix linux BlockEOF with data length zero #22309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec indicates BlockEOF May have data length zero.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi and
electrocucaracha
August 31, 2022 15:28
pullapprove
bot
requested review from
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov and
LuDuda
August 31, 2022 15:28
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
August 31, 2022 15:28
pullapprove
bot
added
review - pending
linux
platform
and removed
platform
linux
labels
Aug 31, 2022
Accepted for 1.0 master: platform specific fix |
andy31415
approved these changes
Aug 31, 2022
PR #22309: Size comparison from dcd8931 to 2825e62 Increases (2 builds for cc13x2_26x2, telink)
Decreases (8 builds for bl602, cc13x2_26x2, esp32, linux, psoc6, telink)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Aug 31, 2022
selissia
approved these changes
Aug 31, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
Spec indicates BlockEOF May have data length zero.
andy31415
pushed a commit
that referenced
this pull request
Aug 31, 2022
Spec indicates BlockEOF May have data length zero. Co-authored-by: rgoliver <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Spec indicates BlockEOF May have data length zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes issue #22308 where linux currently doesn't support BlockEOF of data length zero.
Change overview
Remove this check, it is checked immediately after in SetBlock: https://github.com/project-chip/connectedhomeip/blob/master/src/platform/Linux/OTAImageProcessorImpl.cpp#L244
But at this point the block is released correctly and it does not return an error.
Testing
Did an ota which finished with a BlockEOF with data length zero and confirmed it finished.