Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to separate app platform code. support dynamic discovery. #22298

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Refactor to separate app platform code. support dynamic discovery. #22298

merged 1 commit into from
Sep 1, 2022

Conversation

amitnj
Copy link
Contributor

@amitnj amitnj commented Aug 31, 2022

Problem

Content apps were not being updated after first startup of the platform-app.

Change overview

Started supporting dynamic update of content apps on uninstall/install when the platform-app is already running.
Also refactored the code to separate out chip server startup code from contentappplatform initialization.

Testing

Testing was done manually using the chip tool.

@github-actions
Copy link

github-actions bot commented Aug 31, 2022 •
edited
Loading

PR #22298: Size comparison from 0a36d9f to 8ef0028

Increases (3 builds for cc13x2_26x2, esp32)
platform target config section 0a36d9f 8ef0028 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 676131 676139 8 0.0
.text 598576 598584 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 173076 173084 8 0.0
esp32 all-clusters-app m5stack (read/write) 490804 490812 8 0.0
.flash.rodata 247344 247352 8 0.0
Decreases (6 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, qpg)
platform target config section 0a36d9f 8ef0028 change % change
bl602 lighting-app bl602 .text 1052324 1052320 -4 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 165588 165580 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 669459 669451 -8 -0.0
.text 583472 583464 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814840 814836 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26445255 26445254 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1129060 1129052 -8 -0.0
.text 576156 576148 -8 -0.0
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0a36d9f 8ef0028 change % change
bl602 lighting-app bl602 (read/write) 1385942 1385942 0 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052324 1052320 -4 -0.0
bl602+rpc (read/write) 1431590 1431590 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084080 1084080 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675087 675087 0 0.0
(read/write) 176320 176320 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89231 89231 0 0.0
.text 585544 585544 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 639791 639791 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78375 78375 0 0.0
.text 561096 561096 0 0.0
lock-ftd LP_CC2652R7 (read only) 676131 676139 8 0.0
(read/write) 165588 165580 -8 -0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77075 77075 0 0.0
.text 598576 598584 8 0.0
lock-mtd LP_CC2652R7 (read only) 659123 659123 0 0.0
(read/write) 178284 178284 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102339 102339 0 0.0
.text 556304 556304 0 0.0
pump-app LP_CC2652R7 (read only) 684959 684959 0 0.0
(read/write) 157464 157464 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 89951 89951 0 0.0
.text 594524 594524 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669459 669451 -8 -0.0
(read/write) 173076 173084 8 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85507 85507 0 0.0
.text 583472 583464 -8 -0.0
shell LP_CC2652R7 (read only) 665898 665898 0 0.0
(read/write) 181028 181028 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85786 85786 0 0.0
.text 579796 579796 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586770 586770 0 0.0
.app_xip_area 463428 463428 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592522 592522 0 0.0
.app_xip_area 464396 464396 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599554 599554 0 0.0
.app_xip_area 476932 476932 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107840 1107840 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 969416 969416 0 0.0
BRD4161A+rpc (read/write) 971828 971828 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818712 818712 0 0.0
BRD4161A+rs911x (read/write) 1001596 1001596 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830344 830344 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150008 1150008 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995668 995668 0 0.0
window-app BRD4161A (read/write) 1099096 1099096 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959208 959208 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033722 1033722 0 0.0
(read/write) 1493526 1493526 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218040 218040 0 0.0
.flash.text 1033722 1033722 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086075 1086075 0 0.0
(read/write) 490804 490812 8 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247344 247352 8 0.0
.flash.text 1080691 1080691 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648092 648092 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572584 572584 0 0.0
lock k32w0+release (read/write) 705096 705096 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629132 629132 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10291284 10291284 0 0.0
(read/write) 705233 705233 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649832 649832 0 0.0
.dynamic 560 560 0 0.0
.got 13848 13848 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 494724 494724 0 0.0
.text 8144100 8144100 0 0.0
thermostat-no-ble arm64 (read only) 2361988 2361988 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141276 141276 0 0.0
.text 1982672 1982672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454936 2454936 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417580 1417580 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180803 1180803 0 0.0
bss 143641 143641 0 0.0
rodata 143380 143380 0 0.0
text 814840 814836 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159983 1159983 0 0.0
bss 142868 142868 0 0.0
rodata 134968 134968 0 0.0
text 803232 803232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742252 1742252 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221468 1221468 0 0.0
.debug_aranges 111712 111712 0 0.0
.debug_frame 372900 372900 0 0.0
.debug_info 26708632 26708632 0 0.0
.debug_line 3655731 3655731 0 0.0
.debug_loc 3569692 3569692 0 0.0
.debug_ranges 337616 337616 0 0.0
.debug_str 3426920 3426920 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570576 570576 0 0.0
.symtab 421488 421488 0 0.0
.text 0 0 0 0.0
1542480 1542480 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685420 1685420 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213307 1213307 0 0.0
.debug_aranges 111184 111184 0 0.0
.debug_frame 375980 375980 0 0.0
.debug_info 26445255 26445254 -1 -0.0
.debug_line 3676247 3676247 0 0.0
.debug_loc 3557329 3557329 0 0.0
.debug_ranges 336232 336232 0 0.0
.debug_str 3415925 3415925 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535050 535050 0 0.0
.symtab 408080 408080 0 0.0
.text 1486384 1486384 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1602700 1602700 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048126 1048126 0 0.0
.debug_aranges 103360 103360 0 0.0
.debug_frame 346248 346248 0 0.0
.debug_info 21907537 21907537 0 0.0
.debug_line 3246712 3246712 0 0.0
.debug_loc 3255672 3255672 0 0.0
.debug_ranges 301704 301704 0 0.0
.debug_str 3221145 3221145 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468349 468349 0 0.0
.symtab 375168 375168 0 0.0
.text 1411896 1411896 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640396 1640396 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055561 1055561 0 0.0
.debug_aranges 104032 104032 0 0.0
.debug_frame 349076 349076 0 0.0
.debug_info 22287285 22287285 0 0.0
.debug_line 3255533 3255533 0 0.0
.debug_loc 3295525 3295525 0 0.0
.debug_ranges 305048 305048 0 0.0
.debug_str 3248566 3248566 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474564 0 0.0
.symtab 378352 378352 0 0.0
.text 1444560 1444560 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129060 1129052 -8 -0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576156 576148 -8 -0.0
lock-app qpg6105+debug (read/write) 1100064 1100064 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547164 547164 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808728 808728 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571326 571326 0 0.0
lighting-app tlsr9518adk80d (read/write) 830628 830628 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589438 589438 0 0.0

@andy31415
Copy link
Contributor

Accepted into 1.0: /examples code change only

@chrisdecenzo chrisdecenzo merged commit b6aac34 into project-chip:master Sep 1, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@amitnj @isiu-apple
Refactor to separate app platform code. support dynamic discovery. (p…
d056b82 
…roject-chip#22298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

@lazarkov lazarkov lazarkov approved these changes

@hawk248 hawk248 hawk248 approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amitnj @andy31415 @lazarkov @hawk248 @chrisdecenzo