-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable TC-RR-1.1 in CI #22292
Merged
tcarmelveilleux
merged 6 commits into
project-chip:master
from
tcarmelveilleux:fix-python-tests
Sep 1, 2022
Merged
Re-enable TC-RR-1.1 in CI #22292
tcarmelveilleux
merged 6 commits into
project-chip:master
from
tcarmelveilleux:fix-python-tests
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A regression had occured on RR-1.1 in master before CI was attempted in project-chip#22143 which prevented the CI test to be enabled This PR: - Fixes TC-RR-1.1 - Enables TC-RR-1.1, TC-SC-3.6 and TC-DA-1.7 to keep them fresh and improve integration test coverage (TC-RR-1.1 tests a lot) - Improve run_python_test.py to do better factory reset Fixes project-chip#21736 Testing done: - Manually tested the fix of TC-RR-1.1 on ESP32 and Linux - CI tests of the above is automated
yunhanw-google
approved these changes
Aug 31, 2022
PR #22292: Size comparison from 08830a5 to 3929384 Increases (2 builds for bl602, psoc6)
Decreases (2 builds for esp32, telink)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Accepted for 1.0: only adding tests (no functional changes) |
vivien-apple
approved these changes
Aug 31, 2022
PR #22292: Size comparison from 08830a5 to cc8d580 Increases (25 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for cc13x2_26x2, cyw30739, esp32, linux, qpg)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Re-enable TC-RR-1.1 in CI - A regression had occured on RR-1.1 in master before CI was attempted in project-chip#22143 which prevented the CI test to be enabled This PR: - Fixes TC-RR-1.1 - Enables TC-RR-1.1, TC-SC-3.6 and TC-DA-1.7 to keep them fresh and improve integration test coverage (TC-RR-1.1 tests a lot) - Improve run_python_test.py to do better factory reset Fixes project-chip#21736 Testing done: - Manually tested the fix of TC-RR-1.1 on ESP32 and Linux - CI tests of the above is automated * Attempt to pass CI * Debug CI * More debug of CI * More CI fixes * Fix more CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
in enable TC_RR_1_1 python test #22143 which prevented the CI test to be enabled
Fixes #21736
Change overview
This PR:
improve integration test coverage (TC-RR-1.1 tests a lot)
Testing