Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable faultinjection cluster in Darwin and Android API surface #22289

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Disable faultinjection cluster in Darwin and Android API surface #22289

merged 2 commits into from
Aug 31, 2022

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Allow configure nlfaultinjection via fault-cluster in yaml #21951 added the FaultInjection cluster to the API surface for Darwin and Android. faultinjection is mainly used to exercises various negative path to improve current test coverage, and gcoverage is only run against linux platform now, so we should disable it on Darwin and Android.

Change overview

Disable faultinjection cluster in Darwin and Android API surface

Testing

How was this tested? (at least one bullet point required)

  • Build all-clusters-app with nlfaultinjection enabled
    scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false chip_with_nlfaultinjection=true

  • Configure a system fault from chip_tool
    ./chip-tool faultinjection fail-at-fault 1 1 0 1 true 12344321 0

  • Confirm the fault is activated from all-clusters-app log

[1661909717.710111][338693:338693] CHIP:EM: Received message of type 0x8 with protocolId (0, 1) and MessageCounter:33050415 on exchange 15984r
[1661909717.710191][338693:338693] CHIP:EM: Handling via exchange: 15984r, Delegate: 0x556a3a6c4b48
[1661909717.710310][338693:338693] CHIP:DMG: InvokeRequestMessage =
[1661909717.710343][338693:338693] CHIP:DMG: {
[1661909717.710367][338693:338693] CHIP:DMG:    suppressResponse = false, 
[1661909717.710393][338693:338693] CHIP:DMG:    timedRequest = false, 
[1661909717.710422][338693:338693] CHIP:DMG:    InvokeRequests =
[1661909717.710466][338693:338693] CHIP:DMG:    [
[1661909717.710492][338693:338693] CHIP:DMG:        CommandDataIB =
[1661909717.710519][338693:338693] CHIP:DMG:        {
[1661909717.710543][338693:338693] CHIP:DMG:            CommandPathIB =
[1661909717.710579][338693:338693] CHIP:DMG:            {
[1661909717.710612][338693:338693] CHIP:DMG:                EndpointId = 0x0,
[1661909717.710646][338693:338693] CHIP:DMG:                ClusterId = 0xfff1fc06,
[1661909717.710678][338693:338693] CHIP:DMG:                CommandId = 0x0,
[1661909717.710709][338693:338693] CHIP:DMG:            },
[1661909717.710744][338693:338693] CHIP:DMG:            
[1661909717.710774][338693:338693] CHIP:DMG:            CommandFields = 
[1661909717.710806][338693:338693] CHIP:DMG:            {
[1661909717.710840][338693:338693] CHIP:DMG:                0x0 = 1, 
[1661909717.710873][338693:338693] CHIP:DMG:                0x1 = 1, 
[1661909717.710906][338693:338693] CHIP:DMG:                0x2 = 0, 
[1661909717.710939][338693:338693] CHIP:DMG:                0x3 = 1, 
[1661909717.710972][338693:338693] CHIP:DMG:                0x4 = true, 
[1661909717.711004][338693:338693] CHIP:DMG:            },
[1661909717.711033][338693:338693] CHIP:DMG:        },
[1661909717.711075][338693:338693] CHIP:DMG:        
[1661909717.711102][338693:338693] CHIP:DMG:    ],
[1661909717.711145][338693:338693] CHIP:DMG:    
[1661909717.711173][338693:338693] CHIP:DMG:    InteractionModelRevision = 1
[1661909717.711199][338693:338693] CHIP:DMG: },
[1661909717.711352][338693:338693] CHIP:DMG: AccessControl: checking f=1 a=c s=0x000000000001B669 t= c=0xFFF1_FC06 e=0 p=m
[1661909717.711412][338693:338693] CHIP:DMG: AccessControl: allowed
[1661909717.711449][338693:338693] CHIP:DMG: Received command for Endpoint=0 Cluster=0xFFF1_FC06 Command=0x0000_0000
[1661909717.711540][338693:338693] CHIP:ZCL: FaultInjection: Configure a fault of type: 1 and Id: 1 to be triggered deterministically

@github-actions
Copy link

github-actions bot commented Aug 31, 2022 •
edited
Loading

PR #22289: Size comparison from 716b957 to 95de63c

Increases (5 builds for bl602, k32w, nrfconnect, psoc6, telink)
platform target config section 716b957 95de63c change % change
bl602 lighting-app bl602 (read/write) 1385478 1385486 8 0.0
.text 1051860 1051864 4 0.0
k32w light k32w0+release (read/write) 648044 648060 16 0.0
.text 572536 572552 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814804 814808 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26708240 26708241 1 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808680 808688 8 0.0
text 571284 571286 2 0.0
Decreases (5 builds for esp32, linux, psoc6)
platform target config section 716b957 95de63c change % change
esp32 all-clusters-app c3devkit (read only) 1033704 1033702 -2 -0.0
.flash.text 1033704 1033702 -2 -0.0
linux chip-tool debug (read only) 10910289 10909369 -920 -0.0
(read/write) 657384 657320 -64 -0.0
.data.rel.ro 622352 622288 -64 -0.0
.rodata 564277 564245 -32 -0.0
.text 8825172 8824308 -864 -0.0
chip-tool-ipv6only arm64 (read only) 10291012 10290052 -960 -0.0
(read/write) 705233 705185 -48 -0.0
.data.rel.ro 649832 649784 -48 -0.0
.rodata 494724 494708 -16 -0.0
.text 8143828 8142900 -928 -0.0
tv-casting-app debug (read only) 5509441 5508609 -832 -0.0
.rodata 344945 344913 -32 -0.0
.text 4892594 4891794 -800 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 21907146 21907145 -1 -0.0
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 716b957 95de63c change % change
bl602 lighting-app bl602 (read/write) 1385478 1385486 8 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1051860 1051864 4 0.0
bl602+rpc (read/write) 1431126 1431126 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1083620 1083620 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675055 675055 0 0.0
(read/write) 176352 176352 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89231 89231 0 0.0
.text 585512 585512 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 639759 639759 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78375 78375 0 0.0
.text 561064 561064 0 0.0
lock-ftd LP_CC2652R7 (read only) 676107 676107 0 0.0
(read/write) 165612 165612 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77075 77075 0 0.0
.text 598552 598552 0 0.0
lock-mtd LP_CC2652R7 (read only) 659091 659091 0 0.0
(read/write) 178316 178316 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102339 102339 0 0.0
.text 556272 556272 0 0.0
pump-app LP_CC2652R7 (read only) 684927 684927 0 0.0
(read/write) 157496 157496 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 89951 89951 0 0.0
.text 594492 594492 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669427 669427 0 0.0
(read/write) 173108 173108 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85507 85507 0 0.0
.text 583440 583440 0 0.0
shell LP_CC2652R7 (read only) 665866 665866 0 0.0
(read/write) 181060 181060 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85786 85786 0 0.0
.text 579764 579764 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586770 586770 0 0.0
.app_xip_area 463428 463428 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592522 592522 0 0.0
.app_xip_area 464396 464396 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599522 599522 0 0.0
.app_xip_area 476900 476900 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107648 1107648 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 969224 969224 0 0.0
BRD4161A+rpc (read/write) 971652 971652 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818536 818536 0 0.0
BRD4161A+rs911x (read/write) 1001548 1001548 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830296 830296 0 0.0
lock-app BRD4161A+wf200 (read/write) 1149976 1149976 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995636 995636 0 0.0
window-app BRD4161A (read/write) 1098904 1098904 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959016 959016 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033704 1033702 -2 -0.0
(read/write) 1493526 1493526 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218040 218040 0 0.0
.flash.text 1033704 1033702 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086059 1086059 0 0.0
(read/write) 490804 490804 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247344 247344 0 0.0
.flash.text 1080675 1080675 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648044 648060 16 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572536 572552 16 0.0
lock k32w0+release (read/write) 705064 705064 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629100 629100 0 0.0
linux all-clusters-app debug (read only) 3043881 3043881 0 0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275307 275307 0 0.0
.text 2589138 2589138 0 0.0
all-clusters-minimal-app debug (read only) 2879681 2879681 0 0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275467 275467 0 0.0
.text 2427554 2427554 0 0.0
bridge-app debug+rpc (read only) 2377945 2377945 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204168 204168 0 0.0
.text 2010866 2010866 0 0.0
chip-tool debug (read only) 10910289 10909369 -920 -0.0
(read/write) 657384 657320 -64 -0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622352 622288 -64 -0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 564277 564245 -32 -0.0
.text 8825172 8824308 -864 -0.0
chip-tool-ipv6only arm64 (read only) 10291012 10290052 -960 -0.0
(read/write) 705233 705185 -48 -0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649832 649784 -48 -0.0
.dynamic 560 560 0 0.0
.got 13848 13848 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 494724 494708 -16 -0.0
.text 8143828 8142900 -928 -0.0
lighting-app debug+rpc (read only) 2602873 2602873 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221008 221008 0 0.0
.text 2210674 2210674 0 0.0
lock-app debug (read only) 2585841 2585841 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238000 238000 0 0.0
.text 2180898 2180898 0 0.0
ota-provider-app debug (read only) 2363097 2363097 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 209976 209976 0 0.0
.text 1989362 1989362 0 0.0
ota-requestor-app debug (read only) 2528425 2528425 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216704 216704 0 0.0
.text 2138818 2138818 0 0.0
shell debug (read only) 2612185 2612185 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235410 235410 0 0.0
.text 2218066 2218066 0 0.0
thermostat-no-ble arm64 (read only) 2361924 2361924 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141276 141276 0 0.0
.text 1982608 1982608 0 0.0
tv-app debug (read only) 3189929 3189929 0 0.0
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 259976 259976 0 0.0
.text 2739922 2739922 0 0.0
tv-casting-app debug (read only) 5509441 5508609 -832 -0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 344945 344913 -32 -0.0
.text 4892594 4891794 -800 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454936 2454936 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417580 1417580 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180771 1180771 0 0.0
bss 143641 143641 0 0.0
rodata 143380 143380 0 0.0
text 814804 814808 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159951 1159951 0 0.0
bss 142868 142868 0 0.0
rodata 134968 134968 0 0.0
text 803200 803200 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742204 1742204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221468 1221468 0 0.0
.debug_aranges 111712 111712 0 0.0
.debug_frame 372900 372900 0 0.0
.debug_info 26708240 26708241 1 0.0
.debug_line 3655437 3655437 0 0.0
.debug_loc 3569448 3569448 0 0.0
.debug_ranges 337616 337616 0 0.0
.debug_str 3426920 3426920 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570576 570576 0 0.0
.symtab 421488 421488 0 0.0
.text 1542432 1542432 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685372 1685372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213307 1213307 0 0.0
.debug_aranges 111184 111184 0 0.0
.debug_frame 375980 375980 0 0.0
.debug_info 26444864 26444864 0 0.0
.debug_line 3675953 3675953 0 0.0
.debug_loc 3557085 3557085 0 0.0
.debug_ranges 336232 336232 0 0.0
.debug_str 3415925 3415925 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535050 535050 0 0.0
.symtab 408080 408080 0 0.0
.text 1486336 1486336 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1602652 1602652 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048126 1048126 0 0.0
.debug_aranges 103360 103360 0 0.0
.debug_frame 346248 346248 0 0.0
.debug_info 21907146 21907145 -1 -0.0
.debug_line 3246418 3246418 0 0.0
.debug_loc 3255412 3255412 0 0.0
.debug_ranges 301704 301704 0 0.0
.debug_str 3221145 3221145 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468349 468349 0 0.0
.symtab 375168 375168 0 0.0
.text 1411848 1411848 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640348 1640348 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055561 1055561 0 0.0
.debug_aranges 104032 104032 0 0.0
.debug_frame 349076 349076 0 0.0
.debug_info 22286893 22286893 0 0.0
.debug_line 3255239 3255239 0 0.0
.debug_loc 3295280 3295280 0 0.0
.debug_ranges 305048 305048 0 0.0
.debug_str 3248566 3248566 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474564 0 0.0
.symtab 378352 378352 0 0.0
.text 1444512 1444512 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129028 1129028 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576124 576124 0 0.0
lock-app qpg6105+debug (read/write) 1100032 1100032 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547132 547132 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808680 808688 8 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571284 571286 2 0.0
lighting-app tlsr9518adk80d (read/write) 830588 830588 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589398 589398 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andy31415
Copy link
Contributor

Accepted for 1.0 as a compatibility/spec compilance. Actual delta seems to be one line (enable from 1 to 0) the rest is auto-generated.

@andy31415 andy31415 merged commit 46443b0 into project-chip:master Aug 31, 2022
@yufengwangca yufengwangca deleted the pr/faultinjection/controller branch August 31, 2022 21:05
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yufengwangca @isiu-apple
Disable faultinjection cluster in Darwin and Android API surface (pro…
6e3b057 
…ject-chip#22289)

* Disable faultinjection cluster in Darwin and Android API surface.

* Run codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
controller darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @andy31415 @bzbarsky-apple