Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "TV Linux App" from shared linux main logs - it is confusiong … #22231

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Remove "TV Linux App" from shared linux main logs - it is confusiong … #22231

merged 1 commit into from
Sep 19, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Aug 29, 2022 •
edited
Loading

…when the app is not TV

Reason for 1.0 inclusion:

I was confused during testing of non-tv app by the log saying "TV app".
This is only affecting example apps not core SDK.

Problem

Log says "TV app" for any common linux app.

Change overview

Change the text.

Testing

N/A - it is just a text change.

@github-actions
Copy link

github-actions bot commented Aug 29, 2022 •
edited
Loading

PR #22231: Size comparison from 0bc1578 to ad25378

Increases (5 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
platform target config section 0bc1578 ad25378 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 665638 665646 8 0.0
.text 579540 579548 8 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 592410 592418 8 0.0
.app_xip_area 464284 464292 8 0.0
esp32 all-clusters-app c3devkit (read only) 1031714 1031716 2 0.0
.flash.text 1031714 1031716 2 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803060 803064 4 0.0
telink lighting-app tlsr9518adk80d text 589262 589264 2 0.0
Decreases (5 builds for bl602, cc13x2_26x2, cyw30739, psoc6, telink)
platform target config section 0bc1578 ad25378 change % change
bl602 lighting-app bl602+rpc (read/write) 1430662 1430654 -8 -0.0
.text 1083344 1083340 -4 -0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 181272 181264 -8 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599546 599538 -8 -0.0
.app_xip_area 476924 476916 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26695728 26695727 -1 -0.0
telink light-switch-app tlsr9518adk80d text 571170 571168 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 0bc1578 ad25378 change % change
bl602 lighting-app bl602 (read/write) 1384766 1384766 0 0.0
.bss 120274 120274 0 0.0
.data 4488 4488 0 0.0
.text 1051332 1051332 0 0.0
bl602+rpc (read/write) 1430662 1430654 -8 -0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1083344 1083340 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672939 672939 0 0.0
(read/write) 178452 178452 0 0.0
.bss 74284 74284 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583788 583788 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637659 637659 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559356 559356 0 0.0
lock-ftd LP_CC2652R7 (read only) 673991 673991 0 0.0
(read/write) 167712 167712 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596840 596840 0 0.0
lock-mtd LP_CC2652R7 (read only) 656759 656759 0 0.0
(read/write) 180632 180632 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554512 554512 0 0.0
pump-app LP_CC2652R7 (read only) 684671 684671 0 0.0
(read/write) 157736 157736 0 0.0
.bss 71420 71420 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594260 594260 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669163 669163 0 0.0
(read/write) 173356 173356 0 0.0
.bss 71532 71532 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583200 583200 0 0.0
shell LP_CC2652R7 (read only) 665638 665646 8 0.0
(read/write) 181272 181264 -8 -0.0
.bss 76604 76604 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579540 579548 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586650 586650 0 0.0
.app_xip_area 463308 463308 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592410 592418 8 0.0
.app_xip_area 464284 464292 8 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599546 599538 -8 -0.0
.app_xip_area 476924 476916 -8 -0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107372 1107372 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968948 968948 0 0.0
BRD4161A+rpc (read/write) 971492 971492 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818372 818372 0 0.0
BRD4161A+rs911x (read/write) 1001052 1001052 0 0.0
.bss 169088 169088 0 0.0
.data 2064 2064 0 0.0
.text 829880 829880 0 0.0
lock-app BRD4161A+wf200 (read/write) 1149628 1149628 0 0.0
.bss 152168 152168 0 0.0
.data 2072 2072 0 0.0
.text 995368 995368 0 0.0
window-app BRD4161A (read/write) 1098628 1098628 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958740 958740 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031714 1031716 2 0.0
(read/write) 1490106 1490106 0 0.0
.dram0.bss 71056 71056 0 0.0
.dram0.data 14608 14608 0 0.0
.flash.rodata 219016 219016 0 0.0
.flash.text 1031714 1031716 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084675 1084675 0 0.0
(read/write) 492028 492028 0 0.0
.dram0.bss 76560 76560 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 249320 249320 0 0.0
.flash.text 1079291 1079291 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 647180 647180 0 0.0
.bss 70424 70424 0 0.0
.data 2068 2068 0 0.0
.text 571960 571960 0 0.0
lock k32w0+release (read/write) 704076 704076 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628408 628408 0 0.0
linux all-clusters-app debug (read only) 3043145 3043145 0 0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275243 275243 0 0.0
.text 2588466 2588466 0 0.0
all-clusters-minimal-app debug (read only) 2878961 2878961 0 0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275403 275403 0 0.0
.text 2426898 2426898 0 0.0
bridge-app debug+rpc (read only) 2377225 2377225 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204104 204104 0 0.0
.text 2010210 2010210 0 0.0
chip-tool debug (read only) 10902609 10902609 0 0.0
(read/write) 657384 657384 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622352 622352 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 563445 563445 0 0.0
.text 8818324 8818324 0 0.0
chip-tool-ipv6only arm64 (read only) 10284180 10284180 0 0.0
(read/write) 705233 705233 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649832 649832 0 0.0
.dynamic 560 560 0 0.0
.got 13848 13848 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 493956 493956 0 0.0
.text 8137764 8137764 0 0.0
lighting-app debug+rpc (read only) 2602121 2602121 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 220944 220944 0 0.0
.text 2209986 2209986 0 0.0
lock-app debug (read only) 2585121 2585121 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 237936 237936 0 0.0
.text 2180242 2180242 0 0.0
ota-provider-app debug (read only) 2362377 2362377 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 209912 209912 0 0.0
.text 1988706 1988706 0 0.0
ota-requestor-app debug (read only) 2527705 2527705 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216640 216640 0 0.0
.text 2138162 2138162 0 0.0
shell debug (read only) 2611433 2611433 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235346 235346 0 0.0
.text 2217378 2217378 0 0.0
thermostat-no-ble arm64 (read only) 2361396 2361396 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141228 141228 0 0.0
.text 1982128 1982128 0 0.0
tv-app debug (read only) 3188041 3188041 0 0.0
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 259720 259720 0 0.0
.text 2738290 2738290 0 0.0
tv-casting-app debug (read only) 5508689 5508689 0 0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 344849 344849 0 0.0
.text 4891938 4891938 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454744 2454744 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417388 1417388 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180591 0 0.0
bss 143641 143641 0 0.0
rodata 143360 143360 0 0.0
text 814656 814656 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159803 1159803 0 0.0
bss 142868 142868 0 0.0
rodata 134948 134948 0 0.0
text 803060 803064 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842216 842216 0 0.0
(read/write) 1741532 1741532 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188464 188464 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221325 1221325 0 0.0
.debug_aranges 111696 111696 0 0.0
.debug_frame 372796 372796 0 0.0
.debug_info 26695728 26695727 -1 -0.0
.debug_line 3654925 3654925 0 0.0
.debug_loc 3568025 3568025 0 0.0
.debug_ranges 337512 337512 0 0.0
.debug_str 3426578 3426578 0 0.0
.heap 842216 842216 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570457 570457 0 0.0
.symtab 421408 421408 0 0.0
.text 1542016 1542016 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842952 842952 0 0.0
(read/write) 1684732 1684732 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187728 187728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213164 1213164 0 0.0
.debug_aranges 111168 111168 0 0.0
.debug_frame 375876 375876 0 0.0
.debug_info 26432422 26432422 0 0.0
.debug_line 3675441 3675441 0 0.0
.debug_loc 3555662 3555662 0 0.0
.debug_ranges 336128 336128 0 0.0
.debug_str 3415583 3415583 0 0.0
.heap 842952 842952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534931 534931 0 0.0
.symtab 408000 408000 0 0.0
.text 1485952 1485952 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851184 851184 0 0.0
(read/write) 1601996 1601996 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179704 179704 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1047983 1047983 0 0.0
.debug_aranges 103344 103344 0 0.0
.debug_frame 346144 346144 0 0.0
.debug_info 2189593 2189593 0 0.0
.debug_line 3245906 3245906 0 0.0
.debug_loc 3253968 3253968 0 0.0
.debug_ranges 301600 301600 0 0.0
.debug_str 3220803 3220803 0 0.0
.heap 851184 851184 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468230 468230 0 0.0
.symtab 375088 375088 0 0.0
.text 1411448 1411448 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846152 846152 0 0.0
(read/write) 1639692 1639692 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184720 184720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055418 1055418 0 0.0
.debug_aranges 104016 104016 0 0.0
.debug_frame 348972 348972 0 0.0
.debug_info 22275664 22275664 0 0.0
.debug_line 3254744 3254744 0 0.0
.debug_loc 3293806 3293806 0 0.0
.debug_ranges 304944 304944 0 0.0
.debug_str 3248278 3248278 0 0.0
.heap 846152 846152 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474445 474445 0 0.0
.symtab 378272 378272 0 0.0
.text 1444112 1444112 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808548 808548 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571170 571168 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830432 830432 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589262 589264 2 0.0

@andy31415 andy31415 merged commit 635b943 into project-chip:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @bzbarsky-apple @Damian-Nordic