Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential IPPacketInfo leak in LwIP code. #22198

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Fix potential IPPacketInfo leak in LwIP code. #22198

merged 1 commit into from
Aug 29, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

We allocate an IPPacketInfo, but then can take early returns without deleting it.

Change overview

Use a UniquePtr, to make it impossible to mess this up.

Testing

Just code inspection.

@github-actions github-actions bot added the inet label Aug 26, 2022
@github-actions
Copy link

github-actions bot commented Aug 26, 2022 •
edited
Loading

PR #22198: Size comparison from 3d7cc78 to af66b64

Increases above 0.2%:

platform target config section 3d7cc78 af66b64 change % change
psoc6 all-clusters cy8ckit_062s2_43012 .debug_str 3393925 3403323 9398 0.3
all-clusters-minimal cy8ckit_062s2_43012 .debug_str 3382914 3392312 9398 0.3
light cy8ckit_062s2_43012 .debug_str 3189008 3198406 9398 0.3
lock cy8ckit_062s2_43012 .debug_str 3216491 3225889 9398 0.3
Increases (21 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect, psoc6)
platform target config section 3d7cc78 af66b64 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383706 16 0.0
.text 1050860 1050872 12 0.0
bl602+rpc (read/write) 1429602 1429618 16 0.0
.text 1082872 1082888 16 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672875 40 0.0
.text 583684 583724 40 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637579 24 0.0
.text 559252 559276 24 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673951 32 0.0
.text 596768 596800 32 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656727 40 0.0
.text 554440 554480 40 0.0
pump-app LP_CC2652R7 (read only) 684551 684591 40 0.0
.text 594140 594180 40 0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669099 40 0.0
.text 583096 583136 40 0.0
shell LP_CC2652R7 (read only) 665526 665566 40 0.0
.text 579428 579468 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586578 586586 8 0.0
.app_xip_area 463236 463244 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599442 599450 8 0.0
.app_xip_area 476820 476828 8 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 971380 971396 16 0.0
.text 818260 818276 16 0.0
BRD4161A+rs911x (read/write) 999896 999928 32 0.0
.text 828732 828764 32 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149228 32 0.0
.text 994944 994976 32 0.0
esp32 all-clusters-app c3devkit (read only) 1031176 1031208 32 0.0
.flash.text 1031176 1031208 32 0.0
m5stack (read only) 1084287 1084315 28 0.0
.flash.text 1078903 1078931 28 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 802964 802968 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1740372 1740404 32 0.0
.debug_info 26646623 26652798 6175 0.0
.debug_line 3647676 3647918 242 0.0
.debug_loc 3562758 3563450 692 0.0
.debug_ranges 336864 336888 24 0.0
.debug_str 3393925 3403323 9398 0.3
.text 1540760 1540792 32 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1683580 1683596 16 0.0
.debug_info 26383316 26389492 6176 0.0
.debug_line 3668080 3668322 242 0.0
.debug_loc 3550395 3551087 692 0.0
.debug_ranges 335480 335504 24 0.0
.debug_str 3382914 3392312 9398 0.3
.text 1484704 1484720 16 0.0
light cy8ckit_062s2_43012 (read/write) 1600828 1600860 32 0.0
.debug_info 21847874 21854049 6175 0.0
.debug_line 3239259 3239501 242 0.0
.debug_loc 3249910 3250602 692 0.0
.debug_ranges 301320 301344 24 0.0
.debug_str 3189008 3198406 9398 0.3
.text 1410296 1410328 32 0.0
lock cy8ckit_062s2_43012 (read/write) 1638540 1638556 16 0.0
.debug_info 22227604 22233778 6174 0.0
.debug_line 3248153 3248395 242 0.0
.debug_loc 3289747 3290439 692 0.0
.debug_ranges 304664 304688 24 0.0
.debug_str 3216491 3225889 9398 0.3
.text 1442976 1442992 16 0.0
Decreases (8 builds for cc13x2_26x2, telink)
platform target config section 3d7cc78 af66b64 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178660 178620 -40 -0.0
lock-ftd LP_CC2652R7 (read/write) 167784 167752 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 180704 180664 -40 -0.0
pump-app LP_CC2652R7 (read/write) 157960 157920 -40 -0.0
pump-controller-app LP_CC2652R7 (read/write) 173572 173532 -40 -0.0
shell LP_CC2652R7 (read/write) 181488 181448 -40 -0.0
telink light-switch-app tlsr9518adk80d text 571028 571026 -2 -0.0
lighting-app tlsr9518adk80d text 589152 589150 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 3d7cc78 af66b64 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383706 16 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050860 1050872 12 0.0
bl602+rpc (read/write) 1429602 1429618 16 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082872 1082888 16 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672875 40 0.0
(read/write) 178660 178620 -40 -0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583684 583724 40 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637579 24 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559252 559276 24 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673951 32 0.0
(read/write) 167784 167752 -32 -0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596800 32 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656727 40 0.0
(read/write) 180704 180664 -40 -0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554480 40 0.0
pump-app LP_CC2652R7 (read only) 684551 684591 40 0.0
(read/write) 157960 157920 -40 -0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594140 594180 40 0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669099 40 0.0
(read/write) 173572 173532 -40 -0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583096 583136 40 0.0
shell LP_CC2652R7 (read only) 665526 665566 40 0.0
(read/write) 181488 181448 -40 -0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579428 579468 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586578 586586 8 0.0
.app_xip_area 463236 463244 8 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592338 592338 0 0.0
.app_xip_area 464212 464212 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599442 599450 8 0.0
.app_xip_area 476820 476828 8 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107284 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968860 968860 0 0.0
BRD4161A+rpc (read/write) 971380 971396 16 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818260 818276 16 0.0
BRD4161A+rs911x (read/write) 999896 999928 32 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828732 828764 32 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149228 32 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 994976 32 0.0
window-app BRD4161A (read/write) 1098548 1098548 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958660 958660 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031176 1031208 32 0.0
(read/write) 1489650 1489650 0 0.0
.dram0.bss 71160 71160 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218448 218448 0 0.0
.flash.text 1031176 1031208 32 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084287 1084315 28 0.0
(read/write) 491568 491568 0 0.0
.dram0.bss 76664 76664 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1078903 1078931 28 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646516 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571320 0 0.0
lock k32w0+release (read/write) 704012 704012 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628344 0 0.0
linux all-clusters-app debug (read only) 3037929 3037929 0 0.0
(read/write) 156024 156024 0 0.0
.bss 61920 61920 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274635 274635 0 0.0
.text 2584146 2584146 0 0.0
all-clusters-minimal-app debug (read only) 2873793 2873793 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274827 274827 0 0.0
.text 2422594 2422594 0 0.0
bridge-app debug+rpc (read only) 2372313 2372313 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203464 203464 0 0.0
.text 2006226 2006226 0 0.0
chip-tool debug (read only) 10876545 10876545 0 0.0
(read/write) 657184 657184 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622168 622168 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 561013 561013 0 0.0
.text 8794980 8794980 0 0.0
chip-tool-ipv6only arm64 (read only) 10262564 10262564 0 0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491796 491796 0 0.0
.text 8118644 8118644 0 0.0
lighting-app debug+rpc (read only) 2597257 2597257 0 0.0
(read/write) 130304 130304 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72488 72488 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220368 220368 0 0.0
.text 2205986 2205986 0 0.0
lock-app debug (read only) 2580241 2580241 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237328 237328 0 0.0
.text 2176258 2176258 0 0.0
ota-provider-app debug (read only) 2357401 2357401 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209304 209304 0 0.0
.text 1984626 1984626 0 0.0
ota-requestor-app debug (read only) 2522921 2522921 0 0.0
(read/write) 127384 127384 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216128 216128 0 0.0
.text 2134178 2134178 0 0.0
shell debug (read only) 2606233 2606233 0 0.0
(read/write) 142144 142144 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234738 234738 0 0.0
.text 2213074 2213074 0 0.0
thermostat-no-ble arm64 (read only) 2356644 2356644 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978336 1978336 0 0.0
tv-app debug (read only) 3182745 3182745 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259080 259080 0 0.0
.text 2733922 2733922 0 0.0
tv-casting-app debug (read only) 5503505 5503505 0 0.0
(read/write) 160464 160464 0 0.0
.bss 51480 51480 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344273 344273 0 0.0
.text 4887618 4887618 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454312 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1416956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180591 0 0.0
bss 143745 143745 0 0.0
rodata 143328 143328 0 0.0
text 814560 814560 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159675 1159675 0 0.0
bss 142972 142972 0 0.0
rodata 134916 134916 0 0.0
text 802964 802968 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842120 842120 0 0.0
(read/write) 1740372 1740404 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188568 188568 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217558 1217558 0 0.0
.debug_aranges 111560 111560 0 0.0
.debug_frame 372476 372476 0 0.0
.debug_info 26646623 26652798 6175 0.0
.debug_line 3647676 3647918 242 0.0
.debug_loc 3562758 3563450 692 0.0
.debug_ranges 336864 336888 24 0.0
.debug_str 3393925 3403323 9398 0.3
.heap 842120 842120 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569449 569449 0 0.0
.symtab 420640 420640 0 0.0
.text 1540760 1540792 32 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842856 842856 0 0.0
(read/write) 1683580 1683596 16 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187832 187832 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209397 1209397 0 0.0
.debug_aranges 111032 111032 0 0.0
.debug_frame 375556 375556 0 0.0
.debug_info 26383316 26389492 6176 0.0
.debug_line 3668080 3668322 242 0.0
.debug_loc 3550395 3551087 692 0.0
.debug_ranges 335480 335504 24 0.0
.debug_str 3382914 3392312 9398 0.3
.heap 842856 842856 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533923 533923 0 0.0
.symtab 407232 407232 0 0.0
.text 1484704 1484720 16 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600828 1600860 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044070 1044070 0 0.0
.debug_aranges 103200 103200 0 0.0
.debug_frame 345800 345800 0 0.0
.debug_info 21847874 21854049 6175 0.0
.debug_line 3239259 3239501 242 0.0
.debug_loc 3249910 3250602 692 0.0
.debug_ranges 301320 301344 24 0.0
.debug_str 3189008 3198406 9398 0.3
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467204 467204 0 0.0
.symtab 374288 374288 0 0.0
.text 1410296 1410328 32 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638540 1638556 16 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051505 1051505 0 0.0
.debug_aranges 103872 103872 0 0.0
.debug_frame 348628 348628 0 0.0
.debug_info 22227604 22233778 6174 0.0
.debug_line 3248153 3248395 242 0.0
.debug_loc 3289747 3290439 692 0.0
.debug_ranges 304664 304688 24 0.0
.debug_str 3216491 3225889 9398 0.3
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473419 473419 0 0.0
.symtab 377472 377472 0 0.0
.text 1442976 1442992 16 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808416 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571028 571026 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830392 830392 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589152 589150 -2 -0.0

@bzbarsky-apple bzbarsky-apple changed the title Fix potential IPPacketInfo in LwIP code. Fix potential IPPacketInfo leak in LwIP code. Aug 27, 2022
@github-actions
Copy link

github-actions bot commented Aug 27, 2022 •
edited
Loading

PR #22198: Size comparison from 934adfd to 490ebc4

Increases above 0.2%:

platform target config section 934adfd 490ebc4 change % change
psoc6 all-clusters cy8ckit_062s2_43012 .debug_str 3394775 3404173 9398 0.3
all-clusters-minimal cy8ckit_062s2_43012 .debug_str 3383764 3393162 9398 0.3
light cy8ckit_062s2_43012 .debug_str 3189008 3198406 9398 0.3
lock cy8ckit_062s2_43012 .debug_str 3216491 3225889 9398 0.3
Increases (21 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect, psoc6, telink)
platform target config section 934adfd 490ebc4 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383706 16 0.0
.text 1050860 1050872 12 0.0
bl602+rpc (read/write) 1429602 1429618 16 0.0
.text 1082872 1082888 16 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672867 672907 40 0.0
.text 583716 583756 40 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637587 637619 32 0.0
.text 559284 559316 32 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673951 32 0.0
.text 596768 596800 32 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656727 40 0.0
.text 554440 554480 40 0.0
pump-app LP_CC2652R7 (read only) 684599 684639 40 0.0
.text 594188 594228 40 0.0
pump-controller-app LP_CC2652R7 (read only) 669091 669131 40 0.0
.text 583128 583168 40 0.0
shell LP_CC2652R7 (read only) 665574 665614 40 0.0
.text 579476 579516 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586578 586586 8 0.0
.app_xip_area 463236 463244 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599442 599450 8 0.0
.app_xip_area 476820 476828 8 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 999896 999928 32 0.0
.text 828732 828764 32 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149228 32 0.0
.text 994944 994976 32 0.0
esp32 all-clusters-app c3devkit (read only) 1031282 1031314 32 0.0
.flash.text 1031282 1031314 32 0.0
m5stack (read only) 1084319 1084347 28 0.0
.flash.text 1078935 1078963 28 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180495 1180511 16 0.0
text 814592 814596 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1740364 1740380 16 0.0
.debug_info 26647573 26653747 6174 0.0
.debug_line 3648191 3648433 242 0.0
.debug_loc 3563899 3564591 692 0.0
.debug_ranges 337208 337232 24 0.0
.debug_str 3394775 3404173 9398 0.3
.text 1540856 1540872 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1683556 1683572 16 0.0
.debug_info 26384268 26390443 6175 0.0
.debug_line 3668595 3668837 242 0.0
.debug_loc 3551536 3552228 692 0.0
.debug_ranges 335824 335848 24 0.0
.debug_str 3383764 3393162 9398 0.3
.text 1484784 1484800 16 0.0
light cy8ckit_062s2_43012 (read/write) 1600828 1600860 32 0.0
.debug_info 21847875 21854050 6175 0.0
.debug_line 3239259 3239501 242 0.0
.debug_loc 3249910 3250602 692 0.0
.debug_ranges 301320 301344 24 0.0
.debug_str 3189008 3198406 9398 0.3
.text 1410296 1410328 32 0.0
lock cy8ckit_062s2_43012 (read/write) 1638540 1638556 16 0.0
.debug_info 22227604 22233778 6174 0.0
.debug_line 3248153 3248395 242 0.0
.debug_loc 3289747 3290439 692 0.0
.debug_ranges 304664 304688 24 0.0
.debug_str 3216491 3225889 9398 0.3
.text 1442976 1442992 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 830328 830336 8 0.0
text 589194 589198 4 0.0
Decreases (6 builds for cc13x2_26x2)
platform target config section 934adfd 490ebc4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178524 178484 -40 -0.0
lock-ftd LP_CC2652R7 (read/write) 167784 167752 -32 -0.0
lock-mtd LP_CC2652R7 (read/write) 180704 180664 -40 -0.0
pump-app LP_CC2652R7 (read/write) 157808 157768 -40 -0.0
pump-controller-app LP_CC2652R7 (read/write) 173428 173388 -40 -0.0
shell LP_CC2652R7 (read/write) 181336 181296 -40 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 934adfd 490ebc4 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383706 16 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050860 1050872 12 0.0
bl602+rpc (read/write) 1429602 1429618 16 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082872 1082888 16 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672867 672907 40 0.0
(read/write) 178524 178484 -40 -0.0
.bss 74284 74284 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583716 583756 40 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637587 637619 32 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559284 559316 32 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673951 32 0.0
(read/write) 167784 167752 -32 -0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596800 32 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656727 40 0.0
(read/write) 180704 180664 -40 -0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554480 40 0.0
pump-app LP_CC2652R7 (read only) 684599 684639 40 0.0
(read/write) 157808 157768 -40 -0.0
.bss 71420 71420 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594188 594228 40 0.0
pump-controller-app LP_CC2652R7 (read only) 669091 669131 40 0.0
(read/write) 173428 173388 -40 -0.0
.bss 71532 71532 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583128 583168 40 0.0
shell LP_CC2652R7 (read only) 665574 665614 40 0.0
(read/write) 181336 181296 -40 -0.0
.bss 76604 76604 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579476 579516 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586578 586586 8 0.0
.app_xip_area 463236 463244 8 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592346 0 0.0
.app_xip_area 464220 464220 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599442 599450 8 0.0
.app_xip_area 476820 476828 8 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107284 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968860 968860 0 0.0
BRD4161A+rpc (read/write) 971396 971396 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818276 818276 0 0.0
BRD4161A+rs911x (read/write) 999896 999928 32 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828732 828764 32 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149228 32 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 994976 32 0.0
window-app BRD4161A (read/write) 1098548 1098548 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958660 958660 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031282 1031314 32 0.0
(read/write) 1489538 1489538 0 0.0
.dram0.bss 71056 71056 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218448 218448 0 0.0
.flash.text 1031282 1031314 32 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084319 1084347 28 0.0
(read/write) 491460 491460 0 0.0
.dram0.bss 76560 76560 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248760 248760 0 0.0
.flash.text 1078935 1078963 28 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646516 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571320 0 0.0
lock k32w0+release (read/write) 704012 704012 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628344 0 0.0
linux all-clusters-app debug (read only) 3038249 3038249 0 0.0
(read/write) 155896 155896 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274635 274635 0 0.0
.text 2584466 2584466 0 0.0
all-clusters-minimal-app debug (read only) 2874113 2874113 0 0.0
(read/write) 147496 147496 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274827 274827 0 0.0
.text 2422914 2422914 0 0.0
bridge-app debug+rpc (read only) 2372313 2372313 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203464 203464 0 0.0
.text 2006226 2006226 0 0.0
chip-tool debug (read only) 10876545 10876545 0 0.0
(read/write) 657184 657184 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622168 622168 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 561013 561013 0 0.0
.text 8794980 8794980 0 0.0
chip-tool-ipv6only arm64 (read only) 10262564 10262564 0 0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491796 491796 0 0.0
.text 8118644 8118644 0 0.0
lighting-app debug+rpc (read only) 2597257 2597257 0 0.0
(read/write) 130304 130304 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72488 72488 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220368 220368 0 0.0
.text 2205986 2205986 0 0.0
lock-app debug (read only) 2580241 2580241 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237328 237328 0 0.0
.text 2176258 2176258 0 0.0
ota-provider-app debug (read only) 2357401 2357401 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209304 209304 0 0.0
.text 1984626 1984626 0 0.0
ota-requestor-app debug (read only) 2522921 2522921 0 0.0
(read/write) 127384 127384 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216128 216128 0 0.0
.text 2134178 2134178 0 0.0
shell debug (read only) 2606553 2606553 0 0.0
(read/write) 142016 142016 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234738 234738 0 0.0
.text 2213394 2213394 0 0.0
thermostat-no-ble arm64 (read only) 2356996 2356996 0 0.0
(read/write) 141681 141681 0 0.0
.bss 55217 55217 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978704 1978704 0 0.0
tv-app debug (read only) 3183065 3183065 0 0.0
(read/write) 257840 257840 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259080 259080 0 0.0
.text 2734242 2734242 0 0.0
tv-casting-app debug (read only) 5503825 5503825 0 0.0
(read/write) 160336 160336 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344273 344273 0 0.0
.text 4887938 4887938 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454312 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1416956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180495 1180511 16 0.0
bss 143641 143641 0 0.0
rodata 143328 143328 0 0.0
text 814592 814596 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159707 1159707 0 0.0
bss 142868 142868 0 0.0
rodata 134916 134916 0 0.0
text 803004 803004 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842224 842224 0 0.0
(read/write) 1740364 1740380 16 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188464 188464 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217412 1217412 0 0.0
.debug_aranges 111552 111552 0 0.0
.debug_frame 372452 372452 0 0.0
.debug_info 26647573 26653747 6174 0.0
.debug_line 3648191 3648433 242 0.0
.debug_loc 3563899 3564591 692 0.0
.debug_ranges 337208 337232 24 0.0
.debug_str 3394775 3404173 9398 0.3
.heap 842224 842224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569431 569431 0 0.0
.symtab 420608 420608 0 0.0
.text 1540856 1540872 16 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842960 842960 0 0.0
(read/write) 1683556 1683572 16 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187728 187728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209251 1209251 0 0.0
.debug_aranges 111024 111024 0 0.0
.debug_frame 375532 375532 0 0.0
.debug_info 26384268 26390443 6175 0.0
.debug_line 3668595 3668837 242 0.0
.debug_loc 3551536 3552228 692 0.0
.debug_ranges 335824 335848 24 0.0
.debug_str 3383764 3393162 9398 0.3
.heap 842960 842960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533905 533905 0 0.0
.symtab 407200 407200 0 0.0
.text 1484784 1484800 16 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600828 1600860 32 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044070 1044070 0 0.0
.debug_aranges 103200 103200 0 0.0
.debug_frame 345800 345800 0 0.0
.debug_info 21847875 21854050 6175 0.0
.debug_line 3239259 3239501 242 0.0
.debug_loc 3249910 3250602 692 0.0
.debug_ranges 301320 301344 24 0.0
.debug_str 3189008 3198406 9398 0.3
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467204 467204 0 0.0
.symtab 374288 374288 0 0.0
.text 1410296 1410328 32 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638540 1638556 16 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051505 1051505 0 0.0
.debug_aranges 103872 103872 0 0.0
.debug_frame 348628 348628 0 0.0
.debug_info 22227604 22233778 6174 0.0
.debug_line 3248153 3248395 242 0.0
.debug_loc 3289747 3290439 692 0.0
.debug_ranges 304664 304688 24 0.0
.debug_str 3216491 3225889 9398 0.3
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473419 473419 0 0.0
.symtab 377472 377472 0 0.0
.text 1442976 1442992 16 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808444 808444 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571100 571100 0 0.0
lighting-app tlsr9518adk80d (read/write) 830328 830336 8 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589194 589198 4 0.0

@bzbarsky-apple bzbarsky-apple merged commit 55e5718 into project-chip:master Aug 29, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-pktinfo-leak branch August 29, 2022 02:09
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Fix potential IPPacketInfo leak in LwIP code. (project-chip#22198)
178b3c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
inet review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @tcarmelveilleux @jmartinez-silabs