-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Control Cluster: EnhancedMoveToHue Command bugfix. #22187
Merged
andy31415
merged 1 commit into
project-chip:master
from
rcasallas-silabs:color_control-enhance_move_to_hue-bugfix
Aug 29, 2022
Merged
Color Control Cluster: EnhancedMoveToHue Command bugfix. #22187
andy31415
merged 1 commit into
project-chip:master
from
rcasallas-silabs:color_control-enhance_move_to_hue-bugfix
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang,
rgoliver and
robszewczyk
August 26, 2022 16:30
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
August 26, 2022 16:30
rcasallas-silabs
force-pushed
the
color_control-enhance_move_to_hue-bugfix
branch
from
August 26, 2022 16:31
ec89849
to
ebae327
Compare
PR #22187: Size comparison from 35c4d69 to ebae327 Increases (19 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
selissia
approved these changes
Aug 26, 2022
jmartinez-silabs
approved these changes
Aug 28, 2022
rcasallas-silabs
force-pushed
the
color_control-enhance_move_to_hue-bugfix
branch
from
August 29, 2022 13:58
ebae327
to
0058cf3
Compare
PR #22187: Size comparison from 0bc1578 to 0058cf3 Increases (20 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
andy31415
approved these changes
Aug 29, 2022
pankore
pushed a commit
to pankore/connectedhomeip
that referenced
this pull request
Sep 2, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Sep 2, 2022
stoneM2017
added a commit
to bouffalolab/connectedhomeip-1
that referenced
this pull request
Sep 4, 2022
pankore
pushed a commit
to pankore/connectedhomeip
that referenced
this pull request
Sep 15, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Sep 15, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Spec requirement unfulfilled in EnhancedMoveToHue command.
Change overview
Now EnhancedMoveToHue command sets ColorMode, and EnhancedColorMode attributes according to 3.2.11.15.5.
Testing
Tested on EFR32 device using the Lighting app.