-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Add a header guard for thread #22176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Problem There is no header guard for ThreadStackManager.h And softap module is not currently used. - Summary of Changes Add the header guard for ThreadStackManager.h using CHIP_DEVICE_CONFIG_ENABLE_THREAD. Remove the softap content from the pkg config. - Summary of Changes chip-tool and chip-lighting-app examples Signed-off-by: hyunuk.tak <[email protected]>
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton and
jepenven-silabs
August 26, 2022 00:11
pullapprove
bot
requested review from
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
August 26, 2022 00:11
dh79pyun
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
PR #22176: Size comparison from b8caa3d to 261c30d Increases (8 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (4 builds for bl602, cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
PR #22176: Size comparison from 48a4797 to 44ae724 Increases (3 builds for esp32, nrfconnect, psoc6)
Decreases (4 builds for psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
bzbarsky-apple
approved these changes
Aug 27, 2022
andy31415
approved these changes
Aug 29, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
- Problem There is no header guard for ThreadStackManager.h And softap module is not currently used. - Summary of Changes Add the header guard for ThreadStackManager.h using CHIP_DEVICE_CONFIG_ENABLE_THREAD. Remove the softap content from the pkg config. - Summary of Changes chip-tool and chip-lighting-app examples Signed-off-by: hyunuk.tak <[email protected]> Signed-off-by: hyunuk.tak <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no header guard for ThreadStackManager.h
And softap module is not currently used.
Summary of Changes
Add the header guard for ThreadStackManager.h using CHIP_DEVICE_CONFIG_ENABLE_THREAD.
Remove the softap content from the pkg config.
Summary of Changes
chip-tool and chip-lighting-app examples