Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback from https://github.com/project-chip/connectedhomeip/issues/22197 #22175

Merged
merged 8 commits into from
Sep 1, 2022
Merged

Address feedback from https://github.com/project-chip/connectedhomeip/issues/22197 #22175

merged 8 commits into from
Sep 1, 2022

Conversation

sharadb-amazon
Copy link
Contributor

@sharadb-amazon sharadb-amazon commented Aug 25, 2022 •
edited
Loading

Problem

This addresses feedback captured in a previous PR and tracked as part of this issue: #22197
Also, addressing the comment in #22115 (review)

Change overview

  1. Made ipk and adminSubject params Nullable explicitly in the protocol def.
  2. Removed sync dispatches to get commissioning params from the MTROperationalCredentialsDelegate.mm
  3. Allocated and Deallocated partialDacVerifier before assignment (Darwin: Allow partial validation of DAC and CD (for external cloud or custom app based validation) #22115 (review))

Testing

Built and tested using the iOS chip controller.

@pullapprove pullapprove bot requested a review from yunhanw-google August 25, 2022 22:31
@github-actions
Copy link

github-actions bot commented Aug 25, 2022 •
edited
Loading

PR #22175: Size comparison from 5c2334a to c64e328

Increases (9 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
platform target config section 5c2334a c64e328 change % change
bl602 lighting-app bl602 .text 1050856 1050860 4 0.0
bl602+rpc .text 1082872 1082876 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672827 672835 8 0.0
.text 583676 583684 8 0.0
pump-app LP_CC2652R7 (read/write) 157960 157968 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814556 814560 4 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26383317 26383318 1 0.0
light cy8ckit_062s2_43012 .debug_info 21847873 21847875 2 0.0
telink light-switch-app tlsr9518adk80d text 571026 571028 2 0.0
lighting-app tlsr9518adk80d (read/write) 830384 830392 8 0.0
text 589148 589150 2 0.0
Decreases (5 builds for cc13x2_26x2, cyw30739)
platform target config section 5c2334a c64e328 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178668 178660 -8 -0.0
pump-app LP_CC2652R7 (read only) 684551 684543 -8 -0.0
.text 594140 594132 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586578 -8 -0.0
.app_xip_area 463244 463236 -8 -0.0
lock cyw930739m2evb_01 (read/write) 592346 592338 -8 -0.0
.app_xip_area 464220 464212 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599442 -8 -0.0
.app_xip_area 476828 476820 -8 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 5c2334a c64e328 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383690 0 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050856 1050860 4 0.0
bl602+rpc (read/write) 1429602 1429602 0 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082872 1082876 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672827 672835 8 0.0
(read/write) 178668 178660 -8 -0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583676 583684 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637555 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559252 559252 0 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673919 0 0.0
(read/write) 167784 167784 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596768 0 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656687 0 0.0
(read/write) 180704 180704 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554440 0 0.0
pump-app LP_CC2652R7 (read only) 684551 684543 -8 -0.0
(read/write) 157960 157968 8 0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594140 594132 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669059 0 0.0
(read/write) 173572 173572 0 0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583096 583096 0 0.0
shell LP_CC2652R7 (read only) 665526 665526 0 0.0
(read/write) 181488 181488 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579428 579428 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586578 -8 -0.0
.app_xip_area 463244 463236 -8 -0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592338 -8 -0.0
.app_xip_area 464220 464212 -8 -0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599442 -8 -0.0
.app_xip_area 476828 476820 -8 -0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107284 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968860 968860 0 0.0
BRD4161A+rpc (read/write) 971396 971396 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818276 818276 0 0.0
BRD4161A+rs911x (read/write) 999896 999896 0 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828732 828732 0 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149196 0 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 994944 0 0.0
window-app BRD4161A (read/write) 1098548 1098548 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958660 958660 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031178 1031178 0 0.0
(read/write) 1489650 1489650 0 0.0
.dram0.bss 71160 71160 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218448 218448 0 0.0
.flash.text 1031178 1031178 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084287 1084287 0 0.0
(read/write) 491568 491568 0 0.0
.dram0.bss 76664 76664 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1078903 1078903 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646516 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571320 0 0.0
lock k32w0+release (read/write) 704012 704012 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628344 0 0.0
linux all-clusters-app debug (read only) 3037929 3037929 0 0.0
(read/write) 156024 156024 0 0.0
.bss 61920 61920 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274635 274635 0 0.0
.text 2584146 2584146 0 0.0
all-clusters-minimal-app debug (read only) 2873793 2873793 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274827 274827 0 0.0
.text 2422594 2422594 0 0.0
bridge-app debug+rpc (read only) 2372313 2372313 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203464 203464 0 0.0
.text 2006226 2006226 0 0.0
chip-tool debug (read only) 10878417 10878417 0 0.0
(read/write) 657184 657184 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622168 622168 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 561365 561365 0 0.0
.text 8796500 8796500 0 0.0
chip-tool-ipv6only arm64 (read only) 10264052 10264052 0 0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492132 492132 0 0.0
.text 8119796 8119796 0 0.0
lighting-app debug+rpc (read only) 2597257 2597257 0 0.0
(read/write) 130304 130304 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72488 72488 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220368 220368 0 0.0
.text 2205986 2205986 0 0.0
lock-app debug (read only) 2580241 2580241 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237328 237328 0 0.0
.text 2176258 2176258 0 0.0
ota-provider-app debug (read only) 2357401 2357401 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209304 209304 0 0.0
.text 1984626 1984626 0 0.0
ota-requestor-app debug (read only) 2522921 2522921 0 0.0
(read/write) 127384 127384 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216128 216128 0 0.0
.text 2134178 2134178 0 0.0
shell debug (read only) 2606233 2606233 0 0.0
(read/write) 142144 142144 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234738 234738 0 0.0
.text 2213074 2213074 0 0.0
thermostat-no-ble arm64 (read only) 2356644 2356644 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978336 1978336 0 0.0
tv-app debug (read only) 3182745 3182745 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259080 259080 0 0.0
.text 2733922 2733922 0 0.0
tv-casting-app debug (read only) 5503505 5503505 0 0.0
(read/write) 160464 160464 0 0.0
.bss 51480 51480 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344273 344273 0 0.0
.text 4887618 4887618 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454312 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1416956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180591 0 0.0
bss 143745 143745 0 0.0
rodata 143328 143328 0 0.0
text 814556 814560 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159675 1159675 0 0.0
bss 142972 142972 0 0.0
rodata 134916 134916 0 0.0
text 802968 802968 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842120 842120 0 0.0
(read/write) 1740372 1740372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188568 188568 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217558 1217558 0 0.0
.debug_aranges 111560 111560 0 0.0
.debug_frame 372476 372476 0 0.0
.debug_info 26646622 26646622 0 0.0
.debug_line 3647676 3647676 0 0.0
.debug_loc 3562758 3562758 0 0.0
.debug_ranges 336864 336864 0 0.0
.debug_str 3393925 3393925 0 0.0
.heap 842120 842120 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569449 569449 0 0.0
.symtab 420640 420640 0 0.0
.text 1540760 1540760 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842856 842856 0 0.0
(read/write) 1683580 1683580 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187832 187832 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209397 1209397 0 0.0
.debug_aranges 111032 111032 0 0.0
.debug_frame 375556 375556 0 0.0
.debug_info 26383317 26383318 1 0.0
.debug_line 3668080 3668080 0 0.0
.debug_loc 3550395 3550395 0 0.0
.debug_ranges 335480 335480 0 0.0
.debug_str 3382914 3382914 0 0.0
.heap 842856 842856 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533923 533923 0 0.0
.symtab 407232 407232 0 0.0
.text 1484704 1484704 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600828 1600828 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044070 1044070 0 0.0
.debug_aranges 103200 103200 0 0.0
.debug_frame 345800 345800 0 0.0
.debug_info 21847873 21847875 2 0.0
.debug_line 3239259 3239259 0 0.0
.debug_loc 3249910 3249910 0 0.0
.debug_ranges 301320 301320 0 0.0
.debug_str 3189008 3189008 0 0.0
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467204 467204 0 0.0
.symtab 374288 374288 0 0.0
.text 1410296 1410296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638540 1638540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051505 1051505 0 0.0
.debug_aranges 103872 103872 0 0.0
.debug_frame 348628 348628 0 0.0
.debug_info 22227604 22227604 0 0.0
.debug_line 3248153 3248153 0 0.0
.debug_loc 3289747 3289747 0 0.0
.debug_ranges 304664 304664 0 0.0
.debug_str 3216491 3216491 0 0.0
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473419 473419 0 0.0
.symtab 377472 377472 0 0.0
.text 1442976 1442976 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808416 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571026 571028 2 0.0
lighting-app tlsr9518adk80d (read/write) 830384 830392 8 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589148 589150 2 0.0

@sharadb-amazon sharadb-amazon changed the title Adding syntactic sugar to make MTRNOCChainIssuer work better with Swift apps Address feedback from https://github.com/project-chip/connectedhomeip/issues/22197 Aug 26, 2022
@github-actions
Copy link

github-actions bot commented Aug 26, 2022 •
edited
Loading

PR #22175: Size comparison from 7e00546 to 04dc37a

Increases (2 builds for cyw30739, efr32)
platform target config section 7e00546 04dc37a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 586578 586586 8 0.0
.app_xip_area 463236 463244 8 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 971380 971396 16 0.0
.text 818260 818276 16 0.0
Decreases (4 builds for nrfconnect, psoc6, telink)
platform target config section 7e00546 04dc37a change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180511 1180495 -16 -0.0
text 814596 814592 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26647573 26647572 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22227605 22227604 -1 -0.0
telink lighting-app tlsr9518adk80d text 589196 589194 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 7e00546 04dc37a change % change
bl602 lighting-app bl602 (read/write) 1383690 1383690 0 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050856 1050856 0 0.0
bl602+rpc (read/write) 1429602 1429602 0 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082872 1082872 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672859 672859 0 0.0
(read/write) 178532 178532 0 0.0
.bss 74284 74284 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583708 583708 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637587 637587 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559284 559284 0 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673919 0 0.0
(read/write) 167784 167784 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596768 0 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656687 0 0.0
(read/write) 180704 180704 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554440 0 0.0
pump-app LP_CC2652R7 (read only) 684599 684599 0 0.0
(read/write) 157808 157808 0 0.0
.bss 71420 71420 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594188 594188 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669091 669091 0 0.0
(read/write) 173428 173428 0 0.0
.bss 71532 71532 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583128 583128 0 0.0
shell LP_CC2652R7 (read only) 665574 665574 0 0.0
(read/write) 181336 181336 0 0.0
.bss 76604 76604 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579476 579476 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586578 586586 8 0.0
.app_xip_area 463236 463244 8 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592346 0 0.0
.app_xip_area 464220 464220 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599450 0 0.0
.app_xip_area 476828 476828 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107284 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968860 968860 0 0.0
BRD4161A+rpc (read/write) 971380 971396 16 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818260 818276 16 0.0
BRD4161A+rs911x (read/write) 999896 999896 0 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828732 828732 0 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149196 0 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 994944 0 0.0
window-app BRD4161A (read/write) 1098548 1098548 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958660 958660 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031282 1031282 0 0.0
(read/write) 1489538 1489538 0 0.0
.dram0.bss 71056 71056 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218448 218448 0 0.0
.flash.text 1031282 1031282 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084319 1084319 0 0.0
(read/write) 491460 491460 0 0.0
.dram0.bss 76560 76560 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248760 248760 0 0.0
.flash.text 1078935 1078935 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646516 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571320 0 0.0
lock k32w0+release (read/write) 704012 704012 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628344 0 0.0
linux all-clusters-app debug (read only) 3038249 3038249 0 0.0
(read/write) 155896 155896 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274635 274635 0 0.0
.text 2584466 2584466 0 0.0
all-clusters-minimal-app debug (read only) 2874113 2874113 0 0.0
(read/write) 147496 147496 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274827 274827 0 0.0
.text 2422914 2422914 0 0.0
bridge-app debug+rpc (read only) 2372313 2372313 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203464 203464 0 0.0
.text 2006226 2006226 0 0.0
chip-tool debug (read only) 10876545 10876545 0 0.0
(read/write) 657184 657184 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622168 622168 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 561013 561013 0 0.0
.text 8794980 8794980 0 0.0
chip-tool-ipv6only arm64 (read only) 10262564 10262564 0 0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491796 491796 0 0.0
.text 8118644 8118644 0 0.0
lighting-app debug+rpc (read only) 2597257 2597257 0 0.0
(read/write) 130304 130304 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72488 72488 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220368 220368 0 0.0
.text 2205986 2205986 0 0.0
lock-app debug (read only) 2580241 2580241 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237328 237328 0 0.0
.text 2176258 2176258 0 0.0
ota-provider-app debug (read only) 2357401 2357401 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209304 209304 0 0.0
.text 1984626 1984626 0 0.0
ota-requestor-app debug (read only) 2522921 2522921 0 0.0
(read/write) 127384 127384 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216128 216128 0 0.0
.text 2134178 2134178 0 0.0
shell debug (read only) 2606553 2606553 0 0.0
(read/write) 142016 142016 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234738 234738 0 0.0
.text 2213394 2213394 0 0.0
thermostat-no-ble arm64 (read only) 2356996 2356996 0 0.0
(read/write) 141681 141681 0 0.0
.bss 55217 55217 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978704 1978704 0 0.0
tv-app debug (read only) 3183065 3183065 0 0.0
(read/write) 257840 257840 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259080 259080 0 0.0
.text 2734242 2734242 0 0.0
tv-casting-app debug (read only) 5503825 5503825 0 0.0
(read/write) 160336 160336 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344273 344273 0 0.0
.text 4887938 4887938 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454312 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1416956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180511 1180495 -16 -0.0
bss 143641 143641 0 0.0
rodata 143328 143328 0 0.0
text 814596 814592 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159707 1159707 0 0.0
bss 142868 142868 0 0.0
rodata 134916 134916 0 0.0
text 803004 803004 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842224 842224 0 0.0
(read/write) 1740364 1740364 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188464 188464 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217412 1217412 0 0.0
.debug_aranges 111552 111552 0 0.0
.debug_frame 372452 372452 0 0.0
.debug_info 26647573 26647572 -1 -0.0
.debug_line 3648191 3648191 0 0.0
.debug_loc 3563899 3563899 0 0.0
.debug_ranges 337208 337208 0 0.0
.debug_str 3394775 3394775 0 0.0
.heap 842224 842224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569431 569431 0 0.0
.symtab 420608 420608 0 0.0
.text 1540856 1540856 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842960 842960 0 0.0
(read/write) 1683556 1683556 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187728 187728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209251 1209251 0 0.0
.debug_aranges 111024 111024 0 0.0
.debug_frame 375532 375532 0 0.0
.debug_info 26384268 26384268 0 0.0
.debug_line 3668595 3668595 0 0.0
.debug_loc 3551536 3551536 0 0.0
.debug_ranges 335824 335824 0 0.0
.debug_str 3383764 3383764 0 0.0
.heap 842960 842960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533905 533905 0 0.0
.symtab 407200 407200 0 0.0
.text 1484784 1484784 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600828 1600828 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044070 1044070 0 0.0
.debug_aranges 103200 103200 0 0.0
.debug_frame 345800 345800 0 0.0
.debug_info 21847874 21847874 0 0.0
.debug_line 3239259 3239259 0 0.0
.debug_loc 3249910 3249910 0 0.0
.debug_ranges 301320 301320 0 0.0
.debug_str 3189008 3189008 0 0.0
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467204 467204 0 0.0
.symtab 374288 374288 0 0.0
.text 1410296 1410296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638540 1638540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051505 1051505 0 0.0
.debug_aranges 103872 103872 0 0.0
.debug_frame 348628 348628 0 0.0
.debug_info 22227605 22227604 -1 -0.0
.debug_line 3248153 3248153 0 0.0
.debug_loc 3289747 3289747 0 0.0
.debug_ranges 304664 304664 0 0.0
.debug_str 3216491 3216491 0 0.0
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473419 473419 0 0.0
.symtab 377472 377472 0 0.0
.text 1442976 1442976 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808444 808444 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571098 571098 0 0.0
lighting-app tlsr9518adk80d (read/write) 830328 830328 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589196 589194 -2 -0.0

bzbarsky-apple
bzbarsky-apple reviewed Aug 27, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this seems to address the potential use-after-free of mCppCommissioner....

src/darwin/Framework/CHIP/MTRDeviceController.mm Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRDeviceController.mm Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 27, 2022 •
edited
Loading

PR #22175: Size comparison from 7e00546 to 6723226

Increases (33 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 7e00546 6723226 change % change
bl602 lighting-app bl602 .text 1050856 1050860 4 0.0
bl602+rpc .text 1082872 1082876 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672859 672867 8 0.0
.text 583708 583716 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586578 586602 24 0.0
.app_xip_area 463236 463260 24 0.0
lock cyw930739m2evb_01 (read/write) 592346 592362 16 0.0
.app_xip_area 464220 464236 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599506 56 0.0
.app_xip_area 476828 476884 56 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107340 56 0.0
.text 968860 968916 56 0.0
BRD4161A+rpc (read/write) 971380 971444 64 0.0
.text 818260 818324 64 0.0
window-app BRD4161A (read/write) 1098548 1098612 64 0.0
.text 958660 958724 64 0.0
k32w light k32w0+release (read/write) 646516 646532 16 0.0
.text 571320 571336 16 0.0
lock k32w0+release (read/write) 704012 704028 16 0.0
.text 628344 628360 16 0.0
linux all-clusters-app debug (read only) 3038249 3038345 96 0.0
.rodata 274635 274667 32 0.0
.text 2584466 2584530 64 0.0
all-clusters-minimal-app debug (read only) 2874113 2874209 96 0.0
.rodata 274827 274859 32 0.0
.text 2422914 2422978 64 0.0
bridge-app debug+rpc (read only) 2372313 2372409 96 0.0
.rodata 203464 203496 32 0.0
.text 2006226 2006290 64 0.0
chip-tool debug (read only) 10876545 10876641 96 0.0
.rodata 561013 561045 32 0.0
.text 8794980 8795044 64 0.0
chip-tool-ipv6only arm64 (read only) 10262564 10262692 128 0.0
.rodata 491796 491828 32 0.0
.text 8118644 8118740 96 0.0
lighting-app debug+rpc (read only) 2597257 2597353 96 0.0
.rodata 220368 220400 32 0.0
.text 2205986 2206050 64 0.0
lock-app debug (read only) 2580241 2580337 96 0.0
.rodata 237328 237360 32 0.0
.text 2176258 2176322 64 0.0
ota-provider-app debug (read only) 2357401 2357497 96 0.0
.rodata 209304 209336 32 0.0
.text 1984626 1984690 64 0.0
ota-requestor-app debug (read only) 2522921 2523017 96 0.0
.rodata 216128 216160 32 0.0
.text 2134178 2134242 64 0.0
shell debug (read only) 2606553 2606649 96 0.0
.rodata 234738 234770 32 0.0
.text 2213394 2213458 64 0.0
thermostat-no-ble arm64 (read only) 2356996 2357108 112 0.0
.rodata 140588 140620 32 0.0
.text 1978704 1978784 80 0.0
tv-app debug (read only) 3183065 3183161 96 0.0
.rodata 259080 259112 32 0.0
.text 2734242 2734306 64 0.0
tv-casting-app debug (read only) 5503825 5503921 96 0.0
.rodata 344273 344305 32 0.0
.text 4887938 4888002 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2454312 2454344 32 0.0
.text 1416956 1416988 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180511 1180559 48 0.0
rodata 143328 143360 32 0.0
text 814596 814620 24 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159707 1159771 64 0.0
rodata 134916 134948 32 0.0
text 803004 803028 24 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_abbrev 1217412 1217436 24 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_abbrev 1209251 1209275 24 0.0
light cy8ckit_062s2_43012 .debug_abbrev 1044070 1044094 24 0.0
lock cy8ckit_062s2_43012 .debug_abbrev 1051505 1051529 24 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808444 808508 64 0.0
text 571098 571128 30 0.0
lighting-app tlsr9518adk80d (read/write) 830328 830392 64 0.0
text 589196 589224 28 0.0
Decreases (5 builds for cc13x2_26x2, psoc6)
platform target config section 7e00546 6723226 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178532 178524 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26647573 26647572 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26384268 26384266 -2 -0.0
light cy8ckit_062s2_43012 .debug_info 21847874 21847872 -2 -0.0
lock cy8ckit_062s2_43012 .debug_info 22227605 22227603 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 7e00546 6723226 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383690 0 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050856 1050860 4 0.0
bl602+rpc (read/write) 1429602 1429602 0 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082872 1082876 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672859 672867 8 0.0
(read/write) 178532 178524 -8 -0.0
.bss 74284 74284 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583708 583716 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637587 637587 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559284 559284 0 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673919 0 0.0
(read/write) 167784 167784 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596768 0 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656687 0 0.0
(read/write) 180704 180704 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554440 0 0.0
pump-app LP_CC2652R7 (read only) 684599 684599 0 0.0
(read/write) 157808 157808 0 0.0
.bss 71420 71420 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594188 594188 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669091 669091 0 0.0
(read/write) 173428 173428 0 0.0
.bss 71532 71532 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583128 583128 0 0.0
shell LP_CC2652R7 (read only) 665574 665574 0 0.0
(read/write) 181336 181336 0 0.0
.bss 76604 76604 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579476 579476 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586578 586602 24 0.0
.app_xip_area 463236 463260 24 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592362 16 0.0
.app_xip_area 464220 464236 16 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599506 56 0.0
.app_xip_area 476828 476884 56 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107284 1107340 56 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968860 968916 56 0.0
BRD4161A+rpc (read/write) 971380 971444 64 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818260 818324 64 0.0
BRD4161A+rs911x (read/write) 999896 999896 0 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828732 828732 0 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149196 0 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 994944 0 0.0
window-app BRD4161A (read/write) 1098548 1098612 64 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958660 958724 64 0.0
esp32 all-clusters-app c3devkit (read only) 1031282 1031282 0 0.0
(read/write) 1489538 1489538 0 0.0
.dram0.bss 71056 71056 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218448 218448 0 0.0
.flash.text 1031282 1031282 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084319 1084319 0 0.0
(read/write) 491460 491460 0 0.0
.dram0.bss 76560 76560 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248760 248760 0 0.0
.flash.text 1078935 1078935 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646532 16 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571336 16 0.0
lock k32w0+release (read/write) 704012 704028 16 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628360 16 0.0
linux all-clusters-app debug (read only) 3038249 3038345 96 0.0
(read/write) 155896 155896 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274635 274667 32 0.0
.text 2584466 2584530 64 0.0
all-clusters-minimal-app debug (read only) 2874113 2874209 96 0.0
(read/write) 147496 147496 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274827 274859 32 0.0
.text 2422914 2422978 64 0.0
bridge-app debug+rpc (read only) 2372313 2372409 96 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203464 203496 32 0.0
.text 2006226 2006290 64 0.0
chip-tool debug (read only) 10876545 10876641 96 0.0
(read/write) 657184 657184 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622168 622168 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 561013 561045 32 0.0
.text 8794980 8795044 64 0.0
chip-tool-ipv6only arm64 (read only) 10262564 10262692 128 0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491796 491828 32 0.0
.text 8118644 8118740 96 0.0
lighting-app debug+rpc (read only) 2597257 2597353 96 0.0
(read/write) 130304 130304 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72488 72488 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220368 220400 32 0.0
.text 2205986 2206050 64 0.0
lock-app debug (read only) 2580241 2580337 96 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237328 237360 32 0.0
.text 2176258 2176322 64 0.0
ota-provider-app debug (read only) 2357401 2357497 96 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209304 209336 32 0.0
.text 1984626 1984690 64 0.0
ota-requestor-app debug (read only) 2522921 2523017 96 0.0
(read/write) 127384 127384 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216128 216160 32 0.0
.text 2134178 2134242 64 0.0
shell debug (read only) 2606553 2606649 96 0.0
(read/write) 142016 142016 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234738 234770 32 0.0
.text 2213394 2213458 64 0.0
thermostat-no-ble arm64 (read only) 2356996 2357108 112 0.0
(read/write) 141681 141681 0 0.0
.bss 55217 55217 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140620 32 0.0
.text 1978704 1978784 80 0.0
tv-app debug (read only) 3183065 3183161 96 0.0
(read/write) 257840 257840 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259080 259112 32 0.0
.text 2734242 2734306 64 0.0
tv-casting-app debug (read only) 5503825 5503921 96 0.0
(read/write) 160336 160336 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344273 344305 32 0.0
.text 4887938 4888002 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454344 32 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1416988 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180511 1180559 48 0.0
bss 143641 143641 0 0.0
rodata 143328 143360 32 0.0
text 814596 814620 24 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159707 1159771 64 0.0
bss 142868 142868 0 0.0
rodata 134916 134948 32 0.0
text 803004 803028 24 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842224 842224 0 0.0
(read/write) 1740364 1740364 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188464 188464 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217412 1217436 24 0.0
.debug_aranges 111552 111552 0 0.0
.debug_frame 372452 372452 0 0.0
.debug_info 26647573 26647572 -1 -0.0
.debug_line 3648191 3648191 0 0.0
.debug_loc 3563899 3563899 0 0.0
.debug_ranges 337208 337208 0 0.0
.debug_str 3394775 3394775 0 0.0
.heap 842224 842224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569431 569431 0 0.0
.symtab 420608 420608 0 0.0
.text 1540856 1540856 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842960 842960 0 0.0
(read/write) 1683556 1683556 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187728 187728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209251 1209275 24 0.0
.debug_aranges 111024 111024 0 0.0
.debug_frame 375532 375532 0 0.0
.debug_info 26384268 26384266 -2 -0.0
.debug_line 3668595 3668595 0 0.0
.debug_loc 3551536 3551536 0 0.0
.debug_ranges 335824 335824 0 0.0
.debug_str 3383764 3383764 0 0.0
.heap 842960 842960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533905 533905 0 0.0
.symtab 407200 407200 0 0.0
.text 1484784 1484784 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600828 1600828 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044070 1044094 24 0.0
.debug_aranges 103200 103200 0 0.0
.debug_frame 345800 345800 0 0.0
.debug_info 21847874 21847872 -2 -0.0
.debug_line 3239259 3239259 0 0.0
.debug_loc 3249910 3249910 0 0.0
.debug_ranges 301320 301320 0 0.0
.debug_str 3189008 3189008 0 0.0
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467204 467204 0 0.0
.symtab 374288 374288 0 0.0
.text 1410296 1410296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638540 1638540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051505 1051529 24 0.0
.debug_aranges 103872 103872 0 0.0
.debug_frame 348628 348628 0 0.0
.debug_info 22227605 22227603 -2 -0.0
.debug_line 3248153 3248153 0 0.0
.debug_loc 3289747 3289747 0 0.0
.debug_ranges 304664 304664 0 0.0
.debug_str 3216491 3216491 0 0.0
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473419 473419 0 0.0
.symtab 377472 377472 0 0.0
.text 1442976 1442976 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808444 808508 64 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571098 571128 30 0.0
lighting-app tlsr9518adk80d (read/write) 830328 830392 64 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589196 589224 28 0.0

@andy31415
Copy link
Contributor

Accepted for 1.0 as platform specific change

@chrisdecenzo chrisdecenzo merged commit e9984f8 into project-chip:master Sep 1, 2022
@sharadb-amazon sharadb-amazon deleted the ios-swift-20220825 branch September 1, 2022 20:11
@bzbarsky-apple bzbarsky-apple mentioned this pull request Sep 6, 2022
Closed
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@sharadb-amazon @bzbarsky-apple @isiu-apple
Address feedback from project-chip#22197 (project-chip#22175)
dc8ad94 
* Address feedback from project-chip#22197

* Allocating and deallocating partialDacVerifier before assignment

* Avoiding returning a BOOL from onNocChainGenerationComplete

* Allocating partialDacVerifier in initWithFactory and checking if allocation failed

* Handling potentially dangling *cppCommissioner, dispatching GetCommissioningParams call on chipWorkQueue

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharadb-amazon @andy31415 @chrisdecenzo @bzbarsky-apple