-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SetUpCodePairer] Only search on network if no credentials are provid… #22166
Merged
woody-apple
merged 1 commit into
sve-2
from
cherry-pick-cf4cf8a6df6430fca12d564b6fcc2adeaf4df59f
Aug 29, 2022
Merged
[SetUpCodePairer] Only search on network if no credentials are provid… #22166
woody-apple
merged 1 commit into
sve-2
from
cherry-pick-cf4cf8a6df6430fca12d564b6fcc2adeaf4df59f
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to chip-tool pairing code commands (#22104)
PR #22166: Size comparison from fb1c812 to f792480 Increases (7 builds for bl602, cc13x2_26x2, cyw30739, linux)
Decreases (1 build for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
@woody-apple Please note #22195 |
woody-apple
deleted the
cherry-pick-cf4cf8a6df6430fca12d564b6fcc2adeaf4df59f
branch
August 29, 2022 19:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed to chip-tool pairing code commands
Problem
In #21664
chip-tool
is used to add an other commissioner after having opened a commissioning window. In theory this operation should only happens on-network. But the fact that the qr code provided for the initial pairing is used get the setup code pairer to issue a BLE scan. That is not necessary and that is also an issue when testing in a lab with a lot of ble devices.fix #21664
Change overview
Testing