-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix efr32-brd4161a-lock-rpc build #22164
Merged
woody-apple
merged 1 commit into
project-chip:master
from
mspang:for-chip/fix-silabs-ifdefs
Aug 25, 2022
Merged
Fix efr32-brd4161a-lock-rpc build #22164
woody-apple
merged 1 commit into
project-chip:master
from
mspang:for-chip/fix-silabs-ifdefs
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the conditional compilation in the EFR32 sources to match their headers. This avoids the following compilation errors: 2022-08-25 13:26:54 INFO ../../examples/lock-app/efr32/third_party/connectedhomeip/examples/platform/efr32/display/lcd.cpp: In member function 'void SilabsLCD::WriteDemoUI(bool)': 2022-08-25 13:26:54 INFO ../../examples/lock-app/efr32/third_party/connectedhomeip/examples/platform/efr32/display/lcd.cpp:125:9: error: 'mShowQRCode' was not declared in this scope 2022-08-25 13:26:54 INFO 125 | if (mShowQRCode) 2022-08-25 13:26:54 INFO | ^~~~~~~~~~~ 2022-08-25 13:26:54 INFO At global scope: 2022-08-25 13:26:54 INFO cc1plus: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics 2022-08-25 13:27:57 INFO ../../examples/lock-app/efr32/third_party/connectedhomeip/examples/platform/efr32/BaseApplication.cpp: In static member function 'static void BaseApplication::ButtonHandler(AppEvent*)': 2022-08-25 13:27:57 INFO ../../examples/lock-app/efr32/third_party/connectedhomeip/examples/platform/efr32/BaseApplication.cpp:396:19: error: 'class SilabsLCD' has no member named 'ToggleQRCode' 2022-08-25 13:27:57 INFO 396 | slLCD.ToggleQRCode(); 2022-08-25 13:27:57 INFO | ^~~~~~~~~~~~ 2022-08-25 13:27:57 INFO At global scope:
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
August 25, 2022 17:31
pullapprove
bot
requested review from
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
August 25, 2022 17:31
selissia
approved these changes
Aug 25, 2022
woody-apple
approved these changes
Aug 25, 2022
PR #22164: Size comparison from b0e5559 to d460352 Increases (4 builds for cc13x2_26x2, cyw30739, efr32, telink)
Decreases (7 builds for cc13x2_26x2, cyw30739, nrfconnect, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Fix the conditional compilation in the EFR32 sources to match their headers. This avoids the following compilation errors: 2022-08-25 13:26:54 INFO ../../examples/lock-app/efr32/third_party/connectedhomeip/examples/platform/efr32/display/lcd.cpp: In member function 'void SilabsLCD::WriteDemoUI(bool)': 2022-08-25 13:26:54 INFO ../../examples/lock-app/efr32/third_party/connectedhomeip/examples/platform/efr32/display/lcd.cpp:125:9: error: 'mShowQRCode' was not declared in this scope 2022-08-25 13:26:54 INFO 125 | if (mShowQRCode) 2022-08-25 13:26:54 INFO | ^~~~~~~~~~~ 2022-08-25 13:26:54 INFO At global scope: 2022-08-25 13:26:54 INFO cc1plus: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics 2022-08-25 13:27:57 INFO ../../examples/lock-app/efr32/third_party/connectedhomeip/examples/platform/efr32/BaseApplication.cpp: In static member function 'static void BaseApplication::ButtonHandler(AppEvent*)': 2022-08-25 13:27:57 INFO ../../examples/lock-app/efr32/third_party/connectedhomeip/examples/platform/efr32/BaseApplication.cpp:396:19: error: 'class SilabsLCD' has no member named 'ToggleQRCode' 2022-08-25 13:27:57 INFO 396 | slLCD.ToggleQRCode(); 2022-08-25 13:27:57 INFO | ^~~~~~~~~~~~ 2022-08-25 13:27:57 INFO At global scope:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Building efr32-brd4161a-lock-rpc fails as of b94c8ed ("[EFR32] Upgrade LCD (#22016)")
Change overview
Fix the conditional compilation in the EFR32 sources to match
their headers.
Testing