-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ota-requestor] Reset to Idle on failed NotifyUpdateApplied #22131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset to Idle state on connection failure when trying to send NotifyUpdateApplied command. Signed-off-by: Damian Krolik <[email protected]>
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
August 24, 2022 15:02
pullapprove
bot
requested review from
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
August 24, 2022 15:02
PR #22131: Size comparison from 9a13892 to cf99a18 Increases (1 build for cyw30739)
Decreases (11 builds for bl602, efr32, linux, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
V1 review: @selissia to look at this for requirement for OTA |
This fix is needed for v1.0 |
selissia
approved these changes
Aug 24, 2022
andy31415
approved these changes
Aug 24, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…chip#22131) Reset to Idle state on connection failure when trying to send NotifyUpdateApplied command. Signed-off-by: Damian Krolik <[email protected]> Signed-off-by: Damian Krolik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When OTA requestor tries to send
NotifyUpdateApplied
command and fails to establish the connection with the OTA provider, it stays in Applying state instead of switching back to Idle. As a result, it no longer queries for a new software update.Change overview
Reset to Idle state on connection failure when trying to send
NotifyUpdateApplied
command.Fixes #22129.
Testing
Moved OTA requestor initialization before Thread stack initialization and tested that when the connection to the OTA provider fails, the requestor switches back to Idle and kicks off the periodic query timer.