-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't delay the release of Lwip UDPEndPoint if there is no pending Lw… #22122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
August 24, 2022 05:41
pullapprove
bot
requested review from
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt and
mspang
August 24, 2022 05:41
PR #22122: Size comparison from 82d974b to 28485d5 Increases (19 builds for bl602, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (11 builds for cc13x2_26x2, nrfconnect, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
andy31415
reviewed
Aug 24, 2022
andy31415
reviewed
Aug 24, 2022
PR #22122: Size comparison from 82d974b to 0ff68f4 Increases (4 builds for bl602, esp32)
Decreases (2 builds for linux)
Full report (24 builds for bl602, esp32, k32w, linux, mbed, nrfconnect, telink)
|
PR #22122: Size comparison from 591b386 to a5b0803 Increases (17 builds for bl602, cc13x2_26x2, efr32, esp32, psoc6)
Decreases (10 builds for cc13x2_26x2, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
woody-apple
approved these changes
Aug 25, 2022
kghost
reviewed
Aug 25, 2022
PR #22122: Size comparison from 07cc33a to e4038fc Increases (18 builds for bl602, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (10 builds for cc13x2_26x2, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
bzbarsky-apple
requested changes
Aug 27, 2022
…IPReceiveUDPMessage
Co-authored-by: Zang MingJie <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
PR #22122: Size comparison from 9bde9e3 to 5c09abb Increases (17 builds for bl602, cc13x2_26x2, efr32, esp32, psoc6)
Decreases (11 builds for cc13x2_26x2, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
PR #22122: Size comparison from d47c8f7 to 32e4789 Increases (18 builds for bl602, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (11 builds for cc13x2_26x2, esp32, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Accepting for 1.0: crash mitigation |
andy31415
approved these changes
Aug 30, 2022
bzbarsky-apple
approved these changes
Aug 30, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
project-chip#22122) * Don't delay the release of Lwip UDPEndPoint if there is no pending LwIPReceiveUDPMessage * Use std::atomic_int instead of bool * Update src/inet/UDPEndPointImplLwIP.cpp Co-authored-by: Zang MingJie <[email protected]> * Update src/inet/UDPEndPointImplLwIP.cpp Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Zang MingJie <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…IPReceiveUDPMessage
Problem
What is being fixed? Examples:
We observed we might run out of UDP endpoint on LWIP implementation on one of our internal product after we delay release the UDP endpoint to solve a racing issue. Fix OT UDP receive and UDP close racing #20536. We resolve this problem by increasing the number of allowed endpoint.
A similar fix is posted on Matter SDK. [EFR32] Update EXCHANGE_CONTEXT and NUM_UDP_ENDPOINT (TC_SC_3_6) #22089
Actuallly, we only need to delay the release of current endpoint if there is a UDPEndPointImplLwIP::LwIPReceiveUDPMessage event pending in the event queue.
Change overview
Don't delay the release of Lwip UDPEndPoint if there is no pending LwIPReceiveUDPMessage
Testing
How was this tested? (at least one bullet point required)