Expose Credentials::ConvertX509CertToChipCert to Obj-C.
#22113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #22113: Size comparison from fa24ab6 to 38aca9f Increases (2 builds for cc13x2_26x2, cyw30739)
Decreases (5 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
emargolis
approved these changes
Aug 23, 2022
mburshteyn1
force-pushed
the
darwin_x509_cert_to_chip_cert
branch
from
38aca9f to
855fb96
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt and
saurabhst
pullapprove
bot
requested review from
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #22113: Size comparison from 82d974b to cc99e18 Increases (6 builds for bl602, cc13x2_26x2, esp32, psoc6)
Decreases (4 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
mspang
approved these changes
Aug 25, 2022
woody-apple
approved these changes
Aug 25, 2022
| + (nullable NSData *)convertToCHIPCertFromX509Cert:(NSData *)x509Certificate | ||
| { | ||
|
|
||
| chip::ByteSpan x509CertBytes = chip::ByteSpan((uint8_t *) x509Certificate.bytes, x509Certificate.length); |
There was a problem hiding this comment.
Please use AsByteSpan().
|
|
||
| chip::ByteSpan x509CertBytes = chip::ByteSpan((uint8_t *) x509Certificate.bytes, x509Certificate.length); | ||
|
|
||
| NSMutableData * chipCertBuffer = [[NSMutableData alloc] initWithLength:chip::Credentials::kMaxCHIPCertLength]; |
There was a problem hiding this comment.
Please use a stack buffer.
| if (errorCode != CHIP_NO_ERROR) | ||
| return nil; | ||
|
|
||
| return [NSData dataWithBytes:chipCertBytes.data() length:chipCertBytes.size()]; |
| @@ -125,6 +125,9 @@ NS_ASSUME_NONNULL_BEGIN | |||
| + (nullable NSData *)generateCertificateSigningRequest:(id<MTRKeypair>)keypair | |||
| error:(NSError * __autoreleasing _Nullable * _Nullable)error; | |||
|
|
|||
| /** Converts the given X.509v3 certificate to the CHIP certificate format. */ | |||
| + (nullable NSData *)convertToCHIPCertFromX509Cert:(NSData *)x509Certificate; | |||
There was a problem hiding this comment.
Needs to document when null is returned.
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ip#22113) * Expose `Credentials::ConvertX509CertToChipCert` to Obj-C. * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Credentials::ConvertX509CertToChipCertto Obj-C.Change overview
Added function
convertToCHIPCertFromX509CerttoMTRCertificatesto exposeCredentials::ConvertX509CertToChipCertto Obj-C.