-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[privacy] Add AES_CTR_encrypt/decrypt with tests. #22108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
mspang and
rgoliver
August 23, 2022 16:36
andy31415
approved these changes
Aug 23, 2022
turon
force-pushed
the
msg/privacy
branch
2 times, most recently
from
August 23, 2022 17:04
d32167b
to
cc70c1c
Compare
PR #22108: Size comparison from 1a1d887 to 8db563b Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
jmeg-sfy
reviewed
Aug 24, 2022
jmeg-sfy
reviewed
Aug 24, 2022
jmeg-sfy
approved these changes
Aug 24, 2022
emargolis
reviewed
Aug 24, 2022
emargolis
approved these changes
Aug 24, 2022
woody-apple
approved these changes
Aug 25, 2022
PR #22108: Size comparison from 1952eb7 to 04330b1 Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
Co-authored-by: Jonathan Mégevand <[email protected]>
Co-authored-by: Evgeny Margolis <[email protected]>
PR #22108: Size comparison from 35c4d69 to 486de90 Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* [privacy] Add AES_CTR_encrypt/decrypt with tests. * [style] Remove magic words. * Apply suggestions from code review Co-authored-by: Jonathan Mégevand <[email protected]> * Update src/crypto/CHIPCryptoPAL.h Co-authored-by: Evgeny Margolis <[email protected]> * Use stdbuf to try to disable stdout buffering on darwin Co-authored-by: Jonathan Mégevand <[email protected]> Co-authored-by: Evgeny Margolis <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ch03 of the spec calls out the need for AES-CTR mode for privacy encrypt/decrypt.
Change overview
Adds AES-CTR to CryptoPal generally for all platforms by utilizing existing AES_CCM but ignoring the tag.
Testing