-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC_RR_1_1: Updated Method that Was Used to Generate Large Sized Operational Certificates #22088
Merged
andy31415
merged 2 commits into
project-chip:master
from
emargolis:emargolis/feature/update-noc-maximize-logic
Aug 23, 2022
Merged
TC_RR_1_1: Updated Method that Was Used to Generate Large Sized Operational Certificates #22088
andy31415
merged 2 commits into
project-chip:master
from
emargolis:emargolis/feature/update-noc-maximize-logic
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional Certificates. Instead of padding the subject DN this method adds size by adding Future Extension. This new approach doesen't have certain limitations compare to the previous approach and allows generation of larger certificates of approximate sizes: {RCAC, ICAC, NOC} ~ {400, 400, 350} bytes in TLV encoded form.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton and
jepenven-silabs
August 22, 2022 21:50
pullapprove
bot
requested review from
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
August 22, 2022 21:50
pullapprove
bot
requested review from
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
August 22, 2022 21:50
pullapprove
bot
added
review - pending
controller
tools
and removed
tools
controller
labels
Aug 22, 2022
tcarmelveilleux
approved these changes
Aug 22, 2022
PR #22088: Size comparison from 6681060 to c2da761 Increases (2 builds for linux, nrfconnect)
Decreases (2 builds for nrfconnect, telink)
Full report (9 builds for bl602, linux, mbed, nrfconnect, telink)
|
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
PR #22088: Size comparison from 6681060 to a5ffc11 Increases above 0.2%:
Increases (16 builds for cc13x2_26x2, efr32, linux, nrfconnect, psoc6)
Decreases (10 builds for cc13x2_26x2, cyw30739, efr32, esp32, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…tional Certificates (project-chip#22088) * TC_RR_1_1: Updated Method that Was Used to Generate Large Sized Operational Certificates. Instead of padding the subject DN this method adds size by adding Future Extension. This new approach doesen't have certain limitations compare to the previous approach and allows generation of larger certificates of approximate sizes: {RCAC, ICAC, NOC} ~ {400, 400, 350} bytes in TLV encoded form. * Update src/credentials/tests/TestChipCert.cpp Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In continuation of #22032. Need a way to generate maximum sized operational certificates.
Change overview
Instead of padding the subject DN this method adds size by adding Future Extension.
This new approach doesn't have certain limitations compare to the previous approach and
allows generation of larger certificates of approximate sizes:
{RCAC, ICAC, NOC} ~ {400, 400, 350} bytes in TLV encoded form.
Testing
Added new tests