RPC: Add RPC target for esp32 lighting app #22070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple and
jelderton
pullapprove
bot
requested review from
woody-apple,
selissia,
xylophone21,
tecimovic,
yufengwangca,
yunhanw-google,
tehampson,
turon,
vijs,
vivien-apple and
wbschiller
|
PR #22070: Size comparison from 9713e10 to b501fd5 Increases (6 builds for cc13x2_26x2, psoc6, telink)
Decreases (3 builds for bl602, cc13x2_26x2)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
Add an RPC target for the DevC Esp32 Lighting app.
rgoliver
force-pushed
the
esp-light-rpc
branch
from
b501fd5 to
7a6a5c9
Compare
|
PR #22070: Size comparison from 48f87f3 to 7a6a5c9 Increases (5 builds for bl602, nrfconnect, psoc6)
Decreases (2 builds for cyw30739, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
|
1.0 justification seems to be: this enhances ability to test things. is this correct @rgoliver ? Could we add this justification to the summary (with any additional reasoning/wording as needed)? |
Done |
|
@rgoliver - needs conflict resolution |
andy31415
approved these changes
Aug 25, 2022
woody-apple
approved these changes
Aug 25, 2022
|
PR #22070: Size comparison from b2358dd to 142ba76 Increases (6 builds for bl602, cc13x2_26x2, psoc6, telink)
Decreases (8 builds for bl602, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Add an RPC target for the DevC Esp32 Lighting app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an RPC target for the DevC Esp32 Lighting app.
Problem
ESP32 lighting app doesn't currently have an RPC target which is used for automated testing.
Change overview
Add an RPC target for the DevC board (Also works on m5).
Testing
Built and flashed the rpc build, tested using chip-console.
1.0 Justification
this enhances ability to test things. - Testers wish to include this sample app in automated testing, which requires an RPC variant. This change is low-risk, as it just adds this other target, and doesn't touch anything else.