-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Read product label and product url from the factory partition if available #22056
Merged
andy31415
merged 2 commits into
project-chip:master
from
shubhamdp:esp32_product_lbl_url
Aug 25, 2022
Merged
[ESP32] Read product label and product url from the factory partition if available #22056
andy31415
merged 2 commits into
project-chip:master
from
shubhamdp:esp32_product_lbl_url
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
August 20, 2022 08:55
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
August 20, 2022 08:55
PR #22056: Size comparison from 74ea252 to 6a354a2 Increases (5 builds for cc13x2_26x2, cyw30739, esp32, psoc6)
Decreases (7 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
chshu
approved these changes
Aug 22, 2022
dhrishi
approved these changes
Aug 22, 2022
andy31415
reviewed
Aug 22, 2022
andy31415
approved these changes
Aug 22, 2022
shubhamdp
force-pushed
the
esp32_product_lbl_url
branch
from
August 23, 2022 04:04
6a354a2
to
0e0ba0e
Compare
PR #22056: Size comparison from 48f87f3 to 0e0ba0e Increases (7 builds for esp32, nrfconnect, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
shubhamdp
force-pushed
the
esp32_product_lbl_url
branch
from
August 23, 2022 13:50
0e0ba0e
to
3bcf73d
Compare
PR #22056: Size comparison from cfdb308 to 3bcf73d Increases (4 builds for esp32, psoc6)
Decreases (3 builds for bl602, psoc6, telink)
Full report (38 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
shubhamdp
force-pushed
the
esp32_product_lbl_url
branch
from
August 24, 2022 02:39
3bcf73d
to
bc39961
Compare
PR #22056: Size comparison from 82d974b to bc39961 Increases (3 builds for esp32, psoc6)
Decreases (2 builds for psoc6)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
… if available (project-chip#22056) * [ESP32] Read product label and product url from the factory partition if available * Return error CHIIP_DEVICE_ERROR_CONFIG_NOT_FOUND if not found in persistent storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Overridden the API in configuration manager to read the product label and product url from the factory partition.
Testing
Flashed the factory partition containing product label and product url, commissioned the device and read the respective basic cluster attributes.