-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] Setting the network interface type to WIFI for wifi devices #22041
Merged
tcarmelveilleux
merged 4 commits into
project-chip:master
from
rosahay-silabs:bugfix/network_interface_type
Aug 23, 2022
Merged
[EFR32] Setting the network interface type to WIFI for wifi devices #22041
tcarmelveilleux
merged 4 commits into
project-chip:master
from
rosahay-silabs:bugfix/network_interface_type
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mlepage-google
August 19, 2022 15:49
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
August 19, 2022 15:49
PR #22041: Size comparison from 67d6821 to a5afda7 Increases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, k32w, psoc6)
Full report (36 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
jmartinez-silabs
approved these changes
Aug 19, 2022
PR #22041: Size comparison from 67d6821 to e928d21 Increases (9 builds for bl602, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739, nrfconnect, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
SVE request : fix issue on efr32 wifi platofrm for a DGGEN test case |
tcarmelveilleux
approved these changes
Aug 23, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 23, 2022
…22041) * EFR32 wifi setting the network interface type to WIFI * Changes as per the suggestions * Changing the if condition * Correcting the code by adding ; for the build to be succeed
andy31415
added a commit
that referenced
this pull request
Aug 24, 2022
…22041) (#22091) * EFR32 wifi setting the network interface type to WIFI * Changes as per the suggestions * Changing the if condition * Correcting the code by adding ; for the build to be succeed Co-authored-by: chirag-silabs <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…roject-chip#22041) * EFR32 wifi setting the network interface type to WIFI * Changes as per the suggestions * Changing the if condition * Correcting the code by adding ; for the build to be succeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The network interface type was returning 0 for the WIFI examples.
Change overview
GetInterfaceType() returns CHIP_ERROR_NOT_IMPLEMENTED for LWIP causing the D for Ltype to return Unspecified.
Setting the Interfacetype to WIFI.
Testing
Tested manually using MG12+RS9116 and MG12+WF200
Note: To be cherry picked in SVE2 Branch