Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing assign -> copy in Darwin #22017

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Fixing assign -> copy in Darwin #22017

merged 1 commit into from
Aug 18, 2022

Conversation

woody-apple
Copy link
Contributor

@woody-apple woody-apple commented Aug 18, 2022 •
edited
Loading

Problem

A parameter has a poor type, should be copy
Resolves: #22017

Change overview

Swap assign -> copy

Testing

Builds without warnings

@woody-apple woody-apple enabled auto-merge (squash) August 18, 2022 19:42
@woody-apple woody-apple linked an issue Aug 18, 2022 that may be closed by this pull request
Consider retaining rendezvousInformation from MTRSetupPayload #21984
Closed
@woody-apple woody-apple changed the title Fixing assign -> copy in Darwin Resolves:#21984 Fixing assign -> copy in Darwin Aug 18, 2022
@github-actions
Copy link

github-actions bot commented Aug 18, 2022 •
edited
Loading

PR #22017: Size comparison from d502f30 to ef87e7f

Increases (3 builds for cc13x2_26x2, psoc6)
platform target config section d502f30 ef87e7f change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 684743 684751 8 0.0
.text 594300 594308 8 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26374275 26374276 1 0.0
light cy8ckit_062s2_43012 .debug_info 21839792 21839793 1 0.0
Decreases (6 builds for cc13x2_26x2, k32w, nrfconnect, telink)
platform target config section d502f30 ef87e7f change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 637747 637739 -8 -0.0
.text 559444 559436 -8 -0.0
pump-app LP_CC2652R7 (read/write) 157760 157752 -8 -0.0
k32w light k32w0+release (read/write) 646676 646660 -16 -0.0
.text 571480 571464 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814448 814444 -4 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808736 -8 -0.0
text 571318 571314 -4 -0.0
lighting-app tlsr9518adk80d text 589408 589406 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section d502f30 ef87e7f change % change
bl602 lighting-app bl602 (read/write) 1383858 1383858 0 0.0
.bss 120258 120258 0 0.0
.data 4480 4480 0 0.0
.text 1051044 1051044 0 0.0
bl602+rpc (read/write) 1429370 1429370 0 0.0
.bss 127698 127698 0 0.0
.data 4600 4600 0 0.0
.text 1082800 1082800 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672795 672795 0 0.0
(read/write) 178700 178700 0 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88819 88819 0 0.0
.text 583660 583660 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637747 637739 -8 -0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559444 559436 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 674079 674079 0 0.0
(read/write) 167616 167616 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596928 596928 0 0.0
lock-mtd LP_CC2652R7 (read only) 656831 656831 0 0.0
(read/write) 180552 180552 0 0.0
.bss 67164 67164 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554592 554592 0 0.0
pump-app LP_CC2652R7 (read only) 684743 684751 8 0.0
(read/write) 157760 157752 -8 -0.0
.bss 71516 71516 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594300 594308 8 0.0
pump-controller-app LP_CC2652R7 (read only) 669243 669243 0 0.0
(read/write) 173380 173380 0 0.0
.bss 71636 71636 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583248 583248 0 0.0
shell LP_CC2652R7 (read only) 665478 665478 0 0.0
(read/write) 181536 181536 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85766 85766 0 0.0
.text 579396 579396 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586618 586618 0 0.0
.app_xip_area 463284 463284 0 0.0
.bss 65768 65768 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592418 592418 0 0.0
.app_xip_area 464300 464300 0 0.0
.bss 70552 70552 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599538 599538 0 0.0
.app_xip_area 476924 476924 0 0.0
.bss 65080 65080 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1100980 1100980 0 0.0
.bss 133372 133372 0 0.0
.data 2068 2068 0 0.0
.text 965516 965516 0 0.0
BRD4161A+rpc (read/write) 1155232 1155232 0 0.0
.bss 150060 150060 0 0.0
.data 2280 2280 0 0.0
.text 1002872 1002872 0 0.0
BRD4161A+rs911x (read/write) 990152 990152 0 0.0
.bss 162696 162696 0 0.0
.data 2056 2056 0 0.0
.text 825380 825380 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139636 1139636 0 0.0
.bss 145872 145872 0 0.0
.data 2064 2064 0 0.0
.text 991680 991680 0 0.0
window-app BRD4161A (read/write) 1092420 1092420 0 0.0
.bss 134812 134812 0 0.0
.data 2096 2096 0 0.0
.text 955492 955492 0 0.0
esp32 all-clusters-app c3devkit (read only) 1030788 1030788 0 0.0
(read/write) 1489570 1489570 0 0.0
.dram0.bss 71136 71136 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218400 218400 0 0.0
.flash.text 1030788 1030788 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1083967 1083967 0 0.0
(read/write) 491496 491496 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248716 248716 0 0.0
.flash.text 1078583 1078583 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646676 646660 -16 -0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571480 571464 -16 -0.0
lock k32w0+release (read/write) 704196 704196 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628528 628528 0 0.0
linux all-clusters-app debug (read only) 3037129 3037129 0 0.0
(read/write) 156024 156024 0 0.0
.bss 61920 61920 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274667 274667 0 0.0
.text 2583314 2583314 0 0.0
all-clusters-minimal-app debug (read only) 2874353 2874353 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274859 274859 0 0.0
.text 2423122 2423122 0 0.0
bridge-app debug+rpc (read only) 2373001 2373001 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203496 203496 0 0.0
.text 2006882 2006882 0 0.0
chip-tool debug (read only) 10864033 10864033 0 0.0
(read/write) 651136 651136 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 616104 616104 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 562485 562485 0 0.0
.text 8795348 8795348 0 0.0
chip-tool-ipv6only arm64 (read only) 10252124 10252124 0 0.0
(read/write) 698929 698929 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643616 643616 0 0.0
.dynamic 560 560 0 0.0
.got 13776 13776 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493180 493180 0 0.0
.text 8121364 8121364 0 0.0
lighting-app debug+rpc (read only) 2597033 2597033 0 0.0
(read/write) 130176 130176 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72360 72360 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220304 220304 0 0.0
.text 2206018 2206018 0 0.0
lock-app debug (read only) 2580929 2580929 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237360 237360 0 0.0
.text 2176914 2176914 0 0.0
ota-provider-app debug (read only) 2358105 2358105 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209336 209336 0 0.0
.text 1985298 1985298 0 0.0
ota-requestor-app debug (read only) 2523369 2523369 0 0.0
(read/write) 127320 127320 0 0.0
.bss 50336 50336 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68728 68728 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216160 216160 0 0.0
.text 2134642 2134642 0 0.0
shell debug (read only) 2605433 2605433 0 0.0
(read/write) 142144 142144 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234770 234770 0 0.0
.text 2212242 2212242 0 0.0
thermostat-no-ble arm64 (read only) 2357300 2357300 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140620 140620 0 0.0
.text 1978960 1978960 0 0.0
tv-app debug (read only) 3173993 3173993 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 258952 258952 0 0.0
.text 2725298 2725298 0 0.0
tv-casting-app debug (read only) 5462161 5462161 0 0.0
(read/write) 160240 160240 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 99928 99928 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 343569 343569 0 0.0
.text 4847506 4847506 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180367 1180367 0 0.0
bss 143737 143737 0 0.0
rodata 143344 143344 0 0.0
text 814448 814444 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159799 1159799 0 0.0
bss 142964 142964 0 0.0
rodata 134944 134944 0 0.0
text 803072 803072 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 881000 0 0.0
(read/write) 1700748 1700748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 149688 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217432 1217432 0 0.0
.debug_aranges 111496 111496 0 0.0
.debug_frame 372228 372228 0 0.0
.debug_info 26636674 26636674 0 0.0
.debug_line 3645881 3645881 0 0.0
.debug_loc 3561084 3561084 0 0.0
.debug_ranges 336520 336520 0 0.0
.debug_str 3392640 3392640 0 0.0
.heap 881000 881000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 568892 568892 0 0.0
.symtab 420304 420304 0 0.0
.text 0 0 0 0.0
1540016 1540016 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 881736 0 0.0
(read/write) 1644204 1644204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 148952 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209298 1209298 0 0.0
.debug_aranges 110984 110984 0 0.0
.debug_frame 375360 375360 0 0.0
.debug_info 26374275 26374276 1 0.0
.debug_line 3666460 3666460 0 0.0
.debug_loc 3549266 3549266 0 0.0
.debug_ranges 335176 335176 0 0.0
.debug_str 3382119 3382119 0 0.0
.heap 881736 881736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533820 533820 0 0.0
.symtab 407008 407008 0 0.0
.text 1484208 1484208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 890080 0 0.0
(read/write) 1561436 1561436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 140816 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1043971 1043971 0 0.0
.debug_aranges 103152 103152 0 0.0
.debug_frame 345604 345604 0 0.0
.debug_info 21839792 21839793 1 0.0
.debug_line 3237638 3237638 0 0.0
.debug_loc 3248769 3248769 0 0.0
.debug_ranges 301016 301016 0 0.0
.debug_str 3188213 3188213 0 0.0
.heap 890080 890080 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467101 467101 0 0.0
.symtab 374064 374064 0 0.0
.text 1409784 1409784 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 885584 0 0.0
(read/write) 1598708 1598708 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 145296 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051147 1051147 0 0.0
.debug_aranges 103824 103824 0 0.0
.debug_frame 348428 348428 0 0.0
.debug_info 22194929 22194929 0 0.0
.debug_line 3246323 3246323 0 0.0
.debug_loc 3288888 3288888 0 0.0
.debug_ranges 304432 304432 0 0.0
.debug_str 3215644 3215644 0 0.0
.heap 885584 885584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473342 473342 0 0.0
.symtab 377248 377248 0 0.0
.text 1442560 1442560 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808736 -8 -0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571318 571314 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 830680 830680 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589408 589406 -2 -0.0

@woody-apple woody-apple merged commit a8679f0 into project-chip:master Aug 18, 2022
github-actions bot pushed a commit that referenced this pull request Aug 18, 2022
@woody-apple @web-flow
Fixing assign -> copy (#22017)
24fb2a0
@woody-apple woody-apple mentioned this pull request Aug 18, 2022
Merged
woody-apple added a commit that referenced this pull request Aug 18, 2022
@woody-apple
Fixing assign -> copy (#22017) (#22021)
922ec1f
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@woody-apple @isiu-apple
Fixing assign -> copy (project-chip#22017)
c3ba0bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
darwin fast track sve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider retaining rendezvousInformation from MTRSetupPayload
1 participant
@woody-apple