Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register the DNS service for the accessory with a valid hostname #22010

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Register the DNS service for the accessory with a valid hostname #22010

merged 1 commit into from
Sep 12, 2022

Conversation

nivi-apple
Copy link
Contributor

  • Call DNSServiceRegisterRecord to register a record for the hostname for all interfaces
    before calling DNSServiceRegister.

Problem

What is being fixed? Examples:

Change overview

Register a DNS service with a valid hostname

Testing

How was this tested? (at least one bullet point required)
*Tested using mac all-clusters-app and chip-tool

@nivi-apple nivi-apple force-pushed the darwin_dns_sd_issue branch 2 times, most recently from 4b23c29 to 726c61d Compare August 24, 2022 22:11
@github-actions
Copy link

github-actions bot commented Aug 24, 2022 •
edited
Loading

PR #22010: Size comparison from b4776ad to 726c61d

Increases (6 builds for bl602, cc13x2_26x2, psoc6)
platform target config section b4776ad 726c61d change % change
bl602 lighting-app bl602+rpc (read/write) 1429298 1429306 8 0.0
.text 1082572 1082576 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178660 178668 8 0.0
pump-app LP_CC2652R7 (read/write) 157960 157968 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 2664473 26644737 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26381430 26381432 2 0.0
light cy8ckit_062s2_43012 .debug_info 21845988 2184598 1 0.0
Decreases (7 builds for bl602, cc13x2_26x2, cyw30739, nrfconnect, telink)
platform target config section b4776ad 726c61d change % change
bl602 lighting-app bl602 (read/write) 1383650 1383642 -8 -0.0
.text 1050816 1050812 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672827 -8 -0.0
.text 583684 583676 -8 -0.0
pump-app LP_CC2652R7 (read only) 684551 684543 -8 -0.0
.text 594140 594132 -8 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599442 -8 -0.0
.app_xip_area 476828 476820 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814560 814556 -4 -0.0
telink light-switch-app tlsr9518adk80d text 571028 571024 -4 -0.0
lighting-app tlsr9518adk80d text 589152 589150 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section b4776ad 726c61d change % change
bl602 lighting-app bl602 (read/write) 1383650 1383642 -8 -0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050816 1050812 -4 -0.0
bl602+rpc (read/write) 1429298 1429306 8 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082572 1082576 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672835 672827 -8 -0.0
(read/write) 178660 178668 8 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583684 583676 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637555 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559252 559252 0 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673919 0 0.0
(read/write) 167784 167784 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596768 0 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656687 0 0.0
(read/write) 180704 180704 0 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554440 0 0.0
pump-app LP_CC2652R7 (read only) 684551 684543 -8 -0.0
(read/write) 157960 157968 8 0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594140 594132 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669059 0 0.0
(read/write) 173572 173572 0 0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583096 583096 0 0.0
shell LP_CC2652R7 (read only) 665526 665526 0 0.0
(read/write) 181488 181488 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579428 579428 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586586 0 0.0
.app_xip_area 463244 463244 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592346 0 0.0
.app_xip_area 464220 464220 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599450 599442 -8 -0.0
.app_xip_area 476828 476820 -8 -0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1107316 1107316 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 968892 968892 0 0.0
BRD4161A+rpc (read/write) 971396 971396 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 818276 818276 0 0.0
BRD4161A+rs911x (read/write) 999928 999928 0 0.0
.bss 169088 169088 0 0.0
.data 2056 2056 0 0.0
.text 828764 828764 0 0.0
lock-app BRD4161A+wf200 (read/write) 1149196 1149196 0 0.0
.bss 152168 152168 0 0.0
.data 2064 2064 0 0.0
.text 994944 994944 0 0.0
window-app BRD4161A (read/write) 1098580 1098580 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 958692 958692 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031040 1031040 0 0.0
(read/write) 1489610 1489610 0 0.0
.dram0.bss 71144 71144 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218424 218424 0 0.0
.flash.text 1031040 1031040 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084175 1084175 0 0.0
(read/write) 491528 491528 0 0.0
.dram0.bss 76648 76648 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248740 248740 0 0.0
.flash.text 1078791 1078791 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646516 646516 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571320 0 0.0
lock k32w0+release (read/write) 704012 704012 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628344 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10259508 10259508 0 0.0
(read/write) 699169 699169 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643848 643848 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493364 493364 0 0.0
.text 8127988 8127988 0 0.0
thermostat-no-ble arm64 (read only) 2356644 2356644 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978336 1978336 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454312 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1416956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180591 1180591 0 0.0
bss 143745 143745 0 0.0
rodata 143328 143328 0 0.0
text 814560 814556 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159675 1159675 0 0.0
bss 142972 142972 0 0.0
rodata 134916 134916 0 0.0
text 802968 802968 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 881000 0 0.0
(read/write) 1700692 1700692 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 149688 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217526 1217526 0 0.0
.debug_aranges 111544 111544 0 0.0
.debug_frame 372400 372400 0 0.0
.debug_info 2664473 26644737 1 0.0
.debug_line 3646957 3646957 0 0.0
.debug_loc 3561998 3561998 0 0.0
.debug_ranges 336696 336696 0 0.0
.debug_str 3393533 3393533 0 0.0
.heap 881000 881000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569137 569137 0 0.0
.symtab 420320 420320 0 0.0
.text 1539960 1539960 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 881736 0 0.0
(read/write) 1643884 1643884 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 148952 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209365 1209365 0 0.0
.debug_aranges 111016 111016 0 0.0
.debug_frame 375480 375480 0 0.0
.debug_info 26381430 26381432 2 0.0
.debug_line 3667361 3667361 0 0.0
.debug_loc 3549635 3549635 0 0.0
.debug_ranges 335312 335312 0 0.0
.debug_str 3382522 3382522 0 0.0
.heap 881736 881736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533611 533611 0 0.0
.symtab 406912 406912 0 0.0
.text 1483888 1483888 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 890080 0 0.0
(read/write) 1561132 1561132 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 140816 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044038 1044038 0 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 345724 345724 0 0.0
.debug_info 21845988 2184598 1 0.0
.debug_line 3238540 3238540 0 0.0
.debug_loc 3249150 3249150 0 0.0
.debug_ranges 301152 301152 0 0.0
.debug_str 3188616 3188616 0 0.0
.heap 890080 890080 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 466892 466892 0 0.0
.symtab 373968 373968 0 0.0
.text 1409480 1409480 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 885584 0 0.0
(read/write) 1598372 1598372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 145296 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051210 1051210 0 0.0
.debug_aranges 103856 103856 0 0.0
.debug_frame 348548 348548 0 0.0
.debug_info 22199262 22199262 0 0.0
.debug_line 3247103 3247103 0 0.0
.debug_loc 3289002 3289002 0 0.0
.debug_ranges 304496 304496 0 0.0
.debug_str 3216047 3216047 0 0.0
.heap 885584 885584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473107 473107 0 0.0
.symtab 377152 377152 0 0.0
.text 1442224 1442224 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808416 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571028 571024 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 830392 830392 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589152 589150 -2 -0.0

vivien-apple
vivien-apple previously requested changes Aug 25, 2022
View reviewed changes
src/platform/Darwin/DnssdContexts.cpp Show resolved Hide resolved
src/platform/Darwin/DnssdContexts.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdContexts.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Aug 27, 2022
View reviewed changes
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
@nivi-apple nivi-apple force-pushed the darwin_dns_sd_issue branch 3 times, most recently from fead8b7 to 6c85214 Compare September 7, 2022 21:11
@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited
Loading

PR #22010: Size comparison from b4505ac to 6c85214

Increases (4 builds for esp32, psoc6)
platform target config section b4505ac 6c85214 change % change
esp32 all-clusters-app c3devkit (read only) 1033928 1033932 4 0.0
.flash.text 1033928 1033932 4 0.0
m5stack (read/write) 490852 490860 8 0.0
.flash.rodata 247392 247400 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26716599 26716600 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26453222 26453224 2 0.0
Decreases (4 builds for efr32, psoc6, telink)
platform target config section b4505ac 6c85214 change % change
efr32 lighting-app BRD4161A+rpc (read/write) 972316 972300 -16 -0.0
.text 819200 819184 -16 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22295179 22295178 -1 -0.0
telink light-switch-app tlsr9518adk80d text 573714 573712 -2 -0.0
lighting-app tlsr9518adk80d text 591842 591840 -2 -0.0
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b4505ac 6c85214 change % change
bl602 lighting-app bl602 (read/write) 1410290 1410290 0 0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1065690 1065690 0 0.0
bl602+rpc (read/write) 1455486 1455486 0 0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1097038 1097038 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675431 675431 0 0.0
(read/write) 175976 175976 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89223 89223 0 0.0
.text 585896 585896 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640151 640151 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78375 78375 0 0.0
.text 561456 561456 0 0.0
lock-ftd LP_CC2652R7 (read only) 676483 676483 0 0.0
(read/write) 165236 165236 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77075 77075 0 0.0
.text 598928 598928 0 0.0
lock-mtd LP_CC2652R7 (read only) 659483 659483 0 0.0
(read/write) 177924 177924 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102355 102355 0 0.0
.text 556648 556648 0 0.0
pump-app LP_CC2652R7 (read only) 685343 685343 0 0.0
(read/write) 157080 157080 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90103 90103 0 0.0
.text 594756 594756 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669835 669835 0 0.0
(read/write) 172700 172700 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85659 85659 0 0.0
.text 583696 583696 0 0.0
shell LP_CC2652R7 (read only) 666090 666090 0 0.0
(read/write) 180836 180836 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85778 85778 0 0.0
.text 579996 579996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587002 587002 0 0.0
.app_xip_area 463660 463660 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592738 592738 0 0.0
.app_xip_area 464612 464612 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599914 599914 0 0.0
.app_xip_area 477292 477292 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108624 1108624 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970200 970200 0 0.0
BRD4161A+rpc (read/write) 972316 972300 -16 -0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819200 819184 -16 -0.0
BRD4161A+rs911x (read/write) 1002056 1002056 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830804 830804 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150180 1150180 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995840 995840 0 0.0
window-app BRD4161A (read/write) 1099856 1099856 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959968 959968 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033928 1033932 4 0.0
(read/write) 1493566 1493566 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218080 218080 0 0.0
.flash.text 1033928 1033932 4 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086511 1086511 0 0.0
(read/write) 490852 490860 8 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247392 247400 8 0.0
.flash.text 1081127 1081127 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648268 648268 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572760 572760 0 0.0
lock k32w0+release (read/write) 705312 705312 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629348 629348 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10329660 10329660 0 0.0
(read/write) 705601 705601 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 649976 649976 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 499948 499948 0 0.0
.text 8176692 8176692 0 0.0
thermostat-no-ble arm64 (read only) 2364244 2364244 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141356 141356 0 0.0
.text 1984848 1984848 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455136 2455136 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417780 1417780 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181327 1181327 0 0.0
bss 143641 143641 0 0.0
rodata 143584 143584 0 0.0
text 815164 815164 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160523 1160523 0 0.0
bss 142868 142868 0 0.0
rodata 135172 135172 0 0.0
text 803556 803556 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742572 1742572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221517 1221517 0 0.0
.debug_aranges 111736 111736 0 0.0
.debug_frame 373008 373008 0 0.0
.debug_info 26716599 26716600 1 0.0
.debug_line 3657478 3657478 0 0.0
.debug_loc 3573505 3573505 0 0.0
.debug_ranges 338360 338360 0 0.0
.debug_str 3427479 3427479 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570615 570615 0 0.0
.symtab 421488 421488 0 0.0
.text 1542800 1542800 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685772 1685772 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213356 1213356 0 0.0
.debug_aranges 111208 111208 0 0.0
.debug_frame 376088 376088 0 0.0
.debug_info 26453222 26453224 2 0.0
.debug_line 3677994 3677994 0 0.0
.debug_loc 3561142 3561142 0 0.0
.debug_ranges 336976 336976 0 0.0
.debug_str 3416484 3416484 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535089 535089 0 0.0
.symtab 408080 408080 0 0.0
.text 1486736 1486736 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603028 1603028 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048175 1048175 0 0.0
.debug_aranges 103384 103384 0 0.0
.debug_frame 346356 346356 0 0.0
.debug_info 21915393 21915393 0 0.0
.debug_line 3248459 3248459 0 0.0
.debug_loc 3259468 3259468 0 0.0
.debug_ranges 302448 302448 0 0.0
.debug_str 3221750 3221750 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468388 468388 0 0.0
.symtab 375168 375168 0 0.0
.text 1412224 1412224 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640716 1640716 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055610 1055610 0 0.0
.debug_aranges 104056 104056 0 0.0
.debug_frame 349184 349184 0 0.0
.debug_info 22295179 22295178 -1 -0.0
.debug_line 3257280 3257280 0 0.0
.debug_loc 3299322 3299322 0 0.0
.debug_ranges 305792 305792 0 0.0
.debug_str 3249171 3249171 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474591 474591 0 0.0
.symtab 378352 378352 0 0.0
.text 1444880 1444880 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129284 1129284 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576380 576380 0 0.0
lock-app qpg6105+debug (read/write) 1100264 1100264 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547364 547364 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812168 812168 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 573714 573712 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 834072 834072 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 591842 591840 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 842316 842316 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598104 598104 0 0.0

@nivi-apple
Copy link
Contributor Author

Code looks great. Thanks Vivien.

@vivien-apple vivien-apple dismissed their stale review September 8, 2022 17:10

I have updated the code a little bit to address some of the comments I made

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited
Loading

PR #22010: Size comparison from 0e3bbae to ff0ec51

Increases (3 builds for esp32, nrfconnect, telink)
platform target config section 0e3bbae ff0ec51 change % change
esp32 all-clusters-app m5stack (read/write) 490852 490860 8 0.0
.flash.rodata 247392 247400 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160507 1160523 16 0.0
text 803552 803556 4 0.0
telink lighting-app tlsr9518adk80d text 591838 591840 2 0.0
Decreases (6 builds for bl602, psoc6, qpg, telink)
platform target config section 0e3bbae ff0ec51 change % change
bl602 lighting-app bl602+rpc .text 1097038 1097036 -2 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26719024 26719023 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 21917818 21917817 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1129284 1129276 -8 -0.0
.text 576380 576372 -8 -0.0
lock-app qpg6105+debug (read/write) 1100264 1100256 -8 -0.0
.text 547364 547356 -8 -0.0
telink ota-requestor-app tlsr9518adk80d (read/write) 842324 842316 -8 -0.0
text 598106 598102 -4 -0.0
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0e3bbae ff0ec51 change % change
bl602 lighting-app bl602 (read/write) 1410290 1410290 0 0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1065690 1065690 0 0.0
bl602+rpc (read/write) 1455486 1455486 0 0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1097038 1097036 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675431 675431 0 0.0
(read/write) 175976 175976 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89223 89223 0 0.0
.text 585896 585896 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640151 640151 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78375 78375 0 0.0
.text 561456 561456 0 0.0
lock-ftd LP_CC2652R7 (read only) 676483 676483 0 0.0
(read/write) 165236 165236 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77075 77075 0 0.0
.text 598928 598928 0 0.0
lock-mtd LP_CC2652R7 (read only) 659483 659483 0 0.0
(read/write) 177924 177924 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102355 102355 0 0.0
.text 556648 556648 0 0.0
pump-app LP_CC2652R7 (read only) 685343 685343 0 0.0
(read/write) 157080 157080 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90103 90103 0 0.0
.text 594756 594756 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669835 669835 0 0.0
(read/write) 172700 172700 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85659 85659 0 0.0
.text 583696 583696 0 0.0
shell LP_CC2652R7 (read only) 666090 666090 0 0.0
(read/write) 180836 180836 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85778 85778 0 0.0
.text 579996 579996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587002 587002 0 0.0
.app_xip_area 463660 463660 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592738 592738 0 0.0
.app_xip_area 464612 464612 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599914 599914 0 0.0
.app_xip_area 477292 477292 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108624 1108624 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970200 970200 0 0.0
BRD4161A+rpc (read/write) 972316 972316 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819200 819200 0 0.0
BRD4161A+rs911x (read/write) 1002056 1002056 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830804 830804 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150180 1150180 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995840 995840 0 0.0
window-app BRD4161A (read/write) 1099856 1099856 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959968 959968 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033930 1033930 0 0.0
(read/write) 1493566 1493566 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218080 218080 0 0.0
.flash.text 1033930 1033930 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086511 1086511 0 0.0
(read/write) 490852 490860 8 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247392 247400 8 0.0
.flash.text 1081127 1081127 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648268 648268 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572760 572760 0 0.0
lock k32w0+release (read/write) 705312 705312 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629348 629348 0 0.0
linux all-clusters-app debug (read only) 3046569 3046569 0 0.0
(read/write) 156064 156064 0 0.0
.bss 61824 61824 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275691 275691 0 0.0
.text 2591442 2591442 0 0.0
all-clusters-minimal-app debug (read only) 2882433 2882433 0 0.0
(read/write) 147664 147664 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275915 275915 0 0.0
.text 2429858 2429858 0 0.0
bridge-app debug+rpc (read only) 2380169 2380169 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204552 204552 0 0.0
.text 2012706 2012706 0 0.0
chip-tool debug (read only) 10958017 10958017 0 0.0
(read/write) 657736 657736 0 0.0
.bss 26072 26072 0 0.0
.data 2690 2690 0 0.0
.data.rel.ro 622456 622456 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 570325 570325 0 0.0
.text 8866468 8866468 0 0.0
chip-tool-ipv6only arm64 (read only) 10330188 10330188 0 0.0
(read/write) 705601 705601 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 649976 649976 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 499948 499948 0 0.0
.text 8177220 8177220 0 0.0
lighting-app debug+rpc (read only) 2605593 2605593 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221392 221392 0 0.0
.text 2213010 2213010 0 0.0
lock-app debug (read only) 2588577 2588577 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238384 238384 0 0.0
.text 2183250 2183250 0 0.0
ota-provider-app debug (read only) 2365833 2365833 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 210360 210360 0 0.0
.text 1991714 1991714 0 0.0
ota-requestor-app debug (read only) 2531161 2531161 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 217184 217184 0 0.0
.text 2141074 2141074 0 0.0
shell debug (read only) 2614905 2614905 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235826 235826 0 0.0
.text 2220370 2220370 0 0.0
thermostat-no-ble arm64 (read only) 2364244 2364244 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141356 141356 0 0.0
.text 1984848 1984848 0 0.0
tv-app debug (read only) 3198785 3198785 0 0.0
(read/write) 258392 258392 0 0.0
.bss 168152 168152 0 0.0
.data 4144 4144 0 0.0
.data.rel.ro 79520 79520 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 260616 260616 0 0.0
.text 2747778 2747778 0 0.0
tv-casting-app debug (read only) 5516377 5516377 0 0.0
(read/write) 160888 160888 0 0.0
.bss 52120 52120 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 100488 100488 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 346001 346001 0 0.0
.text 4898066 4898066 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455136 2455136 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417780 1417780 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181327 1181327 0 0.0
bss 143641 143641 0 0.0
rodata 143584 143584 0 0.0
text 815164 815164 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160507 1160523 16 0.0
bss 142868 142868 0 0.0
rodata 135172 135172 0 0.0
text 803552 803556 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742572 1742572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221650 1221650 0 0.0
.debug_aranges 111744 111744 0 0.0
.debug_frame 373048 373048 0 0.0
.debug_info 26719024 26719023 -1 -0.0
.debug_line 3658002 3658002 0 0.0
.debug_loc 3573942 3573942 0 0.0
.debug_ranges 338400 338400 0 0.0
.debug_str 3427580 3427580 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570615 570615 0 0.0
.symtab 421488 421488 0 0.0
.text 1542800 1542800 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685772 1685772 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213489 1213489 0 0.0
.debug_aranges 111216 111216 0 0.0
.debug_frame 376128 376128 0 0.0
.debug_info 26455647 26455647 0 0.0
.debug_line 3678518 3678518 0 0.0
.debug_loc 3561579 3561579 0 0.0
.debug_ranges 337016 337016 0 0.0
.debug_str 3416585 3416585 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535089 535089 0 0.0
.symtab 408080 408080 0 0.0
.text 1486736 1486736 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603028 1603028 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048308 1048308 0 0.0
.debug_aranges 103392 103392 0 0.0
.debug_frame 346396 346396 0 0.0
.debug_info 21917818 21917817 -1 -0.0
.debug_line 3248983 3248983 0 0.0
.debug_loc 3259921 3259921 0 0.0
.debug_ranges 302488 302488 0 0.0
.debug_str 3221851 3221851 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468388 468388 0 0.0
.symtab 375168 375168 0 0.0
.text 1412224 1412224 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640716 1640716 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055743 1055743 0 0.0
.debug_aranges 104064 104064 0 0.0
.debug_frame 349224 349224 0 0.0
.debug_info 22297601 22297601 0 0.0
.debug_line 3257804 3257804 0 0.0
.debug_loc 3299773 3299773 0 0.0
.debug_ranges 305832 305832 0 0.0
.debug_str 3249272 3249272 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474591 474591 0 0.0
.symtab 378352 378352 0 0.0
.text 1444880 1444880 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129284 1129276 -8 -0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576380 576372 -8 -0.0
lock-app qpg6105+debug (read/write) 1100264 1100256 -8 -0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547364 547356 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 812168 812168 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 573712 573712 0 0.0
lighting-app tlsr9518adk80d (read/write) 834072 834072 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 591838 591840 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 842324 842316 -8 -0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598106 598102 -4 -0.0

bzbarsky-apple
bzbarsky-apple reviewed Sep 8, 2022
View reviewed changes
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdInterfaceInfos.h Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdInterfaceInfos.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdInterfaceInfos.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdInterfaceInfos.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdInterfaceInfos.h Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdInterfaceInfos.h Outdated Show resolved Hide resolved
src/platform/Darwin/MdnsError.cpp Show resolved Hide resolved
src/platform/Darwin/DnssdInterfaceInfos.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/DnssdInterfaceInfos.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 9, 2022 •
edited
Loading

PR #22010: Size comparison from 27f9fb4 to 3a84639

Increases (1 build for telink)
platform target config section 27f9fb4 3a84639 change % change
telink light-switch-app tlsr9518adk80d text 574346 574348 2 0.0
Decreases (2 builds for bl602, nrfconnect)
platform target config section 27f9fb4 3a84639 change % change
bl602 lighting-app bl602 (read/write) 1411830 1411822 -8 -0.0
.text 1067066 1067064 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161227 1161211 -16 -0.0
text 804100 804096 -4 -0.0
Full report (14 builds for bl602, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 27f9fb4 3a84639 change % change
bl602 lighting-app bl602 (read/write) 1411830 1411822 -8 -0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1067066 1067064 -2 -0.0
bl602+rpc (read/write) 1457282 1457282 0 0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1098670 1098670 0 0.0
k32w light k32w0+release (read/write) 648860 648860 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 573352 573352 0 0.0
lock k32w0+release (read/write) 706048 706048 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630084 630084 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10332012 10332012 0 0.0
(read/write) 705649 705649 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 650024 650024 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 500092 500092 0 0.0
.text 8178852 8178852 0 0.0
thermostat-no-ble arm64 (read only) 2366068 2366068 0 0.0
(read/write) 141905 141905 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76160 76160 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141516 141516 0 0.0
.text 1986464 1986464 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455224 2455224 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417868 1417868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182027 1182027 0 0.0
bss 143641 143641 0 0.0
rodata 143740 143740 0 0.0
text 815708 815708 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161227 1161211 -16 -0.0
bss 142868 142868 0 0.0
rodata 135332 135332 0 0.0
text 804100 804096 -4 -0.0
qpg lighting-app qpg6105+debug (read/write) 1130012 1130012 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577108 577108 0 0.0
lock-app qpg6105+debug (read/write) 1101008 1101008 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548108 548108 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812960 812960 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574346 574348 2 0.0
lighting-app tlsr9518adk80d (read/write) 834872 834872 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592478 592478 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843116 843116 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598740 598740 0 0.0

@vivien-apple vivien-apple force-pushed the darwin_dns_sd_issue branch 2 times, most recently from 3dfb177 to e784ea7 Compare September 9, 2022 11:15
@github-actions
Copy link

github-actions bot commented Sep 9, 2022 •
edited
Loading

PR #22010: Size comparison from 27f9fb4 to e784ea7

Increases (3 builds for bl602, cc13x2_26x2, telink)
platform target config section 27f9fb4 e784ea7 change % change
bl602 lighting-app bl602+rpc .text 1098670 1098672 2 0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 670555 670563 8 0.0
.text 584256 584264 8 0.0
telink light-switch-app tlsr9518adk80d text 574346 574348 2 0.0
Decreases (4 builds for cc13x2_26x2, esp32, telink)
platform target config section 27f9fb4 e784ea7 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 171980 171972 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1223522 1223518 -4 -0.0
.flash.text 1223522 1223518 -4 -0.0
m5stack (read/write) 563604 563596 -8 -0.0
.flash.rodata 314328 314320 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 834872 834864 -8 -0.0
text 592478 592476 -2 -0.0
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 27f9fb4 e784ea7 change % change
bl602 lighting-app bl602 (read/write) 1411830 1411830 0 0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1067066 1067066 0 0.0
bl602+rpc (read/write) 1457282 1457282 0 0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1098670 1098672 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676159 676159 0 0.0
(read/write) 175248 175248 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89383 89383 0 0.0
.text 586464 586464 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640879 640879 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78535 78535 0 0.0
.text 562024 562024 0 0.0
lock-ftd LP_CC2652R7 (read only) 677235 677235 0 0.0
(read/write) 164484 164484 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77235 77235 0 0.0
.text 599520 599520 0 0.0
lock-mtd LP_CC2652R7 (read only) 660219 660219 0 0.0
(read/write) 177188 177188 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102515 102515 0 0.0
.text 557224 557224 0 0.0
pump-app LP_CC2652R7 (read only) 686071 686071 0 0.0
(read/write) 156352 156352 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90263 90263 0 0.0
.text 595324 595324 0 0.0
pump-controller-app LP_CC2652R7 (read only) 670555 670563 8 0.0
(read/write) 171980 171972 -8 -0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85819 85819 0 0.0
.text 584256 584264 8 0.0
shell LP_CC2652R7 (read only) 666986 666986 0 0.0
(read/write) 179940 179940 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85994 85994 0 0.0
.text 580676 580676 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587394 587394 0 0.0
.app_xip_area 464052 464052 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 593146 593146 0 0.0
.app_xip_area 465020 465020 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600618 600618 0 0.0
.app_xip_area 477996 477996 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1109992 1109992 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 971568 971568 0 0.0
BRD4161A+rpc (read/write) 973052 973052 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819936 819936 0 0.0
BRD4161A+rs911x (read/write) 1003432 1003432 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832180 832180 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150916 1150916 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 996576 996576 0 0.0
window-app BRD4161A (read/write) 1101224 1101224 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 961336 961336 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223522 1223518 -4 -0.0
(read/write) 1787654 1787654 0 0.0
.dram0.bss 76952 76952 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257208 257208 0 0.0
.flash.text 1223522 1223518 -4 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233347 1233347 0 0.0
(read/write) 563604 563596 -8 -0.0
.dram0.bss 82312 82312 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314328 314320 -8 -0.0
.flash.text 1227963 1227963 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648860 648860 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 573352 573352 0 0.0
lock k32w0+release (read/write) 706048 706048 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630084 630084 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10332012 10332012 0 0.0
(read/write) 705649 705649 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 650024 650024 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 500092 500092 0 0.0
.text 8178852 8178852 0 0.0
thermostat-no-ble arm64 (read only) 2366068 2366068 0 0.0
(read/write) 141905 141905 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76160 76160 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141516 141516 0 0.0
.text 1986464 1986464 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455224 2455224 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417868 1417868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182027 1182027 0 0.0
bss 143641 143641 0 0.0
rodata 143740 143740 0 0.0
text 815708 815708 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161227 1161227 0 0.0
bss 142868 142868 0 0.0
rodata 135332 135332 0 0.0
text 804100 804100 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1744108 1744108 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221909 1221909 0 0.0
.debug_aranges 111776 111776 0 0.0
.debug_frame 373172 373172 0 0.0
.debug_info 26739035 26739035 0 0.0
.debug_line 3662824 3662824 0 0.0
.debug_loc 3581159 3581159 0 0.0
.debug_ranges 340544 340544 0 0.0
.debug_str 3428604 3428604 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571087 571087 0 0.0
.symtab 421776 421776 0 0.0
.text 1544336 1544336 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1687316 1687316 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213748 1213748 0 0.0
.debug_aranges 111248 111248 0 0.0
.debug_frame 376252 376252 0 0.0
.debug_info 26475658 26475658 0 0.0
.debug_line 3683364 3683364 0 0.0
.debug_loc 3568796 3568796 0 0.0
.debug_ranges 339160 339160 0 0.0
.debug_str 3417609 3417609 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535561 535561 0 0.0
.symtab 408368 408368 0 0.0
.text 1488280 1488280 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1604548 1604548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048567 1048567 0 0.0
.debug_aranges 103424 103424 0 0.0
.debug_frame 346520 346520 0 0.0
.debug_info 21937828 21937828 0 0.0
.debug_line 3253793 3253793 0 0.0
.debug_loc 3267090 3267090 0 0.0
.debug_ranges 304632 304632 0 0.0
.debug_str 3222875 3222875 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468860 468860 0 0.0
.symtab 375456 375456 0 0.0
.text 1413744 1413744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642236 1642236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1056002 1056002 0 0.0
.debug_aranges 104096 104096 0 0.0
.debug_frame 349348 349348 0 0.0
.debug_info 22317613 22317613 0 0.0
.debug_line 3262602 3262602 0 0.0
.debug_loc 3306957 3306957 0 0.0
.debug_ranges 307976 307976 0 0.0
.debug_str 3250296 3250296 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475063 475063 0 0.0
.symtab 378640 378640 0 0.0
.text 1446400 1446400 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130012 1130012 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577108 577108 0 0.0
lock-app qpg6105+debug (read/write) 1101008 1101008 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548108 548108 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812960 812960 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574346 574348 2 0.0
lighting-app tlsr9518adk80d (read/write) 834872 834864 -8 -0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592478 592476 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 843116 843116 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598740 598740 0 0.0

@github-actions
Copy link

github-actions bot commented Sep 12, 2022 •
edited
Loading

PR #22010: Size comparison from 8af13a2 to 47e6055

Increases (4 builds for esp32, nrfconnect, psoc6)
platform target config section 8af13a2 47e6055 change % change
esp32 all-clusters-app c3devkit (read only) 1223518 1223520 2 0.0
.flash.text 1223518 1223520 2 0.0
m5stack (read/write) 563596 563604 8 0.0
.flash.rodata 314320 314328 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815704 815708 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 21937782 21937784 2 0.0
Decreases (5 builds for bl602, nrfconnect, psoc6, telink)
platform target config section 8af13a2 47e6055 change % change
bl602 lighting-app bl602+rpc .text 1098672 1098670 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161227 1161211 -16 -0.0
text 804100 804096 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26738990 26738989 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22317568 22317567 -1 -0.0
telink ota-requestor-app tlsr9518adk80d text 598742 598740 -2 -0.0
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 8af13a2 47e6055 change % change
bl602 lighting-app bl602 (read/write) 1411830 1411830 0 0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1067066 1067066 0 0.0
bl602+rpc (read/write) 1457282 1457282 0 0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1098672 1098670 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676159 676159 0 0.0
(read/write) 175248 175248 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89383 89383 0 0.0
.text 586464 586464 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640879 640879 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78535 78535 0 0.0
.text 562024 562024 0 0.0
lock-ftd LP_CC2652R7 (read only) 677235 677235 0 0.0
(read/write) 164484 164484 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77235 77235 0 0.0
.text 599520 599520 0 0.0
lock-mtd LP_CC2652R7 (read only) 660219 660219 0 0.0
(read/write) 177188 177188 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102515 102515 0 0.0
.text 557224 557224 0 0.0
pump-app LP_CC2652R7 (read only) 686071 686071 0 0.0
(read/write) 156352 156352 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90263 90263 0 0.0
.text 595324 595324 0 0.0
pump-controller-app LP_CC2652R7 (read only) 670563 670563 0 0.0
(read/write) 171972 171972 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85819 85819 0 0.0
.text 584264 584264 0 0.0
shell LP_CC2652R7 (read only) 666986 666986 0 0.0
(read/write) 179940 179940 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85994 85994 0 0.0
.text 580676 580676 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587394 587394 0 0.0
.app_xip_area 464052 464052 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 593146 593146 0 0.0
.app_xip_area 465020 465020 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600618 600618 0 0.0
.app_xip_area 477996 477996 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1109992 1109992 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 971568 971568 0 0.0
BRD4161A+rpc (read/write) 973052 973052 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819936 819936 0 0.0
BRD4161A+rs911x (read/write) 1003432 1003432 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832180 832180 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150916 1150916 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 996576 996576 0 0.0
window-app BRD4161A (read/write) 1101224 1101224 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 961336 961336 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223518 1223520 2 0.0
(read/write) 1787654 1787654 0 0.0
.dram0.bss 76952 76952 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257208 257208 0 0.0
.flash.text 1223518 1223520 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233347 1233347 0 0.0
(read/write) 563596 563604 8 0.0
.dram0.bss 82312 82312 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314320 314328 8 0.0
.flash.text 1227963 1227963 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648860 648860 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 573352 573352 0 0.0
lock k32w0+release (read/write) 706048 706048 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630084 630084 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10332988 10332988 0 0.0
(read/write) 705649 705649 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 650024 650024 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 501404 501404 0 0.0
.text 8178516 8178516 0 0.0
thermostat-no-ble arm64 (read only) 2365844 2365844 0 0.0
(read/write) 141905 141905 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76160 76160 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141452 141452 0 0.0
.text 1986304 1986304 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455224 2455224 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417868 1417868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182027 1182027 0 0.0
bss 143641 143641 0 0.0
rodata 143740 143740 0 0.0
text 815704 815708 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161227 1161211 -16 -0.0
bss 142868 142868 0 0.0
rodata 135332 135332 0 0.0
text 804100 804096 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1744108 1744108 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221909 1221909 0 0.0
.debug_aranges 111776 111776 0 0.0
.debug_frame 373172 373172 0 0.0
.debug_info 26738990 26738989 -1 -0.0
.debug_line 3662776 3662776 0 0.0
.debug_loc 3581084 3581084 0 0.0
.debug_ranges 340544 340544 0 0.0
.debug_str 3428604 3428604 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571087 571087 0 0.0
.symtab 421776 421776 0 0.0
.text 1544336 1544336 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1687316 1687316 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213748 1213748 0 0.0
.debug_aranges 111248 111248 0 0.0
.debug_frame 376252 376252 0 0.0
.debug_info 26475614 26475614 0 0.0
.debug_line 3683316 3683316 0 0.0
.debug_loc 3568721 3568721 0 0.0
.debug_ranges 339160 339160 0 0.0
.debug_str 3417609 3417609 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535561 535561 0 0.0
.symtab 408368 408368 0 0.0
.text 1488280 1488280 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1604548 1604548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048567 1048567 0 0.0
.debug_aranges 103424 103424 0 0.0
.debug_frame 346520 346520 0 0.0
.debug_info 21937782 21937784 2 0.0
.debug_line 3253745 3253745 0 0.0
.debug_loc 3267015 3267015 0 0.0
.debug_ranges 304632 304632 0 0.0
.debug_str 3222875 3222875 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468860 468860 0 0.0
.symtab 375456 375456 0 0.0
.text 1413744 1413744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642236 1642236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1056002 1056002 0 0.0
.debug_aranges 104096 104096 0 0.0
.debug_frame 349348 349348 0 0.0
.debug_info 22317568 22317567 -1 -0.0
.debug_line 3262554 3262554 0 0.0
.debug_loc 3306883 3306883 0 0.0
.debug_ranges 307976 307976 0 0.0
.debug_str 3250296 3250296 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475063 475063 0 0.0
.symtab 378640 378640 0 0.0
.text 1446400 1446400 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130012 1130012 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577108 577108 0 0.0
lock-app qpg6105+debug (read/write) 1101008 1101008 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548108 548108 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812960 812960 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574348 574348 0 0.0
lighting-app tlsr9518adk80d (read/write) 834864 834864 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592476 592476 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843116 843116 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598742 598740 -2 -0.0

@nivi-apple @vivien-apple
Register the DNS service for the accessory with a valid hostname
8d80336 
- Call DNSServiceRegisterRecord to register a record for the hostname for all interfaces
  before calling DNSServiceRegister.
@github-actions
Copy link

github-actions bot commented Sep 12, 2022 •
edited
Loading

PR #22010: Size comparison from d7dc898 to 8d80336

Increases (7 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
platform target config section d7dc898 8d80336 change % change
bl602 lighting-app bl602 (read/write) 1411822 1411830 8 0.0
.text 1067064 1067068 4 0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 179940 179948 8 0.0
esp32 all-clusters-app c3devkit (read only) 1223520 1223522 2 0.0
(read/write) 1787654 1787662 8 0.0
.flash.rodata 257208 257216 8 0.0
.flash.text 1223520 1223522 2 0.0
m5stack (read/write) 563596 563604 8 0.0
.flash.rodata 314320 314328 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26738989 26738990 1 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812960 812968 8 0.0
text 574348 574350 2 0.0
ota-requestor-app tlsr9518adk80d text 598740 598742 2 0.0
Decreases (2 builds for cc13x2_26x2, psoc6)
platform target config section d7dc898 8d80336 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 666986 666978 -8 -0.0
.text 580676 580668 -8 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 21937783 21937782 -1 -0.0
Full report (35 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section d7dc898 8d80336 change % change
bl602 lighting-app bl602 (read/write) 1411822 1411830 8 0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1067064 1067068 4 0.0
bl602+rpc (read/write) 1457282 1457282 0 0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1098670 1098670 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676159 676159 0 0.0
(read/write) 175248 175248 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89383 89383 0 0.0
.text 586464 586464 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640879 640879 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78535 78535 0 0.0
.text 562024 562024 0 0.0
lock-ftd LP_CC2652R7 (read only) 677235 677235 0 0.0
(read/write) 164484 164484 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77235 77235 0 0.0
.text 599520 599520 0 0.0
lock-mtd LP_CC2652R7 (read only) 660219 660219 0 0.0
(read/write) 177188 177188 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102515 102515 0 0.0
.text 557224 557224 0 0.0
pump-app LP_CC2652R7 (read only) 686071 686071 0 0.0
(read/write) 156352 156352 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90263 90263 0 0.0
.text 595324 595324 0 0.0
pump-controller-app LP_CC2652R7 (read only) 670563 670563 0 0.0
(read/write) 171972 171972 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85819 85819 0 0.0
.text 584264 584264 0 0.0
shell LP_CC2652R7 (read only) 666986 666978 -8 -0.0
(read/write) 179940 179948 8 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85994 85994 0 0.0
.text 580676 580668 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587394 587394 0 0.0
.app_xip_area 464052 464052 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 593146 593146 0 0.0
.app_xip_area 465020 465020 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 600618 600618 0 0.0
.app_xip_area 477996 477996 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1109992 1109992 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 971568 971568 0 0.0
BRD4161A+rpc (read/write) 973052 973052 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819936 819936 0 0.0
BRD4161A+rs911x (read/write) 1003432 1003432 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832180 832180 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150916 1150916 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 996576 996576 0 0.0
window-app BRD4161A (read/write) 1101224 1101224 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 961336 961336 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223520 1223522 2 0.0
(read/write) 1787654 1787662 8 0.0
.dram0.bss 76952 76952 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257208 257216 8 0.0
.flash.text 1223520 1223522 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233347 1233347 0 0.0
(read/write) 563596 563604 8 0.0
.dram0.bss 82312 82312 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314320 314328 8 0.0
.flash.text 1227963 1227963 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648860 648860 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 573352 573352 0 0.0
lock k32w0+release (read/write) 706048 706048 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630084 630084 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10332988 10332988 0 0.0
(read/write) 705649 705649 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 650024 650024 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 501404 501404 0 0.0
.text 8178516 8178516 0 0.0
thermostat-no-ble arm64 (read only) 2365844 2365844 0 0.0
(read/write) 141905 141905 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76160 76160 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141452 141452 0 0.0
.text 1986304 1986304 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455224 2455224 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417868 1417868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182027 1182027 0 0.0
bss 143641 143641 0 0.0
rodata 143740 143740 0 0.0
text 815708 815708 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161227 1161227 0 0.0
bss 142868 142868 0 0.0
rodata 135332 135332 0 0.0
text 804100 804100 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1744108 1744108 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221909 1221909 0 0.0
.debug_aranges 111776 111776 0 0.0
.debug_frame 373172 373172 0 0.0
.debug_info 26738989 26738990 1 0.0
.debug_line 3662776 3662776 0 0.0
.debug_loc 3581084 3581084 0 0.0
.debug_ranges 340544 340544 0 0.0
.debug_str 3428604 3428604 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571087 571087 0 0.0
.symtab 421776 421776 0 0.0
.text 1544336 1544336 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1687316 1687316 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213748 1213748 0 0.0
.debug_aranges 111248 111248 0 0.0
.debug_frame 376252 376252 0 0.0
.debug_info 26475612 26475612 0 0.0
.debug_line 3683316 3683316 0 0.0
.debug_loc 3568721 3568721 0 0.0
.debug_ranges 339160 339160 0 0.0
.debug_str 3417609 3417609 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535561 535561 0 0.0
.symtab 408368 408368 0 0.0
.text 1488280 1488280 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1604548 1604548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048567 1048567 0 0.0
.debug_aranges 103424 103424 0 0.0
.debug_frame 346520 346520 0 0.0
.debug_info 21937783 21937782 -1 -0.0
.debug_line 3253745 3253745 0 0.0
.debug_loc 3267015 3267015 0 0.0
.debug_ranges 304632 304632 0 0.0
.debug_str 3222875 3222875 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468860 468860 0 0.0
.symtab 375456 375456 0 0.0
.text 1413744 1413744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642236 1642236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1056002 1056002 0 0.0
.debug_aranges 104096 104096 0 0.0
.debug_frame 349348 349348 0 0.0
.debug_info 22317568 22317568 0 0.0
.debug_line 3262554 3262554 0 0.0
.debug_loc 3306883 3306883 0 0.0
.debug_ranges 307976 307976 0 0.0
.debug_str 3250296 3250296 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475063 475063 0 0.0
.symtab 378640 378640 0 0.0
.text 1446400 1446400 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130012 1130012 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 577108 577108 0 0.0
lock-app qpg6105+debug (read/write) 1101008 1101008 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548108 548108 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812960 812968 8 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574348 574350 2 0.0
lighting-app tlsr9518adk80d (read/write) 834872 834872 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592478 592478 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843116 843116 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598740 598742 2 0.0

@woody-apple woody-apple merged commit 70b8bb1 into project-chip:master Sep 12, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@nivi-apple @isiu-apple
Register the DNS service for the accessory with a valid hostname (pro…
a77ee16 
…ject-chip#22010)

- Call DNSServiceRegisterRecord to register a record for the hostname for all interfaces
  before calling DNSServiceRegister.
@nivi-apple nivi-apple deleted the darwin_dns_sd_issue branch March 5, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@vivien-apple vivien-apple vivien-apple left review comments

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
darwin fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Darwin dns-sd advertising needs to use the right hostname
4 participants
@nivi-apple @woody-apple @bzbarsky-apple @vivien-apple