OTA: Add SetMetadataForProvider to requestor #22005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
saurabhst
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Aug 18, 2022
|
PR #22005: Size comparison from b1f2fc7 to aba56af Increases above 0.2%:
Increases (24 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (6 builds for cc13x2_26x2, k32w, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
|
PR #22005: Size comparison from b85c5ec to 003593e Increases above 0.2%:
Increases (24 builds for bl602, cc13x2_26x2, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
added 2 commits
August 22, 2022 15:45
Add a setter for the OTA MetadataForProvider, which is provided during the QueryImageRequest.
Add an RPC to set the TLV data in metadata for provider, which is used during the SendQueryImageRequest.
|
PR #22005: Size comparison from f68b948 to 8d94585 Increases above 0.2%:
Increases (24 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (6 builds for cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
tcarmelveilleux
approved these changes
Aug 22, 2022
selissia
approved these changes
Aug 22, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* OTA: Add SetMetadataForProvider to requestor Add a setter for the OTA MetadataForProvider, which is provided during the QueryImageRequest. * RPC: Add RPC to set ota metadata for provider Add an RPC to set the TLV data in metadata for provider, which is used during the SendQueryImageRequest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OTA requestor has no method for setting the metadataForProvider value.
Change overview
Add a setter on the OTA requester interface to set the metadataForProvider value.
Implement this method on for the DefaultOTARequestor as an optional bytespan property which can be set at runtime.
Provide an RPC to set the value at runtime.
Testing
Tested using the included RPC on m5, verified the metadata was correctly included to the provider during image query.