-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
These two fixes are needed to get Android chip-tool working again #21980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
August 17, 2022 19:36
pullapprove
bot
requested review from
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
August 17, 2022 22:08
Damian-Nordic
approved these changes
Aug 18, 2022
andy31415
reviewed
Aug 18, 2022
src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/ChipClient.kt
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Aug 18, 2022
src/controller/java/src/chip/devicecontroller/ChipDeviceController.java
Outdated
Show resolved
Hide resolved
PR #21980: Size comparison from b1f2fc7 to 5c12387 Increases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
…ired to set a vendor ID so it must be passed during construction. Also fix typo in onCommissioningStatusUpdate JNI method description.
PR #21980: Size comparison from 3acafb1 to f488b99 Increases (4 builds for bl602, cc13x2_26x2, esp32, nrfconnect)
Decreases (4 builds for psoc6, telink)
Full report (38 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
PR #21980: Size comparison from 1f83af0 to 96db248 Increases (3 builds for cyw30739, psoc6, telink)
Decreases (4 builds for psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
This was referenced Sep 15, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ired to set a vendor ID (project-chip#21980) so it must be passed during construction. Also fix typo in onCommissioningStatusUpdate JNI method description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android chip-tool has been broken for weeks. A lot of new people read the documentation and build this tool as a means of learning how the project works. We should keep this tool in working order.
This patch sets the controllerVendorId to 0xFFF4 which is one of the allowable Test Vendor IDs.
After making these two changes and following these instructions...
https://github.com/project-chip/connectedhomeip/blob/master/docs/guides/android_building.md
I verified that the resulting chip-tool is able to commission the Espressif samples.
Based on info from: Hiep Nguyen <[email protected]>