Update KVS to handle zero length elements #21977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
andy31415
reviewed
Aug 17, 2022
andy31415
reviewed
Aug 17, 2022
andy31415
approved these changes
Aug 17, 2022
This was necessary for updating the test example for persistent storage. I can remove those changes if that example is not needed anymore. |
|
PR #21977: Size comparison from fc45b77 to 07ddad4 Increases (8 builds for cc13x2_26x2, nrfconnect)
Decreases (8 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #21977: Size comparison from fc45b77 to 3a1dde0 Increases above 0.2%:
Increases (16 builds for cc13x2_26x2, esp32, linux, nrfconnect)
Decreases (10 builds for cc13x2_26x2, esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
ReneJosefsen
approved these changes
Aug 18, 2022
|
PR #21977: Size comparison from 1ea6bbe to 79ae854 Increases (7 builds for cc13x2_26x2, telink)
Decreases (8 builds for cc13x2_26x2, nrfconnect)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #21977: Size comparison from 67d6821 to df379ea Increases (13 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (9 builds for cc13x2_26x2, cyw30739, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
|
PR #21977: Size comparison from 6ca1f85 to c8ef977 Increases (7 builds for cc13x2_26x2, esp32)
Decreases (11 builds for cc13x2_26x2, cyw30739, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
|
PR #21977: Size comparison from b85c5ec to c5bddd4 Increases (10 builds for cc13x2_26x2, psoc6, telink)
Decreases (11 builds for bl602, cc13x2_26x2, nrfconnect, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
* allow for nullptr in KVS write * complete audit with chip_support_enable_storage_api_audit=true
|
PR #21977: Size comparison from f68b948 to c785fde Increases (9 builds for cc13x2_26x2, psoc6, telink)
Decreases (13 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
|
1.0 justification: platform-specific fix to pass tests (in this case storage audit) |
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Aug 24, 2022
* allow for nullptr in KVS write * complete audit with chip_support_enable_storage_api_audit=true
woody-apple
pushed a commit
that referenced
this pull request
Aug 24, 2022
* allow for nullptr in KVS write * complete audit with chip_support_enable_storage_api_audit=true Co-authored-by: Seth Rickard <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* allow for nullptr in KVS write * complete audit with chip_support_enable_storage_api_audit=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #21912
Fix the CC13X2_26X2 KVS implementation to allow for zero length values.
Change overview
If a key item exists without a value item, we now assume that the value is a zero length element. The read/write/delete functions have been updated to reflect this new assumption. The KVS interfaces have been updated to not reject values of zero length.
The persistent-storage example has been updated with a new test for binary values of zero length.
Testing
the persistent-storage application was run and produced passing results.