Bridge #21975
Merged
Bridge #21975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cluster definitions are automatically generated from the IDL and devices automatically route read/writes to the appropriate cluster. Writes can be intercepted on a per-cluster basis to talk to whatever bridged backend there is.
andy31415
reviewed
Aug 17, 2022
andy31415
reviewed
Aug 17, 2022
andy31415
reviewed
Aug 17, 2022
andy31415
reviewed
Aug 17, 2022
andy31415
reviewed
Aug 17, 2022
scripts/idl/tests/outputs/cluster_struct_attribute/cpp/BridgeClustersImpl.h
Outdated
Show resolved
Hide resolved
|
PR #21975: Size comparison from 1939019 to 035b8a5 Increases above 0.2%:
Increases (4 builds for cc13x2_26x2, linux, nrfconnect)
Decreases (4 builds for bl602, cc13x2_26x2, linux, telink)
Full report (40 builds for bl602, cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Updates userinput backend to run commands on matter thread
|
PR #21975: Size comparison from f68b948 to f35521b Increases above 0.2%:
Increases (1 build for linux)
Decreases (4 builds for cc13x2_26x2, cyw30739, linux, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
mrjerryjohns
suggested changes
Aug 24, 2022
|
PR #21975: Size comparison from 383c416 to e362714 Increases above 0.2%:
Increases (6 builds for cc13x2_26x2, linux, psoc6, telink)
Decreases (5 builds for bl602, cc13x2_26x2, esp32, linux, qpg)
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
As per our conversation, here're the four things we should fix to make this more re-usable and integratable into the broader SDK in the near future, since I think there are a number of concepts here worth leveraging going forward:
To do that, we might need to add a new file similar to
As well as containing the metadata information. This then makes it easy to track the attributes in a list, as well as dynamically create the metadata table from this very information.
|
|
PR #21975: Size comparison from d520402 to 68d79a1 Increases (9 builds for bl602, bl702, cc13x2_26x2, psoc6)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, psoc6, qpg, telink)
|
mrjerryjohns
approved these changes
Sep 29, 2022
pullapprove
bot
requested review from
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #21975: Size comparison from 2a1f9ef to b935207 Increases above 0.2%:
Increases (4 builds for bl702, k32w)
Decreases (3 builds for bl702, k32w)
Full report (9 builds for bl702, k32w, linux, mbed, nrfconnect)
|
|
PR #21975: Size comparison from 2a1f9ef to c98d9d4 Increases above 0.2%:
Increases (19 builds for bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, cc13x2_26x2, k32w, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster definitions are automatically generated from the IDL and
devices automatically route read/writes to the appropriate cluster.
Writes can be intercepted on a per-cluster basis to talk to whatever
bridged backend there is.
Bridge includes an interactive CLI to modify and inspect bridge state
b/225921621
Testing
Manual testing with chip-tool on linux.
Add device to bridge via CLI
new-device switch
finish-device
Then read the newly added switch device's attributes
Then change attribute via set and read new value