-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update light switch doc #21963
Merged
andy31415
merged 3 commits into
project-chip:master
from
doublemis1:update_light_switch_doc
Aug 25, 2022
Merged
Update light switch doc #21963
andy31415
merged 3 commits into
project-chip:master
from
doublemis1:update_light_switch_doc
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doublemis1
force-pushed
the
update_light_switch_doc
branch
from
August 17, 2022 10:20
be1e2c0
to
11b307f
Compare
Damian-Nordic
approved these changes
Aug 17, 2022
PR #21963: Size comparison from 6f3d168 to 11b307f Increases (1 build for bl602)
Decreases (4 builds for esp32, linux, nrfconnect)
Full report (40 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
August 17, 2022 18:44
pullapprove
bot
requested review from
kpschoedel,
lazarkov,
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
August 17, 2022 18:44
PR #21963: Size comparison from 6f3d168 to 03dc3a1 Increases above 0.2%:
Increases (11 builds for mbed, nrfconnect)
Decreases (1 build for nrfconnect)
Full report (11 builds for mbed, nrfconnect)
|
andy31415
approved these changes
Aug 25, 2022
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Sep 1, 2022
* Update multicast testing documentation with yaml test alignment * Regen zap (cherry picked from commit 3fcad7d) Signed-off-by: Marcin Kajor <[email protected]>
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Sep 1, 2022
This reverts commit e9e7555.
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Update multicast testing documentation with yaml test alignment * Regen zap * Fixing style Co-authored-by: Justin Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The TestGroupDemoConfig.yaml represents Matter non-complaint procedure.
The nrfconnect light switch multicast testing instruction defines ACL which is overwritten by TestGroupDemoConfig.yaml
Change overview
Update TestGroupDemoConfig.yaml to represent add group Matter complaint procedure.
Remove step in light switch multicast testing instruction to set ACL while setting up multicast communication.
Testing
DUT: nrfconnect light bulb
Commission DUT
and run TestGroupDemoConfig