-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Added some OTA events for the device #21953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov and
LuDuda
August 17, 2022 07:18
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
August 17, 2022 07:18
pullapprove
bot
added
esp32
examples
platform
and removed
examples
platform
esp32
labels
Aug 17, 2022
shubhamdp
force-pushed
the
esp32_ota_events
branch
from
August 17, 2022 07:22
f3ee513
to
685389a
Compare
PR #21953: Size comparison from 7ff2bda to 685389a Increases (2 builds for bl602, telink)
Decreases (1 build for telink)
Full report (14 builds for bl602, cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
shubhamdp
force-pushed
the
esp32_ota_events
branch
from
August 17, 2022 07:58
685389a
to
919b343
Compare
PR #21953: Size comparison from 7ff2bda to 919b343 Increases (1 build for esp32)
Decreases (2 builds for nrfconnect, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
dhrishi
reviewed
Aug 17, 2022
PR #21953: Size comparison from 7ff2bda to c76cc99 Increases (3 builds for bl602, esp32, telink)
Decreases (2 builds for nrfconnect, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Aug 17, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* [ESP32] Added some OTA events for the device * Addressed review comments * fix the cut pasted log prints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
UpdateState
attribute.Change overview
Testing
ota-requestor-app/esp32