Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync OTA provider device type with specs #21950

Merged

Conversation

woody-apple
Copy link
Contributor

Problem

What is being fixed? Examples:

  • OTA provider device type was not matching specs

Change overview

Sync OTA provider device type with specs

Testing

How was this tested? (at least one bullet point required)

  • Verified OTA provider device type syncs with specs

* Sync OTA provider device type with specs

* Addressed review comments
@github-actions
Copy link

github-actions bot commented Aug 17, 2022

PR #21950: Size comparison from 4a8a3a7 to 7540361

Increases (3 builds for cyw30739, efr32, esp32)
platform target config section 4a8a3a7 7540361 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599018 599026 8 0.0
.app_xip_area 476372 476380 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1139284 1139300 16 0.0
.text 991680 991696 16 0.0
esp32 all-clusters-app c3devkit (read only) 1029982 1029984 2 0.0
.flash.text 1029982 1029984 2 0.0
Decreases (1 build for bl602)
platform target config section 4a8a3a7 7540361 change % change
bl602 lighting-app bl602+rpc (read/write) 1429010 1429002 -8 -0.0
.text 1082792 1082788 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4a8a3a7 7540361 change % change
bl602 lighting-app bl602 (read/write) 1383498 1383498 0 0.0
.bss 119906 119906 0 0.0
.data 4480 4480 0 0.0
.text 1051032 1051032 0 0.0
bl602+rpc (read/write) 1429010 1429002 -8 -0.0
.bss 127346 127346 0 0.0
.data 4600 4600 0 0.0
.text 1082792 1082788 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672379 672379 0 0.0
(read/write) 179132 179132 0 0.0
.bss 74404 74404 0 0.0
.data 3372 3372 0 0.0
.rodata 88747 88747 0 0.0
.text 583316 583316 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637763 637763 0 0.0
(read/write) 157980 157980 0 0.0
.bss 73692 73692 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559460 559460 0 0.0
lock-ftd LP_CC2652R7 (read only) 674095 674095 0 0.0
(read/write) 167632 167632 0 0.0
.bss 71508 71508 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596944 596944 0 0.0
lock-mtd LP_CC2652R7 (read only) 656839 656839 0 0.0
(read/write) 180576 180576 0 0.0
.bss 67196 67196 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554600 554600 0 0.0
pump-app LP_CC2652R7 (read only) 684767 684767 0 0.0
(read/write) 157768 157768 0 0.0
.bss 71548 71548 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594324 594324 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669259 669259 0 0.0
(read/write) 173396 173396 0 0.0
.bss 71668 71668 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583264 583264 0 0.0
shell LP_CC2652R7 (read only) 665062 665062 0 0.0
(read/write) 181968 181968 0 0.0
.bss 76724 76724 0 0.0
.data 3376 3376 0 0.0
.rodata 85694 85694 0 0.0
.text 579052 579052 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586070 586070 0 0.0
.app_xip_area 462704 462704 0 0.0
.bss 65800 65800 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591886 591886 0 0.0
.app_xip_area 463736 463736 0 0.0
.bss 70584 70584 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599018 599026 8 0.0
.app_xip_area 476372 476380 8 0.0
.bss 65112 65112 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1100740 1100740 0 0.0
.bss 133020 133020 0 0.0
.data 2068 2068 0 0.0
.text 965628 965628 0 0.0
BRD4161A+rpc (read/write) 1154992 1154992 0 0.0
.bss 149708 149708 0 0.0
.data 2280 2280 0 0.0
.text 1002984 1002984 0 0.0
BRD4161A+rs911x (read/write) 989864 989864 0 0.0
.bss 162344 162344 0 0.0
.data 2056 2056 0 0.0
.text 825444 825444 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139284 1139300 16 0.0
.bss 145520 145520 0 0.0
.data 2064 2064 0 0.0
.text 991680 991696 16 0.0
window-app BRD4161A (read/write) 1092196 1092196 0 0.0
.bss 134460 134460 0 0.0
.data 2096 2096 0 0.0
.text 955620 955620 0 0.0
esp32 all-clusters-app c3devkit (read only) 1029982 1029984 2 0.0
(read/write) 1488674 1488674 0 0.0
.dram0.bss 70864 70864 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217776 217776 0 0.0
.flash.text 1029982 1029984 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1083335 1083335 0 0.0
(read/write) 490632 490632 0 0.0
.dram0.bss 76376 76376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248116 248116 0 0.0
.flash.text 1077951 1077951 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 645092 645092 0 0.0
.bss 69848 69848 0 0.0
.data 2044 2044 0 0.0
.text 570472 570472 0 0.0
lock k32w0+release (read/write) 702644 702644 0 0.0
.bss 70320 70320 0 0.0
.data 2052 2052 0 0.0
.text 627544 627544 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10172732 10172732 0 0.0
(read/write) 698657 698657 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643408 643408 0 0.0
.dynamic 560 560 0 0.0
.got 13720 13720 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 489884 489884 0 0.0
.text 8045892 8045892 0 0.0
thermostat-no-ble arm64 (read only) 2356964 2356964 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140524 140524 0 0.0
.text 1978720 1978720 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 214692 214692 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179683 1179683 0 0.0
bss 143375 143375 0 0.0
rodata 143268 143268 0 0.0
text 814084 814084 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159543 1159543 0 0.0
bss 142612 142612 0 0.0
rodata 134944 134944 0 0.0
text 803072 803072 0 0.0
p6 all-clusters-app default (read only) 881368 881368 0 0.0
(read/write) 1698964 1698964 0 0.0
.bss 149320 149320 0 0.0
.data 2656 2656 0 0.0
.text 1538600 1538600 0 0.0
all-clusters-minimal-app default (read only) 882088 882088 0 0.0
(read/write) 1642972 1642972 0 0.0
.bss 148600 148600 0 0.0
.data 2656 2656 0 0.0
.text 1483328 1483328 0 0.0
light-app default (read only) 890432 890432 0 0.0
(read/write) 1560260 1560260 0 0.0
.bss 140464 140464 0 0.0
.data 2448 2448 0 0.0
.text 1408960 1408960 0 0.0
lock-app default (read only) 885936 885936 0 0.0
(read/write) 1597540 1597540 0 0.0
.bss 144944 144944 0 0.0
.data 2464 2464 0 0.0
.text 1441744 1441744 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808416 0 0.0
bss 71096 71096 0 0.0
noinit 43488 43488 0 0.0
text 571344 571344 0 0.0
lighting-app tlsr9518adk80d (read/write) 830352 830352 0 0.0
bss 71952 71952 0 0.0
noinit 43488 43488 0 0.0
text 589436 589436 0 0.0

@andy31415 andy31415 merged commit 39f525e into sve-2 Aug 17, 2022
@andy31415 andy31415 deleted the cherry-pick-4b2de040ec8ecd8f7cd99e3fad4498542eb5c3d6 branch August 17, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants