-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync fan device type with specs #21923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex and
harsha-rajendran
August 16, 2022 11:46
pullapprove
bot
requested review from
yufengwangca,
vivien-apple,
yunhanw-google,
wbschiller,
woody-apple and
xylophone21
August 16, 2022 11:46
dhrishi
reviewed
Aug 16, 2022
PR #21923: Size comparison from 5a05207 to 7ccda8a Increases (1 build for cc13x2_26x2)
Decreases (3 builds for cc13x2_26x2, cyw30739, nrfconnect)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Aug 16, 2022
PR #21923: Size comparison from 5a05207 to 029f0ee Increases (2 builds for cc13x2_26x2, esp32)
Decreases (1 build for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Aug 16, 2022
dhrishi
approved these changes
Aug 16, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
* Sync fan device type with specs * Addressed review comments
woody-apple
added a commit
that referenced
this pull request
Aug 16, 2022
* Sync fan device type with specs * Addressed review comments Co-authored-by: Rohit Jadhav <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Sync fan device type with specs * Addressed review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Added fan device type to sync with specs
Testing
How was this tested? (at least one bullet point required)