-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] Loader script: Flash length fixed. #21884
Merged
woody-apple
merged 1 commit into
project-chip:master
from
rcasallas-silabs:efr32xg24_ldscript
Aug 15, 2022
Merged
[EFR32] Loader script: Flash length fixed. #21884
woody-apple
merged 1 commit into
project-chip:master
from
rcasallas-silabs:efr32xg24_ldscript
Aug 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
August 15, 2022 13:22
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
August 15, 2022 13:22
pullapprove
bot
added
review - pending
examples
platform
and removed
examples
platform
labels
Aug 15, 2022
rcasallas-silabs
force-pushed
the
efr32xg24_ldscript
branch
from
August 15, 2022 13:23
903596d
to
9bf7675
Compare
jmartinez-silabs
approved these changes
Aug 15, 2022
PR #21884: Size comparison from 89232c5 to 9bf7675 Increases (3 builds for efr32, esp32, telink)
Decreases (1 build for nrfconnect)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The length of the main flash is off by one page: 0x8180000 - 0x08006000 = 0x17A000, not 0x178000.
This offset affect the location of the attestation credentials.
Change overview
Flash length fixed for EFR32MG24.
Testing
EFR32MG24 device commissioned correctly. Attestation address verified using the ARM debugger.