Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin: change crypto to boringssl from mbedtls #21865

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Darwin: change crypto to boringssl from mbedtls #21865

merged 1 commit into from
Aug 15, 2022

Conversation

jtung-apple
Copy link
Contributor

Problem

For Issue #20955 - move to boringssl instead of mbedtls

Change overview

Changed chip_xcode_build_connector.sh to use boringssl, and removed references to mbedtls in the Matter Xcode project file.

Testing

  • Built darwin-framework-tool
  • Built CHIPTool+Matter framework in Xcode

nivi-apple
nivi-apple approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@nivi-apple nivi-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@github-actions
Copy link

github-actions bot commented Aug 12, 2022 •
edited
Loading

PR #21865: Size comparison from 0888818 to 6a1b352

Increases (2 builds for cc13x2_26x2, telink)
platform target config section 0888818 6a1b352 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 180940 180948 8 0.0
telink lighting-app tlsr9518adk80d text 588922 588924 2 0.0
Decreases (3 builds for cc13x2_26x2, esp32, k32w)
platform target config section 0888818 6a1b352 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 656403 656395 -8 -0.0
.text 554288 554280 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1027158 1027154 -4 -0.0
.flash.text 1027158 1027154 -4 -0.0
k32w lock k32w0+release (read/write) 702180 702164 -16 -0.0
.text 627128 627112 -16 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0888818 6a1b352 change % change
bl602 lighting-app bl602 (read/write) 1382106 1382106 0 0.0
.bss 119834 119834 0 0.0
.data 4480 4480 0 0.0
.text 1049916 1049916 0 0.0
bl602+rpc (read/write) 1427346 1427346 0 0.0
.bss 127274 127274 0 0.0
.data 4600 4600 0 0.0
.text 1081420 1081420 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 671879 671879 0 0.0
(read/write) 179584 179584 0 0.0
.bss 74356 74356 0 0.0
.data 3372 3372 0 0.0
.rodata 88607 88607 0 0.0
.text 582956 582956 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637263 637263 0 0.0
(read/write) 157932 157932 0 0.0
.bss 73644 73644 0 0.0
.data 3372 3372 0 0.0
.rodata 77855 77855 0 0.0
.text 559084 559084 0 0.0
lock-ftd LP_CC2652R7 (read only) 673659 673659 0 0.0
(read/write) 167996 167996 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 76547 76547 0 0.0
.text 596632 596632 0 0.0
lock-mtd LP_CC2652R7 (read only) 656403 656395 -8 -0.0
(read/write) 180940 180948 8 0.0
.bss 67124 67124 0 0.0
.data 3296 3296 0 0.0
.rodata 101635 101635 0 0.0
.text 554288 554280 -8 -0.0
pump-app LP_CC2652R7 (read only) 684203 684203 0 0.0
(read/write) 158260 158260 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 89699 89699 0 0.0
.text 594020 594020 0 0.0
pump-controller-app LP_CC2652R7 (read only) 668671 668671 0 0.0
(read/write) 173912 173912 0 0.0
.bss 71596 71596 0 0.0
.data 3292 3292 0 0.0
.rodata 85247 85247 0 0.0
.text 582944 582944 0 0.0
shell LP_CC2652R7 (read only) 664578 664578 0 0.0
(read/write) 182404 182404 0 0.0
.bss 76676 76676 0 0.0
.data 3376 3376 0 0.0
.rodata 85554 85554 0 0.0
.text 578708 578708 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585702 585702 0 0.0
.app_xip_area 462416 462416 0 0.0
.bss 65728 65728 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591502 591502 0 0.0
.app_xip_area 463432 463432 0 0.0
.bss 70512 70512 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598338 598338 0 0.0
.app_xip_area 475772 475772 0 0.0
.bss 65040 65040 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1098900 1098900 0 0.0
.bss 132932 132932 0 0.0
.data 2068 2068 0 0.0
.text 963876 963876 0 0.0
BRD4161A+rpc (read/write) 1153180 1153180 0 0.0
.bss 149620 149620 0 0.0
.data 2280 2280 0 0.0
.text 1001260 1001260 0 0.0
BRD4161A+rs911x (read/write) 988324 988324 0 0.0
.bss 162272 162272 0 0.0
.data 2056 2056 0 0.0
.text 823976 823976 0 0.0
lock-app BRD4161A+wf200 (read/write) 1138516 1138516 0 0.0
.bss 145448 145448 0 0.0
.data 2064 2064 0 0.0
.text 990984 990984 0 0.0
window-app BRD4161A (read/write) 1090352 1090352 0 0.0
.bss 134364 134364 0 0.0
.data 2096 2096 0 0.0
.text 953872 953872 0 0.0
esp32 all-clusters-app c3devkit (read only) 1027158 1027154 -4 -0.0
(read/write) 1487938 1487938 0 0.0
.dram0.bss 70432 70432 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217472 217472 0 0.0
.flash.text 1027158 1027154 -4 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1080523 1080523 0 0.0
(read/write) 489896 489896 0 0.0
.dram0.bss 75936 75936 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247820 247820 0 0.0
.flash.text 1075139 1075139 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644708 644708 0 0.0
.bss 69800 69800 0 0.0
.data 2044 2044 0 0.0
.text 570136 570136 0 0.0
lock k32w0+release (read/write) 702180 702164 -16 -0.0
.bss 70272 70272 0 0.0
.data 2052 2052 0 0.0
.text 627128 627112 -16 -0.0
linux all-clusters-app debug (read only) 3030865 3030865 0 0.0
(read/write) 155856 155856 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85496 85496 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 273931 273931 0 0.0
.text 2577810 2577810 0 0.0
all-clusters-minimal-app debug (read only) 2870689 2870689 0 0.0
(read/write) 147592 147592 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78088 78088 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274091 274091 0 0.0
.text 2420178 2420178 0 0.0
bridge-app debug+rpc (read only) 2369577 2369577 0 0.0
(read/write) 127520 127520 0 0.0
.bss 50624 50624 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67432 67432 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202952 202952 0 0.0
.text 2003954 2003954 0 0.0
chip-tool debug (read only) 10658249 10658249 0 0.0
(read/write) 650880 650880 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 615864 615864 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 552245 552245 0 0.0
.text 8600164 8600164 0 0.0
chip-tool-ipv6only arm64 (read only) 10068468 10068468 0 0.0
(read/write) 698641 698641 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643392 643392 0 0.0
.dynamic 560 560 0 0.0
.got 13712 13712 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 483284 483284 0 0.0
.text 7948196 7948196 0 0.0
lighting-app debug+rpc (read only) 2593593 2593593 0 0.0
(read/write) 130144 130144 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72328 72328 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 219728 219728 0 0.0
.text 2203106 2203106 0 0.0
lock-app debug (read only) 2577505 2577505 0 0.0
(read/write) 125480 125480 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69480 69480 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 236784 236784 0 0.0
.text 2174018 2174018 0 0.0
ota-provider-app debug (read only) 2354633 2354633 0 0.0
(read/write) 118944 118944 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63304 63304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 208728 208728 0 0.0
.text 1982386 1982386 0 0.0
ota-requestor-app debug (read only) 2520361 2520361 0 0.0
(read/write) 127256 127256 0 0.0
.bss 50304 50304 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68696 68696 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 215488 215488 0 0.0
.text 2132258 2132258 0 0.0
shell debug (read only) 2599185 2599185 0 0.0
(read/write) 141976 141976 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77096 77096 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 234066 234066 0 0.0
.text 2206722 2206722 0 0.0
thermostat-no-ble arm64 (read only) 2354308 2354308 0 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75952 75952 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140156 140156 0 0.0
.text 1976448 1976448 0 0.0
tv-app debug (read only) 3171425 3171425 0 0.0
(read/write) 257936 257936 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79176 79176 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 258728 258728 0 0.0
.text 2722834 2722834 0 0.0
tv-casting-app debug (read only) 5411825 5411825 0 0.0
(read/write) 159056 159056 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98736 98736 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 341937 341937 0 0.0
.text 4801490 4801490 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453832 2453832 0 0.0
.bss 214644 214644 0 0.0
.data 5872 5872 0 0.0
.text 1416476 1416476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179467 1179467 0 0.0
bss 143302 143302 0 0.0
rodata 143180 143180 0 0.0
text 814088 814088 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159363 1159363 0 0.0
bss 142540 142540 0 0.0
rodata 134876 134876 0 0.0
text 803076 803076 0 0.0
p6 all-clusters-app default (read only) 881440 881440 0 0.0
(read/write) 1696140 1696140 0 0.0
.bss 149248 149248 0 0.0
.data 2656 2656 0 0.0
.text 1535848 1535848 0 0.0
all-clusters-minimal-app default (read only) 882160 882160 0 0.0
(read/write) 1640180 1640180 0 0.0
.bss 148528 148528 0 0.0
.data 2656 2656 0 0.0
.text 1480608 1480608 0 0.0
light-app default (read only) 890480 890480 0 0.0
(read/write) 1558860 1558860 0 0.0
.bss 140416 140416 0 0.0
.data 2448 2448 0 0.0
.text 1407608 1407608 0 0.0
lock-app default (read only) 885984 885984 0 0.0
(read/write) 1596028 1596028 0 0.0
.bss 144896 144896 0 0.0
.data 2464 2464 0 0.0
.text 1440280 1440280 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 807624 807624 0 0.0
bss 71048 71048 0 0.0
noinit 43488 43488 0 0.0
text 570844 570844 0 0.0
lighting-app tlsr9518adk80d (read/write) 829552 829552 0 0.0
bss 71904 71904 0 0.0
noinit 43488 43488 0 0.0
text 588922 588924 2 0.0

@woody-apple woody-apple enabled auto-merge (squash) August 15, 2022 23:18
@woody-apple woody-apple merged commit eea0c53 into project-chip:master Aug 15, 2022
@jtung-apple jtung-apple mentioned this pull request Aug 16, 2022
Closed
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@jtung-apple @isiu-apple
Issue 20955 change darwin crypto to boringssl from mbedtls (project-c…
e438213 
…hip#21865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivi-apple nivi-apple nivi-apple approved these changes

@emargolis emargolis emargolis approved these changes

@woody-apple woody-apple Awaiting requested review from woody-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtung-apple @emargolis @nivi-apple @woody-apple