Fix logic error in FreeRTOSNewlibLockSupport_test.c #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspang
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
This tries to release a freed lock due to a typo. It seems the updated firmware image didn't get flashed when validating the previous change :(
mspang
force-pushed
the
for-chip/fix-lock-free
branch
from
797de0d to
9f10829
Compare
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Aug 16, 2020
As of b15c292 ("[nrf5-lock] start joiner role on boot (project-chip#1962)"), we are using too much stack space in timer task. The timer task has a 1k stack and logging along uses a 256 byte stack buffer. The code in GenericThreadStackManagerImpl_FreeRTOS<ImplClass>::OnJoinerTimer should be moved off the timer task. In the meantime increase the stack size to avoid overruns in the thread joiner. Also enable the option configCHECK_FOR_STACK_OVERFLOW, and while we're here also enable configUSE_MALLOC_FAILED_HOOK. These diagnostic options are invaluable for saving debugging time. Since logging uses significant stack space, try to catch stack overflows in the platform LogV(). This fires reliably in OnJoinerTimer prior to enlarging the stack. Depends on project-chip#2185 Fixes project-chip#2187
|
Size increase report for "gn_nrf-example-build"
Full report output |
|
Size increase report for "gn_linux-example-build"
Full report output |
|
Size increase report for "nrf-example-build"
Full report output |
|
Size increase report for "nrfconnect-example-build"
Full report output |
|
Size increase report for "linux-example-build"
Full report output |
|
Size increase report for "esp32-example-build"
Full report output |
saurabhst
approved these changes
Aug 17, 2020
|
This fixes #2193 |
bukepo
approved these changes
Aug 17, 2020
andy31415
approved these changes
Aug 17, 2020
woody-apple
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to release a freed lock due to a typo. It seems the updated
firmware image didn't get flashed when validating the previous change :(