When a client detects subscription drop, mark sessions defunct. #21841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This marks defunct the session the subscripton is on, as well as any sessions that are "more stale" than it, in the sense of not having seen anything from the peer for at least as long. This should increase the chance that our next attempt to communicate with the peer will not use a stale session.
bzbarsky-apple
force-pushed
the
subscription-defunct-on-drop
branch
from
dce6c1c to
1a9a51b
Compare
mrjerryjohns
approved these changes
Aug 11, 2022
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic and
vijs
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #21841: Size comparison from c758e8b to 1a9a51b Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Aug 12, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ect-chip#21841) This marks defunct the session the subscripton is on, as well as any sessions that are "more stale" than it, in the sense of not having seen anything from the peer for at least as long. This should increase the chance that our next attempt to communicate with the peer will not use a stale session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks defunct the session the subscripton is on, as well as any sessions
that are "more stale" than it, in the sense of not having seen anything from the
peer for at least as long. This should increase the chance that our next
attempt to communicate with the peer will not use a stale session.
Problem
Possible to have a stale session until a send attempt fails (and then we mark it defunct).
Change overview
Mark sessions defunct on subscription drop.
Testing
Created a subscription with resubscription disabled from chip-tool to all-clusters-app, then
kill -9on the all-clusters-app and restarted it. After the subscription timed out, tried to establish it again.Before this PR, this re-establishment attempt timed out (and the next one succeeded). After this PR, we re-establish CASE on the subscription re-establishment attempt.