Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Fix RPC console install #21837

Merged
merged 1 commit into from
Aug 15, 2022
Merged

RPC: Fix RPC console install #21837

merged 1 commit into from
Aug 15, 2022

Conversation

rgoliver
Copy link

Problem

rpc console is not including proto dependencies

~/connectedhomeip% chip-console                       
Traceback (most recent call last):
  File "/home/spang/connectedhomeip/.environment/pigweed-venv/bin/chip-console", line 5, in <module>
    from chip_rpc.console import main
  File "/ssd/src/connectedhomeip/examples/common/pigweed/rpc_console/py/chip_rpc/console.py", line 66, in <module>
    from attributes_service import attributes_service_pb2
ModuleNotFoundError: No module named 'attributes_service'

Change overview

Use chip_rpc_distribution which includes the proto dependencies.

Testing

clean bootstrap, and started console.

RPC: Fix RPC console install
ba26281 
Was not properly including the proto files, fix to have them
included.
@github-actions
Copy link

github-actions bot commented Aug 11, 2022 •
edited
Loading

PR #21837: Size comparison from 1845133 to ba26281

Increases (1 build for esp32)
platform target config section 1845133 ba26281 change % change
esp32 all-clusters-app c3devkit (read only) 1026542 1026544 2 0.0
.flash.text 1026542 1026544 2 0.0
Decreases (4 builds for bl602, efr32, telink)
platform target config section 1845133 ba26281 change % change
bl602 lighting-app bl602 (read/write) 1380642 1380634 -8 -0.0
.text 1048712 1048708 -4 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1137068 1137052 -16 -0.0
.text 990144 990128 -16 -0.0
telink light-switch-app tlsr9518adk80d text 570244 570242 -2 -0.0
lighting-app tlsr9518adk80d text 588322 588320 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1845133 ba26281 change % change
bl602 lighting-app bl602 (read/write) 1380642 1380634 -8 -0.0
.bss 119762 119762 0 0.0
.data 4480 4480 0 0.0
.text 1048712 1048708 -4 -0.0
bl602+rpc (read/write) 1425890 1425890 0 0.0
.bss 127202 127202 0 0.0
.data 4600 4600 0 0.0
.text 1080212 1080212 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 671367 671367 0 0.0
(read/write) 180024 180024 0 0.0
.bss 74284 74284 0 0.0
.data 3372 3372 0 0.0
.rodata 88559 88559 0 0.0
.text 582492 582492 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636759 636759 0 0.0
(read/write) 157860 157860 0 0.0
.bss 73572 73572 0 0.0
.data 3372 3372 0 0.0
.rodata 77815 77815 0 0.0
.text 558620 558620 0 0.0
lock-ftd LP_CC2652R7 (read only) 673115 673115 0 0.0
(read/write) 168468 168468 0 0.0
.bss 71364 71364 0 0.0
.data 3296 3296 0 0.0
.rodata 76499 76499 0 0.0
.text 596136 596136 0 0.0
lock-mtd LP_CC2652R7 (read only) 655723 655723 0 0.0
(read/write) 181548 181548 0 0.0
.bss 67052 67052 0 0.0
.data 3296 3296 0 0.0
.rodata 101451 101451 0 0.0
.text 553792 553792 0 0.0
pump-app LP_CC2652R7 (read only) 683355 683355 0 0.0
(read/write) 159036 159036 0 0.0
.bss 71404 71404 0 0.0
.data 3296 3296 0 0.0
.rodata 89395 89395 0 0.0
.text 593476 593476 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667807 667807 0 0.0
(read/write) 174704 174704 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84943 84943 0 0.0
.text 582384 582384 0 0.0
shell LP_CC2652R7 (read only) 664050 664050 0 0.0
(read/write) 182860 182860 0 0.0
.bss 76604 76604 0 0.0
.data 3376 3376 0 0.0
.rodata 85506 85506 0 0.0
.text 578228 578228 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585166 585166 0 0.0
.app_xip_area 461952 461952 0 0.0
.bss 65656 65656 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590966 590966 0 0.0
.app_xip_area 462968 462968 0 0.0
.bss 70440 70440 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 597642 597642 0 0.0
.app_xip_area 475148 475148 0 0.0
.bss 64968 64968 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1097340 1097340 0 0.0
.bss 132860 132860 0 0.0
.data 2068 2068 0 0.0
.text 962388 962388 0 0.0
BRD4161A+rpc (read/write) 1151604 1151604 0 0.0
.bss 149548 149548 0 0.0
.data 2280 2280 0 0.0
.text 999756 999756 0 0.0
BRD4161A+rs911x (read/write) 986748 986748 0 0.0
.bss 162200 162200 0 0.0
.data 2056 2056 0 0.0
.text 822472 822472 0 0.0
lock-app BRD4161A+wf200 (read/write) 1137068 1137052 -16 -0.0
.bss 144840 144840 0 0.0
.data 2064 2064 0 0.0
.text 990144 990128 -16 -0.0
window-app BRD4161A (read/write) 1088776 1088776 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 952368 952368 0 0.0
esp32 all-clusters-app c3devkit (read only) 1026542 1026544 2 0.0
(read/write) 1487570 1487570 0 0.0
.dram0.bss 70360 70360 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217168 217168 0 0.0
.flash.text 1026542 1026544 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079875 1079875 0 0.0
(read/write) 489528 489528 0 0.0
.dram0.bss 75864 75864 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247524 247524 0 0.0
.flash.text 1074491 1074491 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644076 644076 0 0.0
.bss 69728 69728 0 0.0
.data 2044 2044 0 0.0
.text 569576 569576 0 0.0
lock k32w0+release (read/write) 701364 701364 0 0.0
.bss 70200 70200 0 0.0
.data 2052 2052 0 0.0
.text 626384 626384 0 0.0
linux all-clusters-app debug (read only) 3028281 3028281 0 0.0
(read/write) 155760 155760 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85416 85416 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 273643 273643 0 0.0
.text 2575682 2575682 0 0.0
all-clusters-minimal-app debug (read only) 2868105 2868105 0 0.0
(read/write) 147496 147496 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 273803 273803 0 0.0
.text 2418050 2418050 0 0.0
bridge-app debug+rpc (read only) 2366929 2366929 0 0.0
(read/write) 127456 127456 0 0.0
.bss 50624 50624 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202600 202600 0 0.0
.text 2001826 2001826 0 0.0
chip-tool debug (read only) 10657601 10657601 0 0.0
(read/write) 650432 650432 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 615784 615784 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 552373 552373 0 0.0
.text 8599460 8599460 0 0.0
chip-tool-ipv6only arm64 (read only) 10067164 10067164 0 0.0
(read/write) 698177 698177 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643344 643344 0 0.0
.dynamic 560 560 0 0.0
.got 13688 13688 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 482780 482780 0 0.0
.text 7947540 7947540 0 0.0
lighting-app debug+rpc (read only) 2590945 2590945 0 0.0
(read/write) 130048 130048 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 219376 219376 0 0.0
.text 2200978 2200978 0 0.0
lock-app debug (read only) 2574921 2574921 0 0.0
(read/write) 125416 125416 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 236496 236496 0 0.0
.text 2171890 2171890 0 0.0
ota-provider-app debug (read only) 2352049 2352049 0 0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 208440 208440 0 0.0
.text 1980258 1980258 0 0.0
ota-requestor-app debug (read only) 2517745 2517745 0 0.0
(read/write) 127192 127192 0 0.0
.bss 50304 50304 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68632 68632 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 215168 215168 0 0.0
.text 2130130 2130130 0 0.0
shell debug (read only) 2596601 2596601 0 0.0
(read/write) 141912 141912 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 233778 233778 0 0.0
.text 2204594 2204594 0 0.0
thermostat-no-ble arm64 (read only) 2352012 2352012 0 0.0
(read/write) 141681 141681 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75880 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139828 139828 0 0.0
.text 1974656 1974656 0 0.0
tv-app debug (read only) 3170361 3170361 0 0.0
(read/write) 257872 257872 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 258376 258376 0 0.0
.text 2722194 2722194 0 0.0
tv-casting-app debug (read only) 5411049 5411049 0 0.0
(read/write) 158992 158992 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98672 98672 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 341649 341649 0 0.0
.text 4801074 4801074 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452976 2452976 0 0.0
.bss 214572 214572 0 0.0
.data 5872 5872 0 0.0
.text 1415620 1415620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178535 1178535 0 0.0
bss 143230 143230 0 0.0
rodata 142888 142888 0 0.0
text 813580 813580 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1158555 1158555 0 0.0
bss 142468 142468 0 0.0
rodata 134580 134580 0 0.0
text 802568 802568 0 0.0
p6 all-clusters-app default (read only) 881512 881512 0 0.0
(read/write) 1694516 1694516 0 0.0
.bss 149176 149176 0 0.0
.data 2656 2656 0 0.0
.text 1534296 1534296 0 0.0
all-clusters-minimal-app default (read only) 882232 882232 0 0.0
(read/write) 1638556 1638556 0 0.0
.bss 148456 148456 0 0.0
.data 2656 2656 0 0.0
.text 1479056 1479056 0 0.0
light-app default (read only) 890552 890552 0 0.0
(read/write) 1557244 1557244 0 0.0
.bss 140344 140344 0 0.0
.data 2448 2448 0 0.0
.text 1406064 1406064 0 0.0
lock-app default (read only) 886056 886056 0 0.0
(read/write) 1594412 1594412 0 0.0
.bss 144824 144824 0 0.0
.data 2464 2464 0 0.0
.text 1438736 1438736 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806648 806648 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 570244 570242 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 828576 828576 0 0.0
bss 71832 71832 0 0.0
noinit 43488 43488 0 0.0
text 588322 588320 -2 -0.0

@rgoliver rgoliver merged commit 89232c5 into project-chip:master Aug 15, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@isiu-apple
RPC: Fix RPC console install (project-chip#21837)
26ee04f 
Was not properly including the proto files, fix to have them
included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples gn review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgoliver @mrjerryjohns @bzbarsky-apple @jmartinez-silabs