-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return CHIP_ERROR_WELL_UNINITIALIZED when object is not initialized #21827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
robszewczyk
August 11, 2022 11:44
pullapprove
bot
requested review from
woody-apple,
xylophone21 and
yufengwangca
August 11, 2022 11:44
pullapprove
bot
added
review - pending
and removed
examples
platform
efr32
crypto
controller
labels
Aug 11, 2022
PR #21827: Size comparison from f2bbce7 to 5956f7d Increases (4 builds for bl602, cc13x2_26x2, efr32, telink)
Decreases (3 builds for cc13x2_26x2, esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Aug 11, 2022
Damian-Nordic
approved these changes
Aug 12, 2022
arkq
force-pushed
the
error-uninitalized
branch
from
August 12, 2022 11:14
5956f7d
to
d348a4f
Compare
Rebased (resolved conflict) |
PR #21827: Size comparison from afd4ab7 to d348a4f Increases (2 builds for bl602, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It seems that we've got a dedicated error code for cases when someone calls a method on an object which is not initialized. The The CHIP_ERROR_INCORRECT_STATE is correct, but I think that CHIP_ERROR_WELL_UNINITIALIZED fits better for that purpose.
Change overview
Testing
CI will check that.