-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TC_DA_1_7.py that was merged in wrong location #21813
Merged
woody-apple
merged 1 commit into
project-chip:master
from
tcarmelveilleux:move-tc-da-1.7
Aug 16, 2022
Merged
Move TC_DA_1_7.py that was merged in wrong location #21813
woody-apple
merged 1 commit into
project-chip:master
from
tcarmelveilleux:move-tc-da-1.7
Aug 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Due to switching between several environments, PR project-chip#21175 had TC_DA_1_7.py in the root of the project rather than `src/python_testing` like other tests. This PR moves the file to its correct location. All prior testing was done with the root location (I checked my command history), so it is the correct code/test, but committed in the wrong place.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
August 11, 2022 02:36
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
August 11, 2022 02:36
PR #21813: Size comparison from 8cf3894 to 82397d5 Increases (2 builds for cc13x2_26x2, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
emargolis
approved these changes
Aug 11, 2022
arkq
approved these changes
Aug 11, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
- Due to switching between several environments, PR project-chip#21175 had TC_DA_1_7.py in the root of the project rather than `src/python_testing` like other tests. This PR moves the file to its correct location. All prior testing was done with the root location (I checked my command history), so it is the correct code/test, but committed in the wrong place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
had TC_DA_1_7.py in the root of the project rather than
src/python_testing
like other tests.Change overview
This PR moves the file to its correct location.
Testing
All prior testing was done with the root location (I checked
my command history), so it is the correct code/test, but
committed in the wrong place.