Make the timing inside on-off server cluster more accurate #21755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #21755: Size comparison from 3439ad3 to 64ef06d Increases (27 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
Decreases (8 builds for cc13x2_26x2, cyw30739, p6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
force-pushed
the
eve/onoff-timing
branch
from
64ef06d to
34db50d
Compare
woody-apple
approved these changes
Aug 9, 2022
bzbarsky-apple
approved these changes
Aug 9, 2022
|
PR #21755: Size comparison from edaaaf2 to 34db50d Increases above 0.2%:
Increases (37 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (7 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Aug 10, 2022
woody-apple
force-pushed
the
eve/onoff-timing
branch
from
34db50d to
07d4723
Compare
…ating the latency between scheduling and firing a timer callback
… time stamp for the next state machine step. This variable gets adjusted by UPDATE_TIME_MS and the wait time gets calculated by UPDATE_TIME_MS - last latency
woody-apple
force-pushed
the
eve/onoff-timing
branch
from
07d4723 to
914248b
Compare
|
PR #21755: Size comparison from 397d642 to 0fdcb4d Increases above 0.2%:
Increases (36 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (8 builds for cc13x2_26x2, p6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…hip#21755) * Make the timing inside on-off server cluster more accurate by compensating the latency between scheduling and firing a timer callback * debug output line removed * even simpler: nextDesiredOnWithTimedOffTimestamp reflects the desired time stamp for the next state machine step. This variable gets adjusted by UPDATE_TIME_MS and the wait time gets calculated by UPDATE_TIME_MS - last latency * Fixing style Co-authored-by: Justin Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The original approach was to always wait 100ms between timer callbacks for counting down an attribute. Due to latencies within the system the real elapsed time is typically higher than 100ms. In some embedded systems it is even up to 25% higher. This leads into very inaccurate values of time-based attributes and thus has a bad user experience.
Change overview
In the PR we do our best to compensate the system latency by having a timeline with fixed 100ms intervals instead of simple 100ms delays without knowing anything about system latencies
Testing
Perform the latest version of the TC-OO-2.3 test case which succeeds now.
Running this code change on a nRF52 platform